Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](cloud) fix analyze compound predicate exception when show copy #37656

Merged
merged 1 commit into from
Jul 12, 2024
Merged

[fix](cloud) fix analyze compound predicate exception when show copy #37656

merged 1 commit into from
Jul 12, 2024

Conversation

sollhui
Copy link
Contributor

@sollhui sollhui commented Jul 11, 2024

Bug report:

mysql> show copy where id='e66c0eb7372b4c80-8781ffff29e0fd85' and tablename ='test_delete_on' and files like 'test_delete_on.json' and state='finished'\G
ERROR 1105 (HY000): errCode = 2, detailMessage = Unexpected exception: class org.apache.doris.analysis.CompoundPredicate cannot be cast to class org.apache.doris.analysis.SlotRef (org.apache.doris.analysis.CompoundPredicate and org.apache.doris.analysis.SlotRef are in unnamed module of loader 'app')

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@sollhui
Copy link
Contributor Author

sollhui commented Jul 11, 2024

run buildall

liaoxin01
liaoxin01 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 39519 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a73e65d2dfe95a301be8a595a1d98ad78e5c5bb9, data reload: false

------ Round 1 ----------------------------------
q1	17635	4341	4257	4257
q2	2005	189	193	189
q3	10442	1150	1048	1048
q4	10195	779	731	731
q5	7630	2686	2628	2628
q6	216	138	138	138
q7	944	593	590	590
q8	9324	2060	2053	2053
q9	8799	6526	6515	6515
q10	8628	3743	3734	3734
q11	457	240	239	239
q12	454	229	223	223
q13	17784	2976	2969	2969
q14	270	234	237	234
q15	533	488	471	471
q16	482	374	380	374
q17	952	603	652	603
q18	7939	7487	7316	7316
q19	5860	1533	1375	1375
q20	687	323	317	317
q21	4966	3177	3751	3177
q22	399	338	345	338
Total cold run time: 116601 ms
Total hot run time: 39519 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4342	4235	4230	4230
q2	382	274	273	273
q3	2957	2781	2858	2781
q4	1980	1747	1725	1725
q5	5705	5581	5510	5510
q6	217	130	133	130
q7	2180	1906	1855	1855
q8	3222	3367	3415	3367
q9	8727	8781	8896	8781
q10	4046	3929	3787	3787
q11	590	522	508	508
q12	809	608	604	604
q13	16031	3158	3177	3158
q14	313	294	292	292
q15	555	501	476	476
q16	489	425	436	425
q17	1828	1519	1539	1519
q18	8126	8090	7801	7801
q19	2205	1554	1546	1546
q20	2110	1893	1868	1868
q21	5063	4900	4750	4750
q22	624	572	577	572
Total cold run time: 72501 ms
Total hot run time: 55958 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 175285 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a73e65d2dfe95a301be8a595a1d98ad78e5c5bb9, data reload: false

query1	917	382	365	365
query2	6465	2392	2359	2359
query3	6631	208	215	208
query4	28497	17516	17386	17386
query5	3669	474	480	474
query6	265	188	168	168
query7	4592	290	298	290
query8	329	292	298	292
query9	8552	2420	2407	2407
query10	430	285	269	269
query11	10605	10067	10062	10062
query12	118	93	82	82
query13	1636	395	365	365
query14	10182	7724	7724	7724
query15	241	187	189	187
query16	7886	315	301	301
query17	1824	546	540	540
query18	2056	272	290	272
query19	197	145	150	145
query20	91	79	82	79
query21	208	127	127	127
query22	4489	4112	4283	4112
query23	34092	33802	33993	33802
query24	10976	2883	2936	2883
query25	622	426	402	402
query26	1157	152	146	146
query27	2449	275	276	275
query28	7318	2133	2126	2126
query29	902	653	636	636
query30	254	152	152	152
query31	1000	753	758	753
query32	101	53	61	53
query33	752	288	296	288
query34	1043	496	501	496
query35	720	599	625	599
query36	1150	981	968	968
query37	159	83	82	82
query38	2982	2810	2932	2810
query39	852	818	815	815
query40	208	116	123	116
query41	51	51	54	51
query42	117	97	96	96
query43	590	555	547	547
query44	1275	726	729	726
query45	200	164	166	164
query46	1117	753	728	728
query47	1860	1768	1768	1768
query48	371	293	305	293
query49	853	399	412	399
query50	776	382	389	382
query51	7021	6886	6776	6776
query52	117	90	96	90
query53	359	289	289	289
query54	883	450	448	448
query55	76	72	74	72
query56	289	267	266	266
query57	1115	1062	1051	1051
query58	243	240	261	240
query59	3354	3306	3121	3121
query60	307	280	278	278
query61	96	98	96	96
query62	810	642	626	626
query63	326	285	297	285
query64	9433	2217	1691	1691
query65	3160	3093	3141	3093
query66	767	337	331	331
query67	15321	14996	14961	14961
query68	4474	543	548	543
query69	530	391	355	355
query70	1120	1130	1090	1090
query71	422	269	280	269
query72	6886	5835	5959	5835
query73	736	323	324	323
query74	5951	5465	5503	5465
query75	3376	2695	2696	2695
query76	2163	936	916	916
query77	436	308	301	301
query78	10282	8959	8856	8856
query79	2470	529	521	521
query80	2075	498	466	466
query81	584	219	220	219
query82	896	136	135	135
query83	320	173	167	167
query84	276	87	89	87
query85	1652	319	305	305
query86	468	320	306	306
query87	3296	3075	3081	3075
query88	4221	2370	2361	2361
query89	478	399	385	385
query90	1762	201	199	199
query91	134	111	101	101
query92	61	52	51	51
query93	2494	508	499	499
query94	1128	215	212	212
query95	406	313	322	313
query96	602	276	271	271
query97	3189	3034	3030	3030
query98	221	206	199	199
query99	1600	1251	1268	1251
Total cold run time: 282213 ms
Total hot run time: 175285 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.69 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a73e65d2dfe95a301be8a595a1d98ad78e5c5bb9, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.67	0.07	0.07
query5	0.50	0.49	0.50
query6	1.14	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.05	0.04
query9	0.55	0.49	0.49
query10	0.55	0.55	0.55
query11	0.16	0.12	0.12
query12	0.15	0.12	0.13
query13	0.62	0.59	0.60
query14	0.78	0.78	0.79
query15	0.86	0.82	0.81
query16	0.34	0.37	0.36
query17	0.96	0.96	0.97
query18	0.23	0.22	0.21
query19	1.87	1.69	1.71
query20	0.01	0.01	0.02
query21	15.39	0.76	0.66
query22	4.57	7.46	2.02
query23	18.22	1.38	1.32
query24	2.12	0.22	0.23
query25	0.16	0.08	0.08
query26	0.31	0.22	0.21
query27	0.45	0.23	0.24
query28	13.21	1.01	1.01
query29	12.58	3.30	3.28
query30	0.25	0.05	0.05
query31	2.87	0.38	0.39
query32	3.27	0.48	0.49
query33	2.97	2.86	2.89
query34	17.37	4.31	4.36
query35	4.44	4.40	4.39
query36	0.66	0.47	0.49
query37	0.18	0.16	0.15
query38	0.15	0.15	0.14
query39	0.04	0.03	0.03
query40	0.15	0.12	0.13
query41	0.11	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.38 s
Total hot run time: 30.69 s

dataroaring
dataroaring approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 42defe6 into apache:master Jul 12, 2024
27 of 30 checks passed
@sollhui sollhui deleted the cloud_show_copy_into branch July 15, 2024 03:59
seawinde pushed a commit to seawinde/doris that referenced this pull request Jul 17, 2024
@sollhui @seawinde
[fix](cloud) fix analyze compound predicate exception when show copy (a…
777cdbc 
…pache#37656)

Bug report:
```
mysql> show copy where id='e66c0eb7372b4c80-8781ffff29e0fd85' and tablename ='test_delete_on' and files like 'test_delete_on.json' and state='finished'\G
ERROR 1105 (HY000): errCode = 2, detailMessage = Unexpected exception: class org.apache.doris.analysis.CompoundPredicate cannot be cast to class org.apache.doris.analysis.SlotRef (org.apache.doris.analysis.CompoundPredicate and org.apache.doris.analysis.SlotRef are in unnamed module of loader 'app')
```
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
@sollhui @dataroaring
[fix](cloud) fix analyze compound predicate exception when show copy (#…
7446019 
…37656)

Bug report:
```
mysql> show copy where id='e66c0eb7372b4c80-8781ffff29e0fd85' and tablename ='test_delete_on' and files like 'test_delete_on.json' and state='finished'\G
ERROR 1105 (HY000): errCode = 2, detailMessage = Unexpected exception: class org.apache.doris.analysis.CompoundPredicate cannot be cast to class org.apache.doris.analysis.SlotRef (org.apache.doris.analysis.CompoundPredicate and org.apache.doris.analysis.SlotRef are in unnamed module of loader 'app')
```
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liaoxin01 liaoxin01 liaoxin01 approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sollhui @doris-robot @liaoxin01 @dataroaring