-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](compaction) Fix data race when fetching base compaction score from cloud tablet #38006
[fix](compaction) Fix data race when fetching base compaction score from cloud tablet #38006
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39785 ms
|
TPC-DS: Total hot run time: 172729 ms
|
ClickBench: Total hot run time: 30.64 s
|
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
…rom cloud tablet (#38006) ## Proposed changes When calculating base compaction score on cloud tablet, data race may cause rowset meta become nullptr and cause a crash. Therefore added a read lock as protection in this case.
Proposed changes
When calculating base compaction score on cloud tablet, data race may cause rowset meta become nullptr and cause a crash.
Therefore added a read lock as protection in this case.