Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](round) fix round decimal128 overflow #38106

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

cambyzju
Copy link
Contributor

After #37733, we found there are some BE UT failed.

And this new change already merged into branch-2.1 and branch-2.0, here back port to master

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@cambyzju
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39929 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3dd1388a25d7b879e980123462a5fe49e96e2b6a, data reload: false

------ Round 1 ----------------------------------
q1	17640	4345	4294	4294
q2	1998	190	190	190
q3	10469	1238	1123	1123
q4	10185	795	866	795
q5	7557	2711	2617	2617
q6	223	141	142	141
q7	973	603	598	598
q8	9220	2100	2069	2069
q9	8981	6584	6582	6582
q10	8708	3811	3740	3740
q11	457	242	251	242
q12	458	235	234	234
q13	17755	2992	3011	2992
q14	269	234	238	234
q15	527	485	494	485
q16	492	386	381	381
q17	985	663	701	663
q18	7934	7444	7317	7317
q19	7353	1422	1411	1411
q20	685	324	314	314
q21	4921	3226	3949	3226
q22	357	283	281	281
Total cold run time: 118147 ms
Total hot run time: 39929 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4406	4274	4275	4274
q2	385	265	275	265
q3	3023	2918	2923	2918
q4	2033	1763	1751	1751
q5	5636	5587	5488	5488
q6	219	134	131	131
q7	2275	1893	1856	1856
q8	3290	3475	3400	3400
q9	8861	8906	8792	8792
q10	4126	3727	3900	3727
q11	606	496	507	496
q12	828	653	613	613
q13	17174	3192	3169	3169
q14	308	299	306	299
q15	554	487	496	487
q16	496	463	440	440
q17	1818	1565	1513	1513
q18	8216	8188	7978	7978
q19	1761	1621	1635	1621
q20	2361	1938	1861	1861
q21	7868	4873	4733	4733
q22	593	525	521	521
Total cold run time: 76837 ms
Total hot run time: 56333 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 176230 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3dd1388a25d7b879e980123462a5fe49e96e2b6a, data reload: false

query1	916	376	379	376
query2	6443	1872	1793	1793
query3	6657	211	219	211
query4	24734	17381	17373	17373
query5	3676	500	509	500
query6	277	175	155	155
query7	4577	297	292	292
query8	235	196	194	194
query9	8504	2390	2355	2355
query10	433	278	277	277
query11	11339	10090	10013	10013
query12	115	89	82	82
query13	1631	366	365	365
query14	10128	7924	8669	7924
query15	223	168	169	168
query16	7597	311	309	309
query17	1362	551	534	534
query18	1753	274	270	270
query19	198	151	150	150
query20	98	78	82	78
query21	211	133	129	129
query22	4302	4106	4013	4013
query23	34103	33638	33754	33638
query24	11043	2937	2946	2937
query25	601	421	445	421
query26	708	162	153	153
query27	2314	278	281	278
query28	6019	2066	2069	2066
query29	910	637	643	637
query30	257	159	154	154
query31	953	761	763	761
query32	97	56	62	56
query33	654	305	303	303
query34	880	521	503	503
query35	717	644	605	605
query36	1164	982	951	951
query37	141	87	92	87
query38	3042	2904	2876	2876
query39	888	824	832	824
query40	198	126	124	124
query41	50	45	47	45
query42	123	102	103	102
query43	511	476	486	476
query44	1131	746	730	730
query45	204	167	164	164
query46	1096	742	733	733
query47	1852	1771	1750	1750
query48	380	298	302	298
query49	858	438	455	438
query50	787	395	397	395
query51	6990	6719	6790	6719
query52	110	94	96	94
query53	368	308	305	305
query54	892	462	453	453
query55	79	77	78	77
query56	316	296	296	296
query57	1135	1069	1047	1047
query58	264	266	258	258
query59	2886	2932	2839	2839
query60	334	301	295	295
query61	115	110	116	110
query62	808	635	637	635
query63	324	298	296	296
query64	9230	2309	6074	2309
query65	3177	3128	3120	3120
query66	759	344	344	344
query67	15889	14912	15049	14912
query68	7688	551	557	551
query69	695	537	372	372
query70	1190	1174	1206	1174
query71	527	295	282	282
query72	9447	5731	5738	5731
query73	789	324	326	324
query74	6159	5753	5686	5686
query75	4414	2732	2721	2721
query76	4441	978	993	978
query77	727	318	322	318
query78	9639	15805	9624	9624
query79	8262	543	534	534
query80	1588	477	483	477
query81	589	229	228	228
query82	264	141	134	134
query83	274	169	203	169
query84	275	87	84	84
query85	730	303	290	290
query86	377	312	310	310
query87	3340	3118	3119	3118
query88	5176	2371	2375	2371
query89	486	408	405	405
query90	2491	192	198	192
query91	132	103	102	102
query92	58	51	49	49
query93	1036	501	512	501
query94	1520	216	219	216
query95	420	311	357	311
query96	590	274	269	269
query97	3228	3040	3073	3040
query98	232	196	208	196
query99	1506	1303	1298	1298
Total cold run time: 289056 ms
Total hot run time: 176230 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.51 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3dd1388a25d7b879e980123462a5fe49e96e2b6a, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.03	0.04
query3	0.22	0.06	0.05
query4	1.67	0.07	0.10
query5	0.51	0.48	0.48
query6	1.13	0.72	0.72
query7	0.01	0.01	0.02
query8	0.05	0.04	0.04
query9	0.55	0.48	0.49
query10	0.53	0.54	0.55
query11	0.15	0.11	0.11
query12	0.14	0.13	0.12
query13	0.60	0.59	0.60
query14	0.79	0.78	0.79
query15	0.85	0.83	0.83
query16	0.37	0.35	0.36
query17	0.95	0.96	0.95
query18	0.22	0.22	0.21
query19	1.82	1.70	1.84
query20	0.02	0.01	0.01
query21	15.40	0.72	0.64
query22	4.02	7.73	1.78
query23	18.28	1.35	1.32
query24	2.10	0.24	0.22
query25	0.16	0.09	0.08
query26	0.31	0.22	0.21
query27	0.45	0.24	0.24
query28	13.26	1.03	1.01
query29	12.63	3.34	3.30
query30	0.26	0.05	0.05
query31	2.88	0.40	0.40
query32	3.24	0.48	0.47
query33	2.90	2.91	2.92
query34	17.09	4.35	4.36
query35	4.39	4.40	4.38
query36	0.66	0.50	0.47
query37	0.19	0.15	0.15
query38	0.15	0.14	0.14
query39	0.04	0.04	0.03
query40	0.16	0.12	0.12
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.47 s
Total hot run time: 30.51 s

Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 22, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cambyzju cambyzju merged commit 1d25dff into apache:master Jul 22, 2024
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.1-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants