Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](array-func)fix func array_enumerate_uniq with param is nullable return #38384

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

amorynan
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@amorynan
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39281 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d8ed629d9457cb4b71be75c75e7096c65202539b, data reload: false

------ Round 1 ----------------------------------
q1	17641	4351	4392	4351
q2	2022	203	197	197
q3	10423	1174	1104	1104
q4	10138	752	730	730
q5	7529	2692	2660	2660
q6	217	141	139	139
q7	958	588	590	588
q8	9232	1930	1879	1879
q9	8501	6586	6513	6513
q10	8847	3776	3766	3766
q11	449	247	248	247
q12	502	227	219	219
q13	17768	2998	2954	2954
q14	288	227	242	227
q15	523	488	495	488
q16	501	396	389	389
q17	946	665	652	652
q18	7937	7381	7349	7349
q19	5466	1032	1067	1032
q20	673	345	349	345
q21	4890	3228	3171	3171
q22	345	282	281	281
Total cold run time: 115796 ms
Total hot run time: 39281 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4473	4273	4199	4199
q2	375	279	271	271
q3	3031	2760	2824	2760
q4	1997	1692	1680	1680
q5	5588	5867	5575	5575
q6	235	131	132	131
q7	2184	1796	1853	1796
q8	3291	3430	3401	3401
q9	8796	8764	8851	8764
q10	4090	3948	3836	3836
q11	601	474	482	474
q12	830	626	636	626
q13	15907	3198	3163	3163
q14	324	302	297	297
q15	536	512	493	493
q16	485	432	457	432
q17	1788	1519	1523	1519
q18	8059	7992	7842	7842
q19	1776	1514	1485	1485
q20	2175	1849	1933	1849
q21	10300	4875	4912	4875
q22	579	483	496	483
Total cold run time: 77420 ms
Total hot run time: 55951 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172369 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d8ed629d9457cb4b71be75c75e7096c65202539b, data reload: false

query1	907	368	361	361
query2	6438	2020	1888	1888
query3	6645	203	215	203
query4	25957	17648	17427	17427
query5	3646	489	481	481
query6	284	159	160	159
query7	4572	293	293	293
query8	240	194	196	194
query9	8591	2426	2395	2395
query10	434	270	269	269
query11	12450	10097	9987	9987
query12	119	88	81	81
query13	1617	370	367	367
query14	10647	7466	6948	6948
query15	246	162	165	162
query16	7024	510	438	438
query17	922	546	530	530
query18	1911	284	280	280
query19	185	144	139	139
query20	89	85	82	82
query21	210	106	107	106
query22	4224	3969	3920	3920
query23	34192	33740	33465	33465
query24	11420	2940	2899	2899
query25	644	437	422	422
query26	1130	155	159	155
query27	2345	281	278	278
query28	7230	2069	2058	2058
query29	937	458	435	435
query30	259	157	158	157
query31	973	786	771	771
query32	96	54	70	54
query33	787	345	332	332
query34	936	488	505	488
query35	904	777	787	777
query36	1148	931	933	931
query37	141	89	91	89
query38	2959	2868	2818	2818
query39	936	818	822	818
query40	203	120	122	120
query41	48	48	50	48
query42	120	101	96	96
query43	523	465	472	465
query44	1226	722	729	722
query45	216	176	182	176
query46	1085	743	742	742
query47	1856	1776	1766	1766
query48	375	297	293	293
query49	866	414	449	414
query50	809	400	398	398
query51	6786	6740	6649	6649
query52	104	87	94	87
query53	254	191	180	180
query54	914	449	453	449
query55	75	76	74	74
query56	310	296	299	296
query57	1157	1042	1057	1042
query58	263	274	276	274
query59	2961	2715	2695	2695
query60	330	299	295	295
query61	119	119	118	118
query62	814	647	625	625
query63	223	180	181	180
query64	9661	2249	1705	1705
query65	3208	3150	3138	3138
query66	920	333	327	327
query67	15466	14816	14971	14816
query68	8670	563	572	563
query69	727	397	346	346
query70	1386	1154	1133	1133
query71	540	268	264	264
query72	9602	5259	6196	5259
query73	2250	322	326	322
query74	6116	5663	5680	5663
query75	5222	2640	2681	2640
query76	5289	903	940	903
query77	778	291	304	291
query78	10039	9702	8919	8919
query79	12777	534	522	522
query80	1348	489	487	487
query81	585	224	232	224
query82	436	131	134	131
query83	343	178	171	171
query84	269	77	81	77
query85	1137	306	315	306
query86	355	316	298	298
query87	3294	3103	3085	3085
query88	5140	2403	2410	2403
query89	490	278	277	277
query90	2079	195	194	194
query91	132	100	100	100
query92	65	50	47	47
query93	6901	561	559	559
query94	1110	282	289	282
query95	353	266	261	261
query96	623	277	270	270
query97	3169	3042	3031	3031
query98	221	209	214	209
query99	1649	1285	1342	1285
Total cold run time: 308382 ms
Total hot run time: 172369 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.48 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d8ed629d9457cb4b71be75c75e7096c65202539b, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.03
query3	0.22	0.05	0.05
query4	1.67	0.09	0.08
query5	0.51	0.49	0.49
query6	1.14	0.72	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.55	0.48	0.49
query10	0.54	0.53	0.54
query11	0.16	0.11	0.12
query12	0.14	0.13	0.12
query13	0.60	0.58	0.58
query14	0.76	0.79	0.77
query15	0.84	0.80	0.81
query16	0.37	0.36	0.38
query17	0.98	0.98	1.01
query18	0.22	0.21	0.22
query19	1.81	1.86	1.79
query20	0.02	0.00	0.01
query21	15.46	0.76	0.65
query22	3.91	6.45	2.77
query23	18.28	1.42	1.31
query24	1.96	0.24	0.23
query25	0.14	0.08	0.08
query26	0.30	0.21	0.21
query27	0.46	0.25	0.24
query28	13.23	1.03	0.99
query29	12.64	3.32	3.23
query30	0.25	0.07	0.05
query31	2.87	0.39	0.39
query32	3.26	0.49	0.48
query33	2.88	2.90	2.95
query34	17.17	4.34	4.34
query35	4.41	4.48	4.41
query36	0.67	0.46	0.46
query37	0.19	0.16	0.15
query38	0.16	0.15	0.14
query39	0.04	0.03	0.04
query40	0.15	0.12	0.13
query41	0.09	0.04	0.05
query42	0.05	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.34 s
Total hot run time: 31.48 s

@amorynan
Copy link
Contributor Author

run cloud_p0

1 similar comment
@amorynan
Copy link
Contributor Author

run cloud_p0

@amorynan
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41778 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8cd8d807023cd061c210cb9c3935eff92135a437, data reload: false

------ Round 1 ----------------------------------
q1	18058	4224	4258	4224
q2	2364	225	219	219
q3	10433	1314	1350	1314
q4	10174	864	991	864
q5	7583	2969	2956	2956
q6	226	140	142	140
q7	1030	612	606	606
q8	9445	1835	1924	1835
q9	8402	6597	6621	6597
q10	8728	3804	3823	3804
q11	432	251	252	251
q12	412	228	228	228
q13	17771	2916	2925	2916
q14	268	247	237	237
q15	525	490	496	490
q16	491	417	389	389
q17	958	919	904	904
q18	8080	7319	7259	7259
q19	1382	1221	1216	1216
q20	561	333	338	333
q21	5296	4708	4710	4708
q22	370	291	288	288
Total cold run time: 112989 ms
Total hot run time: 41778 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4095	4060	4011	4011
q2	334	223	218	218
q3	2988	2979	2975	2975
q4	1893	1840	1863	1840
q5	5236	5213	5189	5189
q6	221	131	133	131
q7	2023	1675	1726	1675
q8	3209	3286	3245	3245
q9	8265	8231	8266	8231
q10	3725	3856	3824	3824
q11	550	454	449	449
q12	722	535	542	535
q13	16063	2966	2934	2934
q14	283	258	263	258
q15	519	471	472	471
q16	447	393	417	393
q17	1718	1706	1715	1706
q18	7840	7347	7205	7205
q19	1684	1679	1653	1653
q20	1954	1785	1738	1738
q21	5450	5154	5076	5076
q22	513	446	454	446
Total cold run time: 69732 ms
Total hot run time: 54203 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169115 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8cd8d807023cd061c210cb9c3935eff92135a437, data reload: false

query1	904	372	358	358
query2	6469	1730	1672	1672
query3	6664	212	222	212
query4	20336	17487	17271	17271
query5	4275	514	534	514
query6	285	173	168	168
query7	4609	301	296	296
query8	253	195	195	195
query9	8518	2429	2417	2417
query10	447	282	274	274
query11	10550	10010	9977	9977
query12	139	91	86	86
query13	1639	391	378	378
query14	8870	7676	8433	7676
query15	200	165	165	165
query16	7151	432	429	429
query17	945	556	547	547
query18	1923	278	295	278
query19	203	141	140	140
query20	92	86	85	85
query21	206	100	99	99
query22	4238	4147	3848	3848
query23	33915	32995	32750	32750
query24	10272	3058	3052	3052
query25	698	387	383	383
query26	1781	149	151	149
query27	2986	278	280	278
query28	7035	1995	1989	1989
query29	1360	448	410	410
query30	286	149	152	149
query31	928	757	745	745
query32	101	55	56	55
query33	701	329	310	310
query34	914	478	494	478
query35	877	726	711	711
query36	983	859	831	831
query37	306	80	77	77
query38	2841	2758	2761	2758
query39	853	812	789	789
query40	277	114	115	114
query41	47	46	45	45
query42	118	98	97	97
query43	478	427	413	413
query44	1196	725	718	718
query45	208	175	175	175
query46	1085	822	786	786
query47	1806	1692	1702	1692
query48	370	291	305	291
query49	1197	466	432	432
query50	902	445	443	443
query51	6638	6640	6517	6517
query52	93	93	89	89
query53	255	179	178	178
query54	648	474	469	469
query55	78	82	75	75
query56	280	253	254	253
query57	1127	1047	1012	1012
query58	275	270	276	270
query59	2592	2357	2517	2357
query60	293	271	284	271
query61	102	98	108	98
query62	921	676	670	670
query63	222	185	187	185
query64	5963	1906	1903	1903
query65	3163	3135	3081	3081
query66	1423	333	358	333
query67	15181	14680	14740	14680
query68	4295	575	592	575
query69	439	303	312	303
query70	1103	1043	1077	1043
query71	369	281	313	281
query72	7156	2670	2558	2558
query73	767	331	345	331
query74	5972	5624	5661	5624
query75	3402	2771	2739	2739
query76	2240	1362	1405	1362
query77	448	316	304	304
query78	9438	8868	8812	8812
query79	1376	539	528	528
query80	1157	512	514	512
query81	572	219	229	219
query82	1065	132	137	132
query83	240	166	169	166
query84	272	79	80	79
query85	1295	324	311	311
query86	394	323	308	308
query87	3251	3157	3106	3106
query88	3000	2514	2529	2514
query89	384	298	288	288
query90	1742	194	190	190
query91	140	116	112	112
query92	71	54	51	51
query93	1389	627	627	627
query94	900	312	307	307
query95	400	286	290	286
query96	600	291	290	290
query97	3218	3022	3043	3022
query98	219	205	201	201
query99	1668	1321	1288	1288
Total cold run time: 261673 ms
Total hot run time: 169115 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.87 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8cd8d807023cd061c210cb9c3935eff92135a437, data reload: false

query1	0.04	0.03	0.04
query2	0.07	0.04	0.04
query3	0.22	0.04	0.05
query4	1.69	0.07	0.07
query5	0.48	0.47	0.48
query6	1.15	0.71	0.71
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.58	0.51	0.51
query10	0.56	0.59	0.58
query11	0.16	0.12	0.11
query12	0.14	0.12	0.13
query13	0.60	0.60	0.60
query14	0.78	0.79	0.80
query15	0.90	0.86	0.86
query16	0.36	0.36	0.36
query17	0.99	1.02	0.98
query18	0.25	0.21	0.21
query19	1.84	1.79	1.74
query20	0.01	0.01	0.02
query21	15.41	0.79	0.65
query22	3.74	8.15	1.19
query23	18.04	1.33	1.29
query24	2.27	0.22	0.22
query25	0.18	0.09	0.08
query26	0.32	0.22	0.22
query27	0.47	0.24	0.25
query28	13.16	0.99	0.96
query29	12.54	3.29	3.30
query30	0.26	0.06	0.06
query31	2.88	0.41	0.40
query32	3.24	0.50	0.48
query33	2.95	2.96	3.00
query34	15.41	4.22	4.27
query35	4.27	4.30	4.29
query36	0.68	0.49	0.47
query37	0.19	0.16	0.15
query38	0.15	0.15	0.15
query39	0.04	0.03	0.03
query40	0.16	0.14	0.12
query41	0.10	0.05	0.05
query42	0.05	0.05	0.04
query43	0.04	0.03	0.04
Total cold run time: 107.44 s
Total hot run time: 29.87 s

Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 31, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon eldenmoon merged commit f4df3d1 into apache:master Aug 1, 2024
27 of 30 checks passed
yiguolei pushed a commit that referenced this pull request Aug 2, 2024
## Proposed changes
backport: #38384
Issue Number: close #xxx

<!--Describe your changes.-->
feiniaofeiafei pushed a commit to feiniaofeiafei/doris that referenced this pull request Aug 9, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants