[Fix](nereids) change char(0) to char(1), varchar(0) to varchar(65533) when create table #38427

feiniaofeiafei · 2024-07-26T14:05:39Z

No description provided.

…) when create table

doris-robot · 2024-07-26T14:05:43Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

feiniaofeiafei · 2024-07-26T14:05:50Z

run buildall

doris-robot · 2024-07-26T14:43:23Z

TPC-H: Total hot run time: 39065 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2c02dec25132f8a2171df86163ca5c256b0361c3, data reload: false

------ Round 1 ----------------------------------
q1	17643	4327	4243	4243
q2	2023	198	200	198
q3	10437	1232	1058	1058
q4	10139	641	765	641
q5	7601	2692	2655	2655
q6	218	138	138	138
q7	950	588	593	588
q8	9299	1880	1902	1880
q9	8986	6543	6534	6534
q10	8790	3804	3781	3781
q11	458	246	241	241
q12	487	228	219	219
q13	17772	2987	2981	2981
q14	282	233	239	233
q15	508	484	500	484
q16	479	394	381	381
q17	956	674	692	674
q18	8002	7523	7401	7401
q19	4916	1038	951	951
q20	671	329	326	326
q21	5144	3166	3239	3166
q22	369	293	292	292
Total cold run time: 116130 ms
Total hot run time: 39065 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4424	4221	4194	4194
q2	365	286	263	263
q3	2978	2788	2851	2788
q4	1960	1673	1702	1673
q5	5536	5597	5484	5484
q6	220	138	142	138
q7	2187	1797	1820	1797
q8	3299	3392	3364	3364
q9	8739	8722	8801	8722
q10	4163	3887	3848	3848
q11	584	484	516	484
q12	785	618	659	618
q13	17258	3170	3181	3170
q14	324	322	295	295
q15	538	502	503	502
q16	515	428	441	428
q17	1810	1536	1487	1487
q18	7993	7985	7820	7820
q19	1751	1615	1565	1565
q20	2148	1899	1863	1863
q21	5137	5002	4795	4795
q22	590	501	510	501
Total cold run time: 73304 ms
Total hot run time: 55799 ms

doris-robot · 2024-07-26T14:54:36Z

TPC-DS: Total hot run time: 172598 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2c02dec25132f8a2171df86163ca5c256b0361c3, data reload: false

query1	919	368	366	366
query2	6446	1863	1831	1831
query3	6655	205	215	205
query4	28669	17683	17382	17382
query5	3695	482	471	471
query6	271	174	152	152
query7	4584	280	294	280
query8	234	188	195	188
query9	8543	2476	2458	2458
query10	448	273	279	273
query11	12235	10097	10091	10091
query12	125	89	87	87
query13	1629	363	360	360
query14	10512	7547	7165	7165
query15	240	167	173	167
query16	7622	448	495	448
query17	1421	581	546	546
query18	1918	287	288	287
query19	187	146	148	146
query20	96	87	84	84
query21	208	102	99	99
query22	4609	4001	4053	4001
query23	34344	33683	33473	33473
query24	10881	2907	2980	2907
query25	654	428	405	405
query26	707	151	158	151
query27	2285	281	289	281
query28	5797	2087	2062	2062
query29	815	447	531	447
query30	249	156	155	155
query31	974	744	733	733
query32	99	56	62	56
query33	675	356	335	335
query34	894	480	503	480
query35	862	752	786	752
query36	1151	964	951	951
query37	141	79	79	79
query38	2980	2839	2843	2839
query39	889	811	803	803
query40	193	112	109	109
query41	45	44	43	43
query42	115	96	95	95
query43	507	457	492	457
query44	1051	711	707	707
query45	213	174	175	174
query46	1084	748	748	748
query47	1861	1756	1780	1756
query48	366	287	285	285
query49	828	404	420	404
query50	804	404	401	401
query51	6629	6826	6627	6627
query52	100	84	90	84
query53	252	180	177	177
query54	871	443	445	443
query55	73	70	74	70
query56	331	266	303	266
query57	1114	1066	1040	1040
query58	275	261	285	261
query59	2993	2751	2549	2549
query60	308	289	284	284
query61	97	92	95	92
query62	796	647	628	628
query63	209	179	179	179
query64	9474	2286	1759	1759
query65	3160	3072	3099	3072
query66	750	329	333	329
query67	15317	14849	15170	14849
query68	5330	524	527	524
query69	720	373	308	308
query70	1174	1106	1072	1072
query71	502	271	267	267
query72	8605	6155	5537	5537
query73	773	324	326	324
query74	6232	5687	5706	5687
query75	4475	2639	2700	2639
query76	3698	911	879	879
query77	657	312	298	298
query78	9813	9047	9022	9022
query79	3135	513	520	513
query80	1520	484	481	481
query81	589	220	217	217
query82	1454	136	138	136
query83	355	175	180	175
query84	270	83	77	77
query85	1341	309	359	309
query86	431	299	323	299
query87	3267	3092	3060	3060
query88	3992	2479	2471	2471
query89	406	282	288	282
query90	1917	196	192	192
query91	124	101	101	101
query92	58	50	51	50
query93	3533	532	524	524
query94	897	296	302	296
query95	367	261	261	261
query96	606	270	271	270
query97	3177	3058	3015	3015
query98	230	199	189	189
query99	1590	1273	1239	1239
Total cold run time: 286717 ms
Total hot run time: 172598 ms

doris-robot · 2024-07-26T15:00:08Z

ClickBench: Total hot run time: 30.61 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2c02dec25132f8a2171df86163ca5c256b0361c3, data reload: false

query1	0.04	0.04	0.03
query2	0.09	0.04	0.04
query3	0.22	0.05	0.05
query4	1.69	0.09	0.08
query5	0.49	0.48	0.49
query6	1.12	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.55	0.49	0.48
query10	0.55	0.54	0.56
query11	0.15	0.11	0.11
query12	0.15	0.13	0.11
query13	0.60	0.58	0.59
query14	0.75	0.78	0.81
query15	0.86	0.83	0.81
query16	0.38	0.36	0.34
query17	0.94	1.04	1.04
query18	0.22	0.21	0.22
query19	1.87	1.83	1.76
query20	0.02	0.01	0.01
query21	15.39	0.77	0.65
query22	3.91	7.75	1.91
query23	18.31	1.40	1.30
query24	2.13	0.24	0.23
query25	0.16	0.08	0.08
query26	0.29	0.21	0.21
query27	0.46	0.23	0.22
query28	13.28	1.01	1.00
query29	12.62	3.28	3.26
query30	0.25	0.06	0.05
query31	2.87	0.40	0.39
query32	3.27	0.47	0.46
query33	2.92	2.85	2.90
query34	17.04	4.36	4.34
query35	4.42	4.41	4.41
query36	0.66	0.46	0.50
query37	0.20	0.16	0.16
query38	0.15	0.14	0.15
query39	0.05	0.04	0.03
query40	0.15	0.12	0.11
query41	0.10	0.05	0.04
query42	0.06	0.04	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.49 s
Total hot run time: 30.61 s

feiniaofeiafei · 2024-07-29T02:53:46Z

run p0

feiniaofeiafei · 2024-07-29T03:21:35Z

run cloud_p0

feiniaofeiafei · 2024-07-29T03:21:54Z

run p1

...-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/ColumnDefinition.java

github-actions · 2024-07-30T03:04:09Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-07-30T03:04:11Z

PR approved by anyone and no changes requested.

…) when create table (apache#38427)

…) when create table (#38427)

…) when create table (#38427) (#38530) cherry-pick #38427 to branch-2.1 --------- Co-authored-by: morrySnow <[email protected]>

…40940) The VARCHAR(0) created has an actual length of 0, and BE didn't restrict it, leading to a BE core dump. #[38427](#38427) changed VARCHAR(0) to have a length of 65533. This PR restricts data import when the length is 0 to avoid a core dump.

…pache#40940) The VARCHAR(0) created has an actual length of 0, and BE didn't restrict it, leading to a BE core dump. #[38427](apache#38427) changed VARCHAR(0) to have a length of 65533. This PR restricts data import when the length is 0 to avoid a core dump.

…40940) The VARCHAR(0) created has an actual length of 0, and BE didn't restrict it, leading to a BE core dump. #[38427](#38427) changed VARCHAR(0) to have a length of 65533. This PR restricts data import when the length is 0 to avoid a core dump.

…) when create table (apache#38427)

[Fix](nereids) change char(0) to char(1), varchar(0) to varchar(65533…

2c02dec

…) when create table

morrySnow reviewed Jul 29, 2024

View reviewed changes

...-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/ColumnDefinition.java Show resolved Hide resolved

morrySnow approved these changes Jul 30, 2024

View reviewed changes

morrySnow added the dev/2.1.x label Jul 30, 2024

github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 30, 2024

github-actions bot added the reviewed label Jul 30, 2024

starocean999 approved these changes Jul 30, 2024

View reviewed changes

morrySnow merged commit 7b9fab1 into apache:master Jul 30, 2024
32 of 34 checks passed

feiniaofeiafei added a commit to feiniaofeiafei/doris that referenced this pull request Jul 30, 2024

[Fix](nereids) change char(0) to char(1), varchar(0) to varchar(65533…

b3ee564

…) when create table (apache#38427)

feiniaofeiafei mentioned this pull request Jul 30, 2024

[Fix](nereids) change char(0) to char(1), varchar(0) to varchar(65533) when create table (#38427) #38530

Merged

gavinchou added the dev/3.0.x label Aug 1, 2024

feiniaofeiafei added a commit to feiniaofeiafei/doris that referenced this pull request Aug 1, 2024

[Fix](nereids) change char(0) to char(1), varchar(0) to varchar(65533…

fee07dd

…) when create table (apache#38427)

morrySnow added the usercase Important user case type label label Aug 2, 2024

feiniaofeiafei added a commit to feiniaofeiafei/doris that referenced this pull request Aug 2, 2024

[Fix](nereids) change char(0) to char(1), varchar(0) to varchar(65533…

7af1659

…) when create table (apache#38427)

dataroaring added dev/3.0.1-merged and removed dev/3.0.x labels Aug 4, 2024

dataroaring pushed a commit that referenced this pull request Aug 4, 2024

[Fix](nereids) change char(0) to char(1), varchar(0) to varchar(65533…

b63227a

…) when create table (#38427)

yiguolei pushed a commit that referenced this pull request Aug 5, 2024

[Fix](nereids) change char(0) to char(1), varchar(0) to varchar(65533…

de9b9d6

…) when create table (#38427) (#38530) cherry-pick #38427 to branch-2.1 --------- Co-authored-by: morrySnow <[email protected]>

yiguolei added dev/2.1.6-merged and removed dev/2.1.x labels Aug 5, 2024

gavinchou mentioned this pull request Aug 19, 2024

Release Note 3.0.1 #39570

Open

yiguolei mentioned this pull request Sep 5, 2024

Release Note 2.1.6 #40443

Open

3 tasks

liaoxin01 mentioned this pull request Sep 18, 2024

[Fix](load) Restrict the import of VARCHAR(0) data to avoid coredump #40940

Merged

eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Nov 12, 2024

[Fix](nereids) change char(0) to char(1), varchar(0) to varchar(65533…

f886356

…) when create table (apache#38427)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix](nereids) change char(0) to char(1), varchar(0) to varchar(65533) when create table #38427

[Fix](nereids) change char(0) to char(1), varchar(0) to varchar(65533) when create table #38427

feiniaofeiafei commented Jul 26, 2024 •

edited

Loading

doris-robot commented Jul 26, 2024

feiniaofeiafei commented Jul 26, 2024

doris-robot commented Jul 26, 2024

doris-robot commented Jul 26, 2024

doris-robot commented Jul 26, 2024

feiniaofeiafei commented Jul 29, 2024

feiniaofeiafei commented Jul 29, 2024

feiniaofeiafei commented Jul 29, 2024

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

[Fix](nereids) change char(0) to char(1), varchar(0) to varchar(65533) when create table #38427

[Fix](nereids) change char(0) to char(1), varchar(0) to varchar(65533) when create table #38427

Conversation

feiniaofeiafei commented Jul 26, 2024 • edited Loading

doris-robot commented Jul 26, 2024

feiniaofeiafei commented Jul 26, 2024

doris-robot commented Jul 26, 2024

doris-robot commented Jul 26, 2024

doris-robot commented Jul 26, 2024

feiniaofeiafei commented Jul 29, 2024

feiniaofeiafei commented Jul 29, 2024

feiniaofeiafei commented Jul 29, 2024

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

feiniaofeiafei commented Jul 26, 2024 •

edited

Loading