[feature](Vault) Support alter hdfs storage vault and alter vault's name #38685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
clang-tidy review says "All clean, LGTM! 👍" |
ByteYue
force-pushed
the
support_rename_vault
branch
from
9eabcc4 to
1bbc772
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
3 similar comments
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 42019 ms |
TPC-DS: Total hot run time: 169321 ms |
ClickBench: Total hot run time: 30.31 s |
gavinchou
requested changes
Aug 8, 2024
| @@ -56,6 +58,11 @@ public class HdfsStorageVault extends StorageVault { | |||
| public static final String HDFS_PREFIX = "hdfs:"; | |||
| public static final String HDFS_FILE_PREFIX = "hdfs://"; | |||
|
|
|||
| public static final HashSet<String> ALTER_CHECK_PROPERTIES = new HashSet<>(Arrays.asList( | |||
There was a problem hiding this comment.
for hdfs, only name and passwd can be altered
There was a problem hiding this comment.
What if the users tried to add more properties?
There was a problem hiding this comment.
forbid
comment why forbid
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pass path format case ok resolve comment add ut
ByteYue
force-pushed
the
support_rename_vault
branch
from
2b6553a to
b68cba9
Compare
|
run buildall |
gavinchou
requested changes
Aug 9, 2024
TPC-H: Total hot run time: 39858 ms |
TPC-DS: Total hot run time: 201616 ms |
ClickBench: Total hot run time: 30.34 s |
gavinchou
previously approved these changes
Aug 13, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 39919 ms |
TPC-DS: Total hot run time: 189400 ms |
ClickBench: Total hot run time: 31.01 s |
gavinchou
approved these changes
Aug 13, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
bobhan1
approved these changes
Aug 13, 2024
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 14, 2024
…ame (apache#38685) Previously only s3 vault can be altered. This pr adds support of hdfs storage vault. And this pr also supports to alter vault's name. usage example ``` ALTER STORAGE VAULT alter_s3_vault PROPERTIES ( "type"="S3", "s3.access_key" = "new_ak", -- change ak "s3.secrete_key" = "new_ak", -- change sk ); ALTER STORAGE VAULT alter_hdfs_vault PROPERTIES ( "type"="hdfs", "VAULT_NAME" = "alter_hdfs_vault_new_name", -- change vault name "hadoop.username" = "hdfs" -- change user name ); ```
gavinchou
pushed a commit
that referenced
this pull request
Sep 10, 2024
…ame (#38685) Previously only s3 vault can be altered. This pr adds support of hdfs storage vault. And this pr also supports to alter vault's name. usage example ``` ALTER STORAGE VAULT alter_s3_vault PROPERTIES ( "type"="S3", "s3.access_key" = "new_ak", -- change ak "s3.secrete_key" = "new_ak", -- change sk ); ALTER STORAGE VAULT alter_hdfs_vault PROPERTIES ( "type"="hdfs", "VAULT_NAME" = "alter_hdfs_vault_new_name", -- change vault name "hadoop.username" = "hdfs" -- change user name ); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only s3 vault can be altered. This pr adds support of hdfs storage vault. And this pr also supports to alter vault's name.
usage example