[bugfix](backup)(cooldown) cancel backup properly when be backup failed #38724

justfortaste · 2024-08-01T11:20:51Z

Currently, when a backup job failed, but it still at the state of SNAPSHOTING.

Cancel the cancel backup properly when be backup failed

Currently, when a backup job failed, but it still at the state of SNAPSHOTING. Cancel the cancel backup properly when be backup failed

doris-robot · 2024-08-01T11:20:55Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

github-actions · 2024-08-01T11:27:34Z

clang-tidy review says "All clean, LGTM! 👍"

nextdreamblue · 2024-08-01T11:28:37Z

run buildall

doris-robot · 2024-08-01T11:46:25Z

TPC-H: Total hot run time: 41682 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e37d169d7bfe6943747155c8f9badfb29bb20ea2, data reload: false

------ Round 1 ----------------------------------
q1	17701	4162	4065	4065
q2	2036	200	197	197
q3	10651	1253	1340	1253
q4	11167	800	919	800
q5	7843	3052	3017	3017
q6	222	140	140	140
q7	1049	623	634	623
q8	9811	1890	1960	1890
q9	8667	6680	6655	6655
q10	8812	3803	3827	3803
q11	438	255	246	246
q12	411	229	225	225
q13	17773	2930	2953	2930
q14	269	238	252	238
q15	524	486	488	486
q16	529	395	391	391
q17	983	895	894	894
q18	8126	7323	7365	7323
q19	1577	1224	1212	1212
q20	565	346	343	343
q21	5227	4733	4675	4675
q22	341	277	276	276
Total cold run time: 114722 ms
Total hot run time: 41682 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4119	4030	4023	4023
q2	327	225	226	225
q3	3003	3113	3150	3113
q4	2014	2015	2038	2015
q5	5511	5438	5373	5373
q6	219	127	131	127
q7	2156	1766	1825	1766
q8	3262	3350	3300	3300
q9	8818	8664	8450	8450
q10	3962	4035	3986	3986
q11	549	452	451	451
q12	761	575	565	565
q13	11018	3129	3130	3129
q14	317	282	300	282
q15	536	493	488	488
q16	472	411	411	411
q17	1782	1739	1768	1739
q18	8507	7738	7607	7607
q19	1694	1708	1715	1708
q20	2039	1840	1783	1783
q21	5550	5291	5433	5291
q22	532	461	453	453
Total cold run time: 67148 ms
Total hot run time: 56285 ms

be/src/common/status.cpp

doris-robot · 2024-08-01T11:57:07Z

TPC-DS: Total hot run time: 169206 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e37d169d7bfe6943747155c8f9badfb29bb20ea2, data reload: false

query1	912	380	368	368
query2	6303	1732	1684	1684
query3	6677	211	220	211
query4	19707	17300	17472	17300
query5	3684	503	520	503
query6	294	173	157	157
query7	4604	303	284	284
query8	250	209	196	196
query9	8526	2393	2386	2386
query10	444	278	286	278
query11	10346	10033	10058	10033
query12	131	91	88	88
query13	1629	381	381	381
query14	9955	7670	6989	6989
query15	217	169	165	165
query16	6762	454	427	427
query17	952	573	560	560
query18	1832	293	290	290
query19	196	149	149	149
query20	93	89	87	87
query21	209	114	106	106
query22	4281	4215	4047	4047
query23	33787	33612	33542	33542
query24	10379	3131	3134	3131
query25	693	430	441	430
query26	1514	153	166	153
query27	2532	288	294	288
query28	7019	2046	2042	2042
query29	1102	468	443	443
query30	232	165	157	157
query31	953	771	770	770
query32	105	60	60	60
query33	725	415	317	317
query34	916	500	501	500
query35	850	730	733	730
query36	1033	907	879	879
query37	245	79	78	78
query38	2882	2780	2733	2733
query39	887	789	815	789
query40	254	113	111	111
query41	43	43	44	43
query42	123	103	97	97
query43	467	411	409	409
query44	1173	725	730	725
query45	203	172	180	172
query46	1076	776	769	769
query47	1782	1690	1712	1690
query48	373	294	285	285
query49	908	407	418	407
query50	892	440	432	432
query51	6849	6823	6569	6569
query52	103	92	90	90
query53	249	177	174	174
query54	637	444	441	441
query55	76	75	73	73
query56	272	245	256	245
query57	1119	1052	1050	1050
query58	266	260	304	260
query59	2550	2329	2463	2329
query60	287	302	263	263
query61	100	114	94	94
query62	869	652	673	652
query63	221	181	179	179
query64	5778	1884	1908	1884
query65	3159	3096	3100	3096
query66	1314	325	335	325
query67	15374	14959	14702	14702
query68	5018	562	570	562
query69	543	297	292	292
query70	1130	1051	1029	1029
query71	522	297	280	280
query72	7675	2677	2491	2491
query73	806	326	325	325
query74	5980	5681	5673	5673
query75	3656	2723	2696	2696
query76	3271	1167	1218	1167
query77	568	312	311	311
query78	9373	8870	8847	8847
query79	2049	543	538	538
query80	1163	513	528	513
query81	564	230	222	222
query82	1005	131	132	131
query83	277	170	179	170
query84	281	78	82	78
query85	1371	353	299	299
query86	443	280	292	280
query87	3291	3099	3072	3072
query88	2953	2381	2411	2381
query89	377	285	293	285
query90	1955	195	191	191
query91	130	96	103	96
query92	65	50	50	50
query93	1982	608	616	608
query94	964	300	296	296
query95	386	260	264	260
query96	608	284	284	284
query97	3229	3034	3051	3034
query98	232	197	194	194
query99	1606	1288	1254	1254
Total cold run time: 263848 ms
Total hot run time: 169206 ms

doris-robot · 2024-08-01T12:02:37Z

ClickBench: Total hot run time: 29.58 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e37d169d7bfe6943747155c8f9badfb29bb20ea2, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.04
query3	0.22	0.05	0.04
query4	1.68	0.06	0.07
query5	0.49	0.48	0.48
query6	1.16	0.71	0.71
query7	0.02	0.01	0.01
query8	0.06	0.05	0.04
query9	0.58	0.52	0.50
query10	0.55	0.58	0.56
query11	0.16	0.12	0.12
query12	0.15	0.12	0.13
query13	0.61	0.61	0.60
query14	0.76	0.81	0.79
query15	0.90	0.85	0.87
query16	0.35	0.35	0.36
query17	0.99	1.01	0.97
query18	0.22	0.21	0.21
query19	1.83	1.75	1.72
query20	0.01	0.00	0.00
query21	15.43	0.78	0.67
query22	4.21	9.11	1.02
query23	17.76	1.26	1.31
query24	2.28	0.23	0.21
query25	0.18	0.08	0.08
query26	0.33	0.21	0.20
query27	0.46	0.23	0.23
query28	13.16	1.00	0.98
query29	12.95	3.29	3.30
query30	0.26	0.06	0.05
query31	2.87	0.40	0.40
query32	3.27	0.50	0.47
query33	2.96	2.91	2.93
query34	15.42	4.26	4.25
query35	4.26	4.31	4.29
query36	0.66	0.48	0.48
query37	0.19	0.16	0.15
query38	0.15	0.16	0.16
query39	0.04	0.03	0.04
query40	0.16	0.13	0.13
query41	0.09	0.05	0.04
query42	0.05	0.05	0.05
query43	0.04	0.04	0.05
Total cold run time: 108.03 s
Total hot run time: 29.58 s

github-actions · 2024-08-02T03:47:34Z

clang-tidy review says "All clean, LGTM! 👍"

xy720

LGTM

github-actions · 2024-08-02T07:00:33Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-08-02T07:00:36Z

PR approved by anyone and no changes requested.

xy720 · 2024-08-02T07:00:54Z

run buildall

doris-robot · 2024-08-02T07:43:05Z

TPC-H: Total hot run time: 41352 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8931a6cfd463e36ce39c1b2ce45f3fb27ba62ed6, data reload: false

------ Round 1 ----------------------------------
q1	17724	4088	4042	4042
q2	2014	198	217	198
q3	10433	1273	1321	1273
q4	10184	781	892	781
q5	7612	2984	2990	2984
q6	226	139	134	134
q7	1036	626	614	614
q8	9428	1736	1943	1736
q9	8669	6580	6617	6580
q10	8744	3807	3836	3807
q11	432	246	252	246
q12	445	226	220	220
q13	17766	2921	2964	2921
q14	267	246	237	237
q15	521	482	477	477
q16	526	383	388	383
q17	956	902	883	883
q18	7931	7259	7272	7259
q19	1507	1230	1214	1214
q20	559	336	342	336
q21	5227	4757	4748	4748
q22	353	279	289	279
Total cold run time: 112560 ms
Total hot run time: 41352 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4071	3994	3983	3983
q2	323	223	218	218
q3	2966	2980	3080	2980
q4	1970	1989	1976	1976
q5	5516	5473	5472	5472
q6	218	131	135	131
q7	2111	1736	1753	1736
q8	3301	3362	3344	3344
q9	8570	8587	8650	8587
q10	3964	4069	3941	3941
q11	538	438	470	438
q12	763	591	594	591
q13	16378	3089	3164	3089
q14	311	266	284	266
q15	522	492	492	492
q16	463	413	420	413
q17	1737	1735	1749	1735
q18	8230	7773	7829	7773
q19	1725	1721	1696	1696
q20	2028	1897	1809	1809
q21	5663	5346	5372	5346
q22	505	461	472	461
Total cold run time: 71873 ms
Total hot run time: 56477 ms

doris-robot · 2024-08-02T07:53:47Z

TPC-DS: Total hot run time: 169502 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8931a6cfd463e36ce39c1b2ce45f3fb27ba62ed6, data reload: false

query1	916	368	361	361
query2	6452	1680	1649	1649
query3	6668	205	219	205
query4	20008	17386	17361	17361
query5	3643	502	511	502
query6	269	169	175	169
query7	4597	303	297	297
query8	255	193	193	193
query9	8505	2410	2400	2400
query10	436	283	271	271
query11	10517	10005	10013	10005
query12	115	91	87	87
query13	1638	402	387	387
query14	9799	6831	7620	6831
query15	201	164	166	164
query16	6805	464	424	424
query17	946	584	572	572
query18	1916	287	288	287
query19	197	150	149	149
query20	91	88	85	85
query21	204	102	98	98
query22	4217	4288	3947	3947
query23	33732	33592	33468	33468
query24	9396	3115	3071	3071
query25	655	434	397	397
query26	1194	151	151	151
query27	2943	282	288	282
query28	7410	2031	1984	1984
query29	984	448	447	447
query30	244	162	158	158
query31	945	764	743	743
query32	104	59	63	59
query33	672	342	336	336
query34	908	492	518	492
query35	910	769	751	751
query36	998	903	896	896
query37	172	84	80	80
query38	2926	2881	2769	2769
query39	872	814	797	797
query40	201	111	110	110
query41	45	44	42	42
query42	120	96	100	96
query43	439	417	415	415
query44	1176	721	739	721
query45	207	178	180	178
query46	1076	807	791	791
query47	1813	1722	1696	1696
query48	354	293	285	285
query49	834	413	431	413
query50	897	437	432	432
query51	6763	6686	6639	6639
query52	102	90	85	85
query53	260	181	190	181
query54	621	453	474	453
query55	75	75	74	74
query56	271	254	262	254
query57	1156	1028	1023	1023
query58	293	259	276	259
query59	2687	2550	2422	2422
query60	328	268	274	268
query61	96	90	92	90
query62	891	665	677	665
query63	215	188	177	177
query64	4711	1889	1867	1867
query65	3159	3063	3100	3063
query66	967	342	322	322
query67	15240	14814	14884	14814
query68	5503	583	588	583
query69	680	390	321	321
query70	1111	1063	1100	1063
query71	456	282	288	282
query72	7562	2688	2514	2514
query73	930	334	333	333
query74	6042	5601	5613	5601
query75	3531	2709	2764	2709
query76	3184	1265	1271	1265
query77	582	302	319	302
query78	9425	8921	8913	8913
query79	2226	531	539	531
query80	1020	488	512	488
query81	581	223	228	223
query82	1143	130	130	130
query83	259	169	168	168
query84	265	80	78	78
query85	1443	325	348	325
query86	494	312	283	283
query87	3269	3168	3098	3098
query88	3764	2476	2482	2476
query89	392	291	278	278
query90	1759	197	195	195
query91	124	101	99	99
query92	54	54	50	50
query93	2119	634	630	630
query94	772	294	286	286
query95	390	270	275	270
query96	603	282	281	281
query97	3244	3099	3122	3099
query98	223	193	193	193
query99	1602	1275	1287	1275
Total cold run time: 263209 ms
Total hot run time: 169502 ms

doris-robot · 2024-08-02T07:59:17Z

ClickBench: Total hot run time: 30.57 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8931a6cfd463e36ce39c1b2ce45f3fb27ba62ed6, data reload: false

query1	0.05	0.04	0.04
query2	0.07	0.04	0.04
query3	0.23	0.05	0.04
query4	1.67	0.07	0.08
query5	0.49	0.49	0.48
query6	1.20	0.72	0.72
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.56	0.50	0.51
query10	0.57	0.57	0.57
query11	0.16	0.12	0.11
query12	0.16	0.12	0.12
query13	0.62	0.61	0.59
query14	0.78	0.80	0.79
query15	0.89	0.86	0.85
query16	0.35	0.35	0.35
query17	0.96	0.99	0.99
query18	0.22	0.23	0.20
query19	1.83	1.77	1.74
query20	0.01	0.01	0.00
query21	15.40	0.73	0.64
query22	3.89	7.25	1.81
query23	18.16	1.40	1.36
query24	2.31	0.22	0.21
query25	0.19	0.09	0.08
query26	0.32	0.21	0.22
query27	0.46	0.23	0.23
query28	13.16	0.99	0.97
query29	12.58	3.40	3.41
query30	0.25	0.05	0.06
query31	2.87	0.42	0.40
query32	3.24	0.50	0.48
query33	2.93	2.95	2.96
query34	15.44	4.20	4.27
query35	4.28	4.26	4.28
query36	0.66	0.49	0.48
query37	0.20	0.16	0.17
query38	0.16	0.14	0.15
query39	0.04	0.04	0.03
query40	0.15	0.12	0.12
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.04	0.05	0.04
Total cold run time: 107.77 s
Total hot run time: 30.57 s

w41ter

Reset LGTM.

fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java

regression-test/suites/backup_restore/test_backup_cancelled.groovy

modify non concurrent injection

github-actions · 2024-08-05T12:41:04Z

clang-tidy review says "All clean, LGTM! 👍"

dataroaring · 2024-08-05T18:15:59Z

run buildall

github-actions · 2024-08-06T02:00:06Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-08-06T02:01:18Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-08-06T02:10:58Z

PR approved by at least one committer and no changes requested.

dataroaring

LGTM

dataroaring · 2024-08-06T08:32:20Z

run buildall

doris-robot · 2024-08-06T09:40:34Z

TPC-H: Total hot run time: 41920 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fa3f6d257d825b5d746e4ce443c71c1ced0cb5f2, data reload: false

------ Round 1 ----------------------------------
q1	17652	4409	4103	4103
q2	2035	207	204	204
q3	10449	1290	1325	1290
q4	10175	874	986	874
q5	7667	2962	3007	2962
q6	220	137	141	137
q7	1075	627	619	619
q8	9437	1991	1968	1968
q9	8641	6614	6624	6614
q10	8727	3849	3902	3849
q11	433	254	266	254
q12	425	244	239	239
q13	17766	2933	2944	2933
q14	270	246	249	246
q15	518	484	500	484
q16	541	388	386	386
q17	979	897	884	884
q18	8181	7435	7264	7264
q19	1466	1224	1224	1224
q20	576	328	345	328
q21	5318	4775	4812	4775
q22	360	285	283	283
Total cold run time: 112911 ms
Total hot run time: 41920 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4090	4048	4043	4043
q2	330	219	222	219
q3	3021	3057	3160	3057
q4	2039	2095	2026	2026
q5	5657	5498	5401	5401
q6	227	145	134	134
q7	2159	1859	1803	1803
q8	3383	3377	3402	3377
q9	8717	8769	8778	8769
q10	3997	3950	4025	3950
q11	559	465	467	465
q12	779	621	605	605
q13	14328	3137	3160	3137
q14	300	290	264	264
q15	548	483	481	481
q16	493	433	414	414
q17	1782	1771	1729	1729
q18	8272	7894	7680	7680
q19	1969	1757	1748	1748
q20	2067	1845	1829	1829
q21	5793	5439	5442	5439
q22	538	485	480	480
Total cold run time: 71048 ms
Total hot run time: 57050 ms

doris-robot · 2024-08-06T09:51:16Z

TPC-DS: Total hot run time: 168718 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fa3f6d257d825b5d746e4ce443c71c1ced0cb5f2, data reload: false

query1	901	378	371	371
query2	6470	1751	1748	1748
query3	6661	215	223	215
query4	20233	17455	17185	17185
query5	3641	536	525	525
query6	258	164	170	164
query7	4582	311	295	295
query8	252	211	197	197
query9	8511	2395	2379	2379
query10	434	275	270	270
query11	10496	9952	9974	9952
query12	121	87	90	87
query13	1636	382	377	377
query14	9300	6015	6993	6015
query15	215	161	172	161
query16	6962	456	451	451
query17	995	588	560	560
query18	1913	285	294	285
query19	197	150	153	150
query20	98	88	94	88
query21	206	99	99	99
query22	4118	4130	4010	4010
query23	33965	33718	33494	33494
query24	9304	3108	3096	3096
query25	661	420	429	420
query26	723	153	158	153
query27	2389	283	299	283
query28	6009	2030	2021	2021
query29	950	462	462	462
query30	242	157	160	157
query31	963	813	746	746
query32	109	57	57	57
query33	695	338	347	338
query34	928	485	566	485
query35	876	771	759	759
query36	1062	855	941	855
query37	175	83	95	83
query38	2966	2884	2896	2884
query39	875	821	848	821
query40	279	114	112	112
query41	46	44	43	43
query42	120	99	100	99
query43	499	429	434	429
query44	1216	738	726	726
query45	211	181	180	180
query46	1083	810	799	799
query47	1827	1718	1714	1714
query48	365	292	292	292
query49	885	427	442	427
query50	900	432	431	431
query51	6759	6733	6651	6651
query52	133	95	94	94
query53	251	196	185	185
query54	646	448	449	448
query55	77	79	74	74
query56	273	268	259	259
query57	1131	1032	1038	1032
query58	277	304	278	278
query59	2670	2699	2319	2319
query60	287	272	285	272
query61	96	93	92	92
query62	890	657	652	652
query63	227	184	187	184
query64	4773	1924	1869	1869
query65	3197	3092	3074	3074
query66	816	334	376	334
query67	15274	14731	14712	14712
query68	5505	573	574	573
query69	744	398	305	305
query70	1143	1103	1031	1031
query71	469	283	279	279
query72	8075	2705	2475	2475
query73	925	331	331	331
query74	6079	5697	5642	5642
query75	3876	2746	2715	2715
query76	3338	1285	1289	1285
query77	718	319	323	319
query78	9418	9008	8903	8903
query79	2252	527	538	527
query80	2142	529	518	518
query81	573	227	226	226
query82	1241	143	136	136
query83	291	175	179	175
query84	272	81	83	81
query85	1413	325	303	303
query86	451	331	300	300
query87	3238	3105	3052	3052
query88	3753	2434	2419	2419
query89	397	283	299	283
query90	1843	200	199	199
query91	172	102	102	102
query92	62	51	51	51
query93	2119	620	615	615
query94	861	312	304	304
query95	394	271	280	271
query96	604	283	285	283
query97	3247	3045	3063	3045
query98	218	203	201	201
query99	1624	1290	1299	1290
Total cold run time: 263757 ms
Total hot run time: 168718 ms

doris-robot · 2024-08-06T09:56:45Z

ClickBench: Total hot run time: 29.67 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fa3f6d257d825b5d746e4ce443c71c1ced0cb5f2, data reload: false

query1	0.05	0.04	0.04
query2	0.07	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.07	0.07
query5	0.48	0.48	0.48
query6	1.15	0.72	0.70
query7	0.02	0.02	0.01
query8	0.06	0.05	0.05
query9	0.58	0.51	0.52
query10	0.56	0.57	0.56
query11	0.16	0.12	0.12
query12	0.14	0.12	0.12
query13	0.61	0.62	0.59
query14	0.77	0.79	0.79
query15	0.89	0.86	0.85
query16	0.34	0.35	0.34
query17	1.04	1.00	0.96
query18	0.25	0.21	0.21
query19	1.84	1.74	1.72
query20	0.01	0.00	0.01
query21	15.41	0.75	0.65
query22	3.81	8.38	1.13
query23	17.97	1.23	1.24
query24	2.28	0.22	0.22
query25	0.17	0.08	0.08
query26	0.32	0.22	0.22
query27	0.46	0.22	0.23
query28	13.19	0.99	0.98
query29	12.57	3.28	3.31
query30	0.25	0.06	0.05
query31	2.87	0.41	0.40
query32	3.25	0.48	0.49
query33	2.92	2.96	2.97
query34	15.43	4.28	4.24
query35	4.31	4.26	4.29
query36	0.68	0.48	0.46
query37	0.19	0.16	0.16
query38	0.17	0.16	0.15
query39	0.04	0.04	0.03
query40	0.16	0.14	0.13
query41	0.09	0.04	0.05
query42	0.05	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 107.56 s
Total hot run time: 29.67 s

nextdreamblue · 2024-08-06T11:36:27Z

run cloud_p1

…ed (apache#38724) Currently, when a backup job failed, but it still at the state of SNAPSHOTING. Cancel the cancel backup properly when be backup failed

…ed (#38724) (#38993) Co-authored-by: zhangyuan <[email protected]>

…ed (apache#38724) Currently, when a backup job failed, but it still at the state of SNAPSHOTING. Cancel the cancel backup properly when be backup failed

#38724 (#38994) cherry pick from #38724 Co-authored-by: zhangyuan <[email protected]>

…ed (#38724) Currently, when a backup job failed, but it still at the state of SNAPSHOTING. Cancel the cancel backup properly when be backup failed

…ed (apache#38724) Currently, when a backup job failed, but it still at the state of SNAPSHOTING. Cancel the cancel backup properly when be backup failed

…ed (#38724) Currently, when a backup job failed, but it still at the state of SNAPSHOTING. Cancel the cancel backup properly when be backup failed

apache#38724 (apache#38994) cherry pick from apache#38724 Co-authored-by: zhangyuan <[email protected]>

[bugfix](backup)(cooldown) cancel backup properly when be backup failed

e37d169

Currently, when a backup job failed, but it still at the state of SNAPSHOTING. Cancel the cancel backup properly when be backup failed

github-actions bot added the doing label Aug 1, 2024

cambyzju reviewed Aug 1, 2024

View reviewed changes

be/src/common/status.cpp Outdated Show resolved Hide resolved

fix if else

8931a6c

xy720 previously approved these changes Aug 2, 2024

View reviewed changes

github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 2, 2024

dataroaring added dev/2.1.x dev/3.0.x labels Aug 4, 2024

w41ter reviewed Aug 5, 2024

View reviewed changes

fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java Outdated Show resolved Hide resolved

fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java Outdated Show resolved Hide resolved

w41ter reviewed Aug 5, 2024

View reviewed changes

regression-test/suites/backup_restore/test_backup_cancelled.groovy Outdated Show resolved Hide resolved

add readlock for new oltptable

47f5325

modify non concurrent injection

justfortaste dismissed xy720’s stale review via 47f5325 August 5, 2024 12:34

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 5, 2024

fix indentation level

191ab1d

Merge branch 'master' into fix_backup_snapshot_err

fa3f6d2

w41ter approved these changes Aug 6, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 6, 2024

dataroaring approved these changes Aug 6, 2024

View reviewed changes

dataroaring added the dev/2.0.x label Aug 6, 2024

w41ter merged commit 4cec791 into apache:master Aug 7, 2024
28 of 30 checks passed

w41ter mentioned this pull request Aug 7, 2024

[bugfix](backup)(cooldown) cancel backup properly when be backup failed #38724 #38994

Merged

w41ter added a commit that referenced this pull request Aug 7, 2024

[bugfix](backup)(cooldown) cancel backup properly when be backup fail…

7e95d7c

…ed (#38724) (#38993) Co-authored-by: zhangyuan <[email protected]>

wm1581066 added dev/2.1.6-merged and removed dev/2.1.x labels Aug 7, 2024

w41ter added a commit that referenced this pull request Aug 7, 2024

[bugfix](backup)(cooldown) cancel backup properly when be backup failed

8528a1b

#38724 (#38994) cherry pick from #38724 Co-authored-by: zhangyuan <[email protected]>

w41ter added dev/2.0.15-merged and removed dev/2.0.x labels Aug 7, 2024

dataroaring added dev/3.0.2-merged and removed dev/3.0.x labels Aug 12, 2024

GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Aug 27, 2024

[bugfix](backup)(cooldown) cancel backup properly when be backup failed

6c95de9

apache#38724 (apache#38994) cherry pick from apache#38724 Co-authored-by: zhangyuan <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[bugfix](backup)(cooldown) cancel backup properly when be backup failed #38724

[bugfix](backup)(cooldown) cancel backup properly when be backup failed #38724

justfortaste commented Aug 1, 2024

doris-robot commented Aug 1, 2024

github-actions bot commented Aug 1, 2024

nextdreamblue commented Aug 1, 2024

doris-robot commented Aug 1, 2024

doris-robot commented Aug 1, 2024

doris-robot commented Aug 1, 2024

github-actions bot commented Aug 2, 2024

xy720 left a comment

github-actions bot commented Aug 2, 2024

github-actions bot commented Aug 2, 2024

xy720 commented Aug 2, 2024

doris-robot commented Aug 2, 2024

doris-robot commented Aug 2, 2024

doris-robot commented Aug 2, 2024

w41ter left a comment

github-actions bot commented Aug 5, 2024

dataroaring commented Aug 5, 2024

github-actions bot commented Aug 6, 2024

github-actions bot commented Aug 6, 2024

github-actions bot commented Aug 6, 2024

dataroaring left a comment

dataroaring commented Aug 6, 2024

doris-robot commented Aug 6, 2024

doris-robot commented Aug 6, 2024

doris-robot commented Aug 6, 2024

nextdreamblue commented Aug 6, 2024

[bugfix](backup)(cooldown) cancel backup properly when be backup failed #38724

[bugfix](backup)(cooldown) cancel backup properly when be backup failed #38724

Conversation

justfortaste commented Aug 1, 2024

doris-robot commented Aug 1, 2024

github-actions bot commented Aug 1, 2024

nextdreamblue commented Aug 1, 2024

doris-robot commented Aug 1, 2024

doris-robot commented Aug 1, 2024

doris-robot commented Aug 1, 2024

github-actions bot commented Aug 2, 2024

xy720 left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 2, 2024

github-actions bot commented Aug 2, 2024

xy720 commented Aug 2, 2024

doris-robot commented Aug 2, 2024

doris-robot commented Aug 2, 2024

doris-robot commented Aug 2, 2024

w41ter left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 5, 2024

dataroaring commented Aug 5, 2024

github-actions bot commented Aug 6, 2024

github-actions bot commented Aug 6, 2024

github-actions bot commented Aug 6, 2024

dataroaring left a comment

Choose a reason for hiding this comment

dataroaring commented Aug 6, 2024

doris-robot commented Aug 6, 2024

doris-robot commented Aug 6, 2024

doris-robot commented Aug 6, 2024

nextdreamblue commented Aug 6, 2024