Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement](audit log) Set print audit log sesssion variable default value to false #38865

Merged
merged 1 commit into from
Aug 5, 2024
Merged

[Enhancement](audit log) Set print audit log sesssion variable default value to false #38865

merged 1 commit into from
Aug 5, 2024

Conversation

Yukang-Lian
Copy link
Collaborator

Proposed changes

In #38419, we introduced a new variable enable_prepared_stmt_audit_log to make group commit faster. Here we set this session variable default value to false.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@github-actions github-actions bot added the doing label Aug 5, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 41653 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b8a6a5aa9f36bde1b05a749db39d8dfb3537efc3, data reload: false

------ Round 1 ----------------------------------
q1	18265	4147	4162	4147
q2	2464	210	203	203
q3	11374	1308	1343	1308
q4	10947	817	936	817
q5	7911	3037	2999	2999
q6	226	145	145	145
q7	1090	641	622	622
q8	9439	1913	1927	1913
q9	8425	6567	6526	6526
q10	8688	3816	3828	3816
q11	417	258	259	258
q12	413	236	230	230
q13	17758	2948	2969	2948
q14	270	243	241	241
q15	522	485	499	485
q16	486	400	387	387
q17	961	905	889	889
q18	7870	7294	7171	7171
q19	1424	1221	1213	1213
q20	575	330	346	330
q21	5304	4726	4820	4726
q22	345	284	279	279
Total cold run time: 115174 ms
Total hot run time: 41653 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4260	4042	3990	3990
q2	326	220	218	218
q3	2986	2987	2979	2979
q4	1872	1860	1850	1850
q5	5247	5248	5199	5199
q6	216	130	130	130
q7	2063	1710	1690	1690
q8	3160	3235	3197	3197
q9	8302	8270	8275	8270
q10	3751	3853	3832	3832
q11	547	454	455	454
q12	741	609	558	558
q13	13465	2993	2955	2955
q14	295	259	256	256
q15	525	469	479	469
q16	434	401	397	397
q17	1713	1698	1689	1689
q18	7747	7245	7128	7128
q19	1670	1682	1681	1681
q20	1975	1759	1759	1759
q21	5416	5176	5196	5176
q22	500	450	454	450
Total cold run time: 67211 ms
Total hot run time: 54327 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 167790 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b8a6a5aa9f36bde1b05a749db39d8dfb3537efc3, data reload: false

query1	918	376	368	368
query2	6481	1687	1643	1643
query3	6665	209	224	209
query4	19421	17355	17190	17190
query5	4312	509	517	509
query6	287	174	167	167
query7	4619	294	300	294
query8	253	210	204	204
query9	8508	2370	2374	2370
query10	437	282	258	258
query11	10579	10043	10073	10043
query12	138	88	89	88
query13	1667	377	363	363
query14	9208	6712	6465	6465
query15	206	158	162	158
query16	7111	420	451	420
query17	925	577	530	530
query18	1920	277	275	275
query19	193	143	141	141
query20	87	85	83	83
query21	202	101	97	97
query22	4153	3924	4097	3924
query23	33580	33084	32999	32999
query24	10318	3117	3067	3067
query25	663	378	392	378
query26	1802	145	148	145
query27	3028	270	281	270
query28	7054	1972	1959	1959
query29	1333	408	406	406
query30	282	149	150	149
query31	917	745	763	745
query32	104	55	53	53
query33	702	318	312	312
query34	904	468	483	468
query35	811	712	750	712
query36	996	861	843	843
query37	287	76	79	76
query38	2869	2776	2763	2763
query39	858	800	793	793
query40	281	112	112	112
query41	50	45	43	43
query42	121	100	101	100
query43	465	399	420	399
query44	1188	737	727	727
query45	205	183	178	178
query46	1081	793	785	785
query47	1824	1715	1730	1715
query48	361	282	287	282
query49	1190	418	407	407
query50	902	435	422	422
query51	6837	6699	6664	6664
query52	98	90	92	90
query53	252	176	182	176
query54	619	445	458	445
query55	81	75	77	75
query56	272	242	249	242
query57	1156	1067	1006	1006
query58	322	263	282	263
query59	2600	2542	2257	2257
query60	290	272	286	272
query61	94	95	92	92
query62	912	670	693	670
query63	213	181	182	181
query64	5877	1896	1915	1896
query65	3191	3071	3078	3071
query66	1428	332	333	332
query67	15384	14889	14819	14819
query68	4374	568	593	568
query69	448	301	294	294
query70	1109	1028	1066	1028
query71	413	277	271	271
query72	7064	2721	2467	2467
query73	759	327	331	327
query74	6028	5749	5686	5686
query75	3392	2731	2730	2730
query76	2443	1209	1282	1209
query77	425	318	325	318
query78	9362	9029	8918	8918
query79	1133	532	534	532
query80	1035	586	493	493
query81	567	222	223	222
query82	1346	130	129	129
query83	240	174	170	170
query84	262	84	80	80
query85	1135	327	296	296
query86	342	312	295	295
query87	3303	3091	3132	3091
query88	2912	2408	2449	2408
query89	392	291	282	282
query90	1990	193	195	193
query91	137	101	102	101
query92	65	49	54	49
query93	1246	622	617	617
query94	877	293	292	292
query95	378	271	315	271
query96	592	277	281	277
query97	3189	3039	3045	3039
query98	209	198	203	198
query99	1658	1287	1281	1281
Total cold run time: 260917 ms
Total hot run time: 167790 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.07 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b8a6a5aa9f36bde1b05a749db39d8dfb3537efc3, data reload: false

query1	0.05	0.04	0.04
query2	0.07	0.04	0.04
query3	0.23	0.04	0.05
query4	1.68	0.06	0.06
query5	0.48	0.47	0.48
query6	1.15	0.71	0.72
query7	0.02	0.01	0.01
query8	0.05	0.05	0.04
query9	0.56	0.51	0.52
query10	0.57	0.57	0.58
query11	0.16	0.11	0.11
query12	0.15	0.13	0.12
query13	0.61	0.61	0.60
query14	0.76	0.78	0.79
query15	0.91	0.87	0.88
query16	0.35	0.37	0.36
query17	1.05	1.02	1.02
query18	0.23	0.23	0.22
query19	1.87	1.72	1.76
query20	0.01	0.01	0.01
query21	15.40	0.75	0.66
query22	4.16	7.31	1.36
query23	17.92	1.42	1.36
query24	2.29	0.22	0.22
query25	0.19	0.08	0.07
query26	0.33	0.22	0.22
query27	0.46	0.24	0.22
query28	13.16	0.99	0.97
query29	12.52	3.28	3.26
query30	0.26	0.06	0.06
query31	2.86	0.41	0.40
query32	3.25	0.50	0.49
query33	2.91	2.97	2.89
query34	15.44	4.27	4.24
query35	4.29	4.29	4.30
query36	0.69	0.47	0.48
query37	0.19	0.17	0.16
query38	0.17	0.15	0.15
query39	0.04	0.04	0.03
query40	0.16	0.12	0.14
query41	0.09	0.05	0.04
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 107.85 s
Total hot run time: 30.07 s

dataroaring
dataroaring approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

PR approved by anyone and no changes requested.

@yiguolei yiguolei removed the doing label Aug 5, 2024
@yiguolei yiguolei merged commit a70e4da into apache:master Aug 5, 2024
29 of 31 checks passed
Yukang-Lian added a commit to Yukang-Lian/doris that referenced this pull request Aug 7, 2024
@Yukang-Lian
[Enhancement](audit log) Set print audit log sesssion variable defaul…
86f4c50 
…t value to false (apache#38865)

## Proposed changes

In apache#38419, we introduced a new variable `enable_prepared_stmt_audit_log`
to make group commit faster. Here we set this session variable default
value to false.

<!--Describe your changes.-->
@Yukang-Lian Yukang-Lian mentioned this pull request Aug 7, 2024
Merged
dataroaring pushed a commit that referenced this pull request Aug 7, 2024
@Yukang-Lian
[cherry-pick](branch-2.1) Pick "[Enhancement](audit log) Set print au…
36edfa0 
…dit log sesssion variable default value to false #38865" (#39009)

pick #38865
dataroaring pushed a commit that referenced this pull request Aug 11, 2024
@Yukang-Lian @dataroaring
[Enhancement](audit log) Set print audit log sesssion variable defaul…
d703eab 
…t value to false (#38865)

## Proposed changes

In #38419, we introduced a new variable `enable_prepared_stmt_audit_log`
to make group commit faster. Here we set this session variable default
value to false.

<!--Describe your changes.-->
dataroaring pushed a commit that referenced this pull request Aug 16, 2024
@Yukang-Lian @dataroaring
[Enhancement](audit log) Set print audit log sesssion variable defaul…
a30d276 
…t value to false (#38865)

## Proposed changes

In #38419, we introduced a new variable `enable_prepared_stmt_audit_log`
to make group commit faster. Here we set this session variable default
value to false.

<!--Describe your changes.-->
@gavinchou gavinchou mentioned this pull request Oct 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.2-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yukang-Lian @doris-robot @yiguolei @dataroaring