Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature](inverted index) Add multi_match function (#37722) #38877

Merged
merged 3 commits into from
Aug 10, 2024
Merged

[feature](inverted index) Add multi_match function (#37722) #38877

merged 3 commits into from
Aug 10, 2024

Conversation

zzzxl1993
Copy link
Contributor

@zzzxl1993 zzzxl1993 commented Aug 5, 2024 •
edited
Loading

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zzzxl1993
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Aug 5, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/vec/functions/function_multi_match.cpp
return Status::OK();
}

Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function 'eval_inverted_index' exceeds recommended size/complexity thresholds [readability-function-size]

Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context,
                           ^
Additional context

be/src/vec/functions/function_multi_match.cpp:94: 85 lines including whitespace and comments (threshold 80)

Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context,
                           ^

be/src/vec/functions/function_multi_match.h

#pragma once

#include <boost/algorithm/string/split.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'boost/algorithm/string/split.hpp' file not found [clang-diagnostic-error]

#include <boost/algorithm/string/split.hpp>
         ^

@zzzxl1993 zzzxl1993 force-pushed the branch-2.1.multi_match branch from 381c525 to 8d4a68f Compare August 5, 2024 10:54
@zzzxl1993
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.37% (9274/25499)
Line Coverage: 27.90% (75833/271846)
Region Coverage: 26.74% (39000/145835)
Branch Coverage: 23.47% (19793/84338)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8d4a68f4e133bff4353a41a28ec275e4352e6910_8d4a68f4e133bff4353a41a28ec275e4352e6910/report/index.html

@zzzxl1993
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.37% (9274/25497)
Line Coverage: 27.90% (75855/271868)
Region Coverage: 26.75% (39012/145858)
Branch Coverage: 23.47% (19801/84368)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3049aa9a37badf3a28e5e87d761c621a7a2e7c8c_3049aa9a37badf3a28e5e87d761c621a7a2e7c8c/report/index.html

@zzzxl1993 zzzxl1993 marked this pull request as draft August 6, 2024 12:27
@zzzxl1993 zzzxl1993 force-pushed the branch-2.1.multi_match branch from 3049aa9 to ae15ddc Compare August 7, 2024 03:53
@zzzxl1993
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/vec/functions/function_multi_match.cpp
return Status::OK();
}

Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function 'eval_inverted_index' exceeds recommended size/complexity thresholds [readability-function-size]

Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context,
                           ^
Additional context

be/src/vec/functions/function_multi_match.cpp:98: 81 lines including whitespace and comments (threshold 80)

Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context,
                           ^

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.37% (9274/25501)
Line Coverage: 27.89% (75852/271986)
Region Coverage: 26.73% (39010/145922)
Branch Coverage: 23.44% (19792/84420)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ae15ddcfd5ed63f4229911c90cd3e6780839c1d5_ae15ddcfd5ed63f4229911c90cd3e6780839c1d5/report/index.html

@zzzxl1993 zzzxl1993 force-pushed the branch-2.1.multi_match branch from ae15ddc to 2c03796 Compare August 7, 2024 07:25
@zzzxl1993 zzzxl1993 marked this pull request as ready for review August 7, 2024 15:24
@zzzxl1993
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.33% (9265/25500)
Line Coverage: 27.82% (75674/272030)
Region Coverage: 26.67% (38935/145969)
Branch Coverage: 23.39% (19753/84452)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2c037960192f679e3775e7ef35d9ed830aab22ee_2c037960192f679e3775e7ef35d9ed830aab22ee/report/index.html

zzzxl1993 and others added 3 commits August 9, 2024 20:00
@zzzxl1993
[feature](inverted index) Add multi_match function (apache#37722)
16f6d4b 
1. select * from tbl where multi_match(c1, 'c2, c3, c4',
'phrase_prefix', 'xxx');
2. multi_match performs a match_phrase_prefix query on the columns
specified in the first and second parameters. The value to be searched
is specified in the fourth parameter.
@zzzxl1993
[fix](inverted index) fix multi match result error
2486218
@zzzxl1993
[fix](inverted index) multi match distinguishes the inverted index v1…
ff3378d 
… and v2 (apache#39149)

## Proposed changes

1. reversed Index v1 and v2 have different column names
@zzzxl1993 zzzxl1993 force-pushed the branch-2.1.multi_match branch from 87e7494 to ff3378d Compare August 9, 2024 12:00
@zzzxl1993
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Aug 9, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/vec/functions/function_multi_match.cpp
return Status::OK();
}

Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function 'eval_inverted_index' exceeds recommended size/complexity thresholds [readability-function-size]

Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context,
                           ^
Additional context

be/src/vec/functions/function_multi_match.cpp:98: 87 lines including whitespace and comments (threshold 80)

Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context,
                           ^

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.46% (9299/25504)
Line Coverage: 27.98% (76200/272298)
Region Coverage: 26.80% (39154/146083)
Branch Coverage: 23.52% (19881/84536)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ff3378d5467d8efa0f1cf381f8670aafc90433fe_ff3378d5467d8efa0f1cf381f8670aafc90433fe/report/index.html

@xiaokang xiaokang merged commit 5e1e725 into apache:branch-2.1 Aug 10, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zzzxl1993 @doris-robot @xiaokang