Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](multi table) fix single stream multi table access denied in cloud mode #38878

Merged
merged 1 commit into from
Aug 6, 2024
Merged

[fix](multi table) fix single stream multi table access denied in cloud mode #38878

merged 1 commit into from
Aug 6, 2024

Conversation

sollhui
Copy link
Contributor

@sollhui sollhui commented Aug 5, 2024

Create single stream multi table job to load Kafka stream, error happened:

failed to get stream load plan, errCode = 2, detailMessage = Access denied for user
'doris_test@null' (using password: YES) '}

It is do not need check password for requests initiated internally for already check it when connection.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@sollhui
Copy link
Contributor Author

sollhui commented Aug 5, 2024

run buildall

@github-actions github-actions bot added the doing label Aug 5, 2024
@sollhui sollhui changed the title [fix](multi table) fix single stream multi table access denied [fix](multi table) fix single stream multi table access denied in cloud mode Aug 5, 2024
@sollhui
Copy link
Contributor Author

sollhui commented Aug 5, 2024

run buildall

@dataroaring dataroaring added the usercase Important user case type label label Aug 5, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 41694 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e0fd9b0cb0159522234579d067015c8ce5772e87, data reload: false

------ Round 1 ----------------------------------
q1	16677	4144	4108	4108
q2	2017	206	199	199
q3	10532	1290	1357	1290
q4	10334	848	961	848
q5	7592	3043	2959	2959
q6	223	138	137	137
q7	1058	611	612	611
q8	9446	1831	1933	1831
q9	8470	6606	6607	6606
q10	8697	3843	3842	3842
q11	426	253	251	251
q12	416	239	225	225
q13	17746	2942	2917	2917
q14	278	247	248	247
q15	538	490	492	490
q16	493	398	388	388
q17	956	919	903	903
q18	8103	7415	7335	7335
q19	1611	1242	1224	1224
q20	545	357	327	327
q21	5271	4710	4676	4676
q22	354	280	284	280
Total cold run time: 111783 ms
Total hot run time: 41694 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4136	4192	4044	4044
q2	322	233	224	224
q3	3008	2997	2966	2966
q4	1866	1859	1878	1859
q5	5235	5219	5185	5185
q6	218	129	130	129
q7	2073	1687	1691	1687
q8	3178	3300	3216	3216
q9	8245	8241	8250	8241
q10	3767	3818	3852	3818
q11	546	450	441	441
q12	724	536	571	536
q13	16778	2936	2974	2936
q14	285	261	260	260
q15	521	474	486	474
q16	451	402	399	399
q17	1745	1698	1695	1695
q18	7733	7330	7263	7263
q19	1694	1687	1715	1687
q20	1973	1757	1781	1757
q21	5365	5238	5220	5220
q22	540	482	467	467
Total cold run time: 70403 ms
Total hot run time: 54504 ms

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

TPC-DS: Total hot run time: 169149 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e0fd9b0cb0159522234579d067015c8ce5772e87, data reload: false

query1	922	389	373	373
query2	6463	1640	1681	1640
query3	6659	216	223	216
query4	20315	17659	17265	17265
query5	4319	506	518	506
query6	290	190	177	177
query7	4600	295	293	293
query8	266	205	200	200
query9	8531	2371	2366	2366
query10	436	296	257	257
query11	10590	10022	10026	10022
query12	130	89	86	86
query13	1623	367	369	367
query14	9335	7531	7623	7531
query15	218	159	158	158
query16	7134	484	440	440
query17	937	547	535	535
query18	1934	277	280	277
query19	188	145	141	141
query20	93	84	88	84
query21	206	97	99	97
query22	4240	4172	3841	3841
query23	33701	32928	33043	32928
query24	10385	3078	3016	3016
query25	665	385	379	379
query26	1767	154	157	154
query27	2923	268	272	268
query28	6962	1985	1970	1970
query29	1308	421	418	418
query30	284	151	150	150
query31	947	765	763	763
query32	99	54	54	54
query33	692	319	326	319
query34	926	480	479	479
query35	859	717	761	717
query36	995	853	867	853
query37	307	80	79	79
query38	2896	2741	2758	2741
query39	854	805	816	805
query40	279	115	115	115
query41	47	47	45	45
query42	124	98	103	98
query43	462	404	412	404
query44	1217	736	726	726
query45	203	175	176	175
query46	1123	839	785	785
query47	1810	1718	1725	1718
query48	368	283	291	283
query49	1203	427	427	427
query50	897	438	429	429
query51	6729	6614	6781	6614
query52	107	90	91	90
query53	259	183	179	179
query54	633	462	456	456
query55	74	73	75	73
query56	270	263	268	263
query57	1164	1029	1038	1029
query58	294	275	275	275
query59	2543	2394	2278	2278
query60	289	274	261	261
query61	105	114	114	114
query62	935	661	676	661
query63	217	184	182	182
query64	5985	1995	1960	1960
query65	3168	3094	3091	3091
query66	1465	351	341	341
query67	15305	14953	14771	14771
query68	4338	574	598	574
query69	453	310	304	304
query70	1055	1075	1085	1075
query71	421	283	281	281
query72	7290	2838	2645	2645
query73	792	328	333	328
query74	6114	5683	5614	5614
query75	3364	2774	2725	2725
query76	2400	1206	1293	1206
query77	443	313	312	312
query78	9474	8972	8927	8927
query79	2356	521	526	521
query80	1248	514	508	508
query81	540	227	232	227
query82	768	133	134	133
query83	203	174	174	174
query84	274	77	85	77
query85	1466	313	305	305
query86	466	281	315	281
query87	3309	3141	3108	3108
query88	3694	2394	2434	2394
query89	382	294	291	291
query90	1902	192	186	186
query91	127	98	98	98
query92	59	50	50	50
query93	2140	619	621	619
query94	849	293	292	292
query95	373	265	266	265
query96	610	285	277	277
query97	3262	3098	3058	3058
query98	230	198	191	191
query99	1671	1295	1321	1295
Total cold run time: 265347 ms
Total hot run time: 169149 ms

Copy link
Contributor

github-actions bot commented Aug 5, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 5, 2024
Copy link
Contributor

github-actions bot commented Aug 5, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

ClickBench: Total hot run time: 30.67 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e0fd9b0cb0159522234579d067015c8ce5772e87, data reload: false

query1	0.05	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.04	0.05
query4	1.66	0.06	0.06
query5	0.48	0.49	0.49
query6	1.17	0.72	0.71
query7	0.02	0.02	0.02
query8	0.05	0.04	0.05
query9	0.57	0.52	0.52
query10	0.59	0.57	0.57
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.62	0.60	0.59
query14	0.76	0.80	0.78
query15	0.89	0.87	0.86
query16	0.36	0.35	0.36
query17	1.00	0.99	1.00
query18	0.22	0.21	0.22
query19	1.84	1.77	1.75
query20	0.01	0.02	0.01
query21	15.40	0.76	0.66
query22	3.84	7.26	2.06
query23	18.09	1.32	1.24
query24	2.28	0.22	0.21
query25	0.19	0.08	0.07
query26	0.32	0.22	0.21
query27	0.46	0.22	0.22
query28	13.16	0.99	0.98
query29	12.52	3.30	3.27
query30	0.25	0.06	0.05
query31	2.86	0.42	0.41
query32	3.23	0.48	0.48
query33	2.94	2.92	2.94
query34	15.43	4.29	4.27
query35	4.29	4.29	4.27
query36	0.67	0.47	0.48
query37	0.19	0.16	0.16
query38	0.16	0.14	0.15
query39	0.04	0.03	0.03
query40	0.16	0.14	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.04
query43	0.05	0.04	0.04
Total cold run time: 107.59 s
Total hot run time: 30.67 s

Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 16ab9ad into apache:master Aug 6, 2024
30 of 31 checks passed
dataroaring pushed a commit that referenced this pull request Aug 6, 2024
…ud mode (#38878)

Create single stream multi table job to load Kafka stream, error
happened:
```
failed to get stream load plan, errCode = 2, detailMessage = Access denied for user
'doris_test@null' (using password: YES) '}
```

It is do not need check password for requests initiated internally for
already check it when connection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.1-merged doing reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants