Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](create table) fix nereids create table no check buckets=0 #38971

Merged
merged 1 commit into from
Aug 7, 2024
Merged

[fix](create table) fix nereids create table no check buckets=0 #38971

merged 1 commit into from
Aug 7, 2024

Conversation

yujun777
Copy link
Collaborator

@yujun777 yujun777 commented Aug 6, 2024

Fix: nereids create table no check buckets=0

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@yujun777
Copy link
Collaborator Author

yujun777 commented Aug 6, 2024

run buildall

@github-actions github-actions bot added the doing label Aug 6, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 41377 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5d84a169f204eed6cd3b734e488a98755e19e98e, data reload: false

------ Round 1 ----------------------------------
q1	18107	4160	4173	4160
q2	2238	198	211	198
q3	10518	1213	1334	1213
q4	10154	791	914	791
q5	7647	2957	2936	2936
q6	218	135	134	134
q7	1045	617	617	617
q8	9436	1890	1946	1890
q9	8497	6512	6553	6512
q10	8701	3816	3813	3813
q11	424	248	253	248
q12	410	229	226	226
q13	17757	2921	2925	2921
q14	270	245	241	241
q15	526	479	473	473
q16	479	388	380	380
q17	947	903	911	903
q18	7968	7254	7200	7200
q19	1377	1198	1199	1198
q20	569	315	329	315
q21	5304	4719	4804	4719
q22	346	293	289	289
Total cold run time: 112938 ms
Total hot run time: 41377 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4003	3980	3954	3954
q2	330	222	219	219
q3	3006	2999	2989	2989
q4	1891	1843	1866	1843
q5	5231	5195	5201	5195
q6	214	128	126	126
q7	2014	1663	1695	1663
q8	3148	3247	3255	3247
q9	8225	8241	8217	8217
q10	3737	3777	3806	3777
q11	546	457	444	444
q12	715	560	527	527
q13	15248	2950	2911	2911
q14	288	267	253	253
q15	514	469	476	469
q16	436	389	387	387
q17	1698	1688	1670	1670
q18	7600	7340	7135	7135
q19	1649	1701	1642	1642
q20	1965	1763	1745	1745
q21	5315	5231	5176	5176
q22	513	475	467	467
Total cold run time: 68286 ms
Total hot run time: 54056 ms

deardeng
deardeng approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@deardeng deardeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-DS: Total hot run time: 168226 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5d84a169f204eed6cd3b734e488a98755e19e98e, data reload: false

query1	919	366	382	366
query2	6492	1648	1646	1646
query3	6687	207	222	207
query4	20067	17490	17273	17273
query5	4335	514	504	504
query6	294	165	160	160
query7	4586	304	300	300
query8	271	195	201	195
query9	8475	2364	2360	2360
query10	464	277	268	268
query11	10701	10025	9931	9931
query12	136	88	90	88
query13	1664	388	373	373
query14	8460	6695	7004	6695
query15	218	167	167	167
query16	7101	481	466	466
query17	968	549	568	549
query18	1920	302	286	286
query19	193	155	152	152
query20	96	89	88	88
query21	206	100	100	100
query22	4185	3992	4036	3992
query23	33838	32892	33109	32892
query24	10404	3013	3015	3013
query25	721	402	417	402
query26	1864	151	156	151
query27	3002	278	279	278
query28	7013	1968	1959	1959
query29	1398	437	426	426
query30	287	152	148	148
query31	957	759	746	746
query32	107	60	55	55
query33	713	314	326	314
query34	920	486	488	486
query35	853	717	724	717
query36	998	855	851	851
query37	295	80	79	79
query38	2837	2758	2730	2730
query39	847	809	818	809
query40	286	114	115	114
query41	49	47	46	46
query42	118	100	107	100
query43	470	415	414	414
query44	1191	722	726	722
query45	204	178	176	176
query46	1078	789	774	774
query47	1821	1732	1721	1721
query48	371	295	292	292
query49	1203	432	435	432
query50	914	430	426	426
query51	6760	6647	6673	6647
query52	99	94	90	90
query53	268	191	178	178
query54	635	463	462	462
query55	82	76	75	75
query56	276	267	268	267
query57	1158	1075	1039	1039
query58	280	278	279	278
query59	2620	2349	2350	2349
query60	317	278	286	278
query61	119	117	226	117
query62	918	652	658	652
query63	214	184	178	178
query64	5858	1914	1896	1896
query65	3158	3121	3089	3089
query66	1461	334	342	334
query67	15497	14876	14901	14876
query68	6742	563	597	563
query69	723	367	316	316
query70	1114	1017	1060	1017
query71	552	285	270	270
query72	8144	2696	2467	2467
query73	946	334	332	332
query74	6050	5651	5659	5651
query75	4318	2719	2705	2705
query76	5246	1253	1287	1253
query77	750	312	320	312
query78	9612	8894	8957	8894
query79	3276	546	576	546
query80	966	506	510	506
query81	553	223	237	223
query82	735	127	134	127
query83	337	178	182	178
query84	266	81	77	77
query85	1443	303	325	303
query86	411	280	300	280
query87	3328	3140	3074	3074
query88	3466	2396	2428	2396
query89	431	291	288	288
query90	2059	189	186	186
query91	123	101	98	98
query92	61	49	53	49
query93	4452	612	625	612
query94	950	291	296	291
query95	391	271	258	258
query96	618	280	280	280
query97	3199	2988	3027	2988
query98	218	196	195	195
query99	1612	1247	1307	1247
Total cold run time: 276009 ms
Total hot run time: 168226 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.52 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5d84a169f204eed6cd3b734e488a98755e19e98e, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.04	0.03
query3	0.22	0.04	0.05
query4	1.68	0.07	0.06
query5	0.50	0.48	0.48
query6	1.16	0.71	0.71
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.57	0.51	0.52
query10	0.57	0.58	0.57
query11	0.16	0.12	0.12
query12	0.15	0.12	0.13
query13	0.60	0.61	0.60
query14	0.78	0.78	0.79
query15	0.94	0.87	0.86
query16	0.35	0.36	0.35
query17	1.01	0.98	0.98
query18	0.22	0.21	0.22
query19	1.90	1.85	1.74
query20	0.01	0.01	0.02
query21	15.47	0.76	0.66
query22	4.17	5.96	1.82
query23	17.96	1.36	1.31
query24	2.26	0.22	0.22
query25	0.17	0.08	0.09
query26	0.32	0.21	0.21
query27	0.46	0.24	0.23
query28	13.18	0.98	0.97
query29	12.55	3.32	3.27
query30	0.28	0.05	0.06
query31	2.88	0.40	0.41
query32	3.26	0.48	0.48
query33	2.93	3.00	2.96
query34	15.42	4.25	4.26
query35	4.28	4.28	4.30
query36	0.66	0.48	0.48
query37	0.19	0.16	0.16
query38	0.16	0.14	0.15
query39	0.04	0.03	0.04
query40	0.16	0.13	0.15
query41	0.10	0.05	0.05
query42	0.06	0.05	0.06
query43	0.05	0.03	0.04
Total cold run time: 108.01 s
Total hot run time: 30.52 s

dataroaring
dataroaring approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring added dev/2.1.x dev/2.0.x usercase Important user case type label labels Aug 7, 2024
@dataroaring dataroaring merged commit e0cfd72 into apache:master Aug 7, 2024
31 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 7, 2024
dataroaring pushed a commit that referenced this pull request Aug 7, 2024
@yujun777 @dataroaring
[fix](create table) fix nereids create table no check buckets=0 (#38971)
da944cf 
Fix: nereids create table no check buckets=0
yujun777 added a commit to yujun777/doris that referenced this pull request Aug 7, 2024
@yujun777
[fix](create table) fix nereids create table no check buckets=0 (apac…
dacf06a 
…he#38971)

Fix: nereids create table no check buckets=0
This was referenced Aug 7, 2024
Merged
Merged
dataroaring pushed a commit that referenced this pull request Aug 7, 2024
@yujun777
[fix](create table) fix nereids create table no check buckets=0 #38971 (
ba51637 
#39000)

cherry pick from #38971
dataroaring pushed a commit that referenced this pull request Aug 9, 2024
@yujun777
[fix](create table) fix nereids create table no check buckets=0 #38971 (
80b6345 
#38999)

cherry pick from #38971
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Aug 14, 2024
@yujun777 @wyxxxcat
[fix](create table) fix nereids create table no check buckets=0 (apac…
9d3b531 
…he#38971)

Fix: nereids create table no check buckets=0
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Aug 27, 2024
@yujun777
[fix](create table) fix nereids create table no check buckets=0 apach…
39512ff 
…e#38971 (apache#39000)

cherry pick from apache#38971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deardeng deardeng deardeng approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.15-merged dev/2.1.6-merged dev/3.0.1-merged doing reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yujun777 @doris-robot @deardeng @dataroaring