[fix](inverted index) warm up inverted index #38986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41854 ms |
TPC-DS: Total hot run time: 170506 ms |
ClickBench: Total hot run time: 30.12 s |
csun5285
suggested changes
Aug 7, 2024
| }; | ||
| _engine.file_cache_block_downloader().submit_download_task(std::move(meta)); | ||
| }; | ||
| auto idx_version = rs->tablet_schema()->get_inverted_index_storage_format(); |
There was a problem hiding this comment.
if (rs->tablet_schema()->has_inverted_index())
| @@ -114,6 +114,40 @@ void CloudWarmUpManager::handle_jobs() { | |||
| wait->signal(); | |||
| }, | |||
| }); | |||
|
|
|||
| // idx | |||
| auto download_idx_file = [&](const io::Path& idx_path) { | |||
There was a problem hiding this comment.
The CloudTablet::add_rowsets also requires this.
gavinchou
reviewed
Aug 7, 2024
| @@ -76,7 +76,7 @@ class FileCacheBlockDownloader { | |||
|
|
|||
| private: | |||
| void download_file_cache_block(const DownloadTask::FileCacheBlockMetaVec&); | |||
| void download_segment_file(const DownloadFileMeta&); | |||
| void download_file(const DownloadFileMeta&); | |||
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 39965 ms |
TPC-H: Total hot run time: 39746 ms |
TPC-DS: Total hot run time: 201626 ms |
ClickBench: Total hot run time: 31.18 s |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
dataroaring
pushed a commit
that referenced
this pull request
Aug 11, 2024
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx