Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](group commit) Modify group commit commit/abort txn timeout as stream load #39003

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Aug 7, 2024

No description provided.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions github-actions bot added the doing label Aug 7, 2024
@mymeiyi
Copy link
Contributor Author

mymeiyi commented Aug 7, 2024

run buildall

Copy link
Contributor

github-actions bot commented Aug 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

github-actions bot commented Aug 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@hust-hhb hust-hhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Aug 7, 2024

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 7, 2024
Copy link
Contributor

github-actions bot commented Aug 7, 2024

PR approved by at least one committer and no changes requested.

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Aug 7, 2024

run performance

@doris-robot
Copy link

TPC-H: Total hot run time: 41411 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6b1864c3c85fa9be99e1c5b6f4ee51a0dc633bbb, data reload: false

------ Round 1 ----------------------------------
q1	17672	4071	4057	4057
q2	2023	201	198	198
q3	10486	1247	1306	1247
q4	10155	788	898	788
q5	7680	2971	2980	2971
q6	219	135	133	133
q7	1058	615	618	615
q8	9421	1757	1944	1757
q9	8593	6629	6599	6599
q10	8772	3828	3869	3828
q11	432	246	251	246
q12	446	228	226	226
q13	17758	2920	2948	2920
q14	283	243	244	243
q15	526	479	498	479
q16	520	408	383	383
q17	964	932	934	932
q18	7977	7394	7233	7233
q19	1542	1225	1215	1215
q20	588	336	331	331
q21	5354	4848	4731	4731
q22	347	279	291	279
Total cold run time: 112816 ms
Total hot run time: 41411 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4093	4009	4034	4009
q2	322	220	223	220
q3	3015	2980	3134	2980
q4	2028	2101	1966	1966
q5	5608	5492	5443	5443
q6	219	133	129	129
q7	2138	1853	1835	1835
q8	3325	3356	3349	3349
q9	8607	8681	8720	8681
q10	3924	4049	3943	3943
q11	548	457	464	457
q12	791	599	613	599
q13	16449	3084	3117	3084
q14	315	275	272	272
q15	520	487	494	487
q16	476	426	421	421
q17	1797	1755	1723	1723
q18	8243	7829	7695	7695
q19	3523	1784	1759	1759
q20	2106	1851	1844	1844
q21	5683	5540	5335	5335
q22	525	456	481	456
Total cold run time: 74255 ms
Total hot run time: 56687 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 170006 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6b1864c3c85fa9be99e1c5b6f4ee51a0dc633bbb, data reload: false

query1	899	377	365	365
query2	6475	1790	1734	1734
query3	6667	213	222	213
query4	20097	17549	17248	17248
query5	3642	528	537	528
query6	288	183	157	157
query7	4602	303	311	303
query8	248	193	201	193
query9	8492	2333	2298	2298
query10	470	266	268	266
query11	10660	10036	10084	10036
query12	124	98	86	86
query13	1650	384	383	383
query14	9367	6864	6906	6864
query15	220	163	170	163
query16	6981	429	446	429
query17	965	572	561	561
query18	1926	301	286	286
query19	201	148	146	146
query20	95	87	87	87
query21	203	102	101	101
query22	4277	4170	4088	4088
query23	33790	33679	33381	33381
query24	9265	3139	3116	3116
query25	686	428	427	427
query26	1410	157	157	157
query27	2834	282	289	282
query28	7479	2016	1991	1991
query29	1043	480	464	464
query30	251	156	157	156
query31	958	777	822	777
query32	116	59	64	59
query33	691	328	345	328
query34	924	525	506	506
query35	893	807	782	782
query36	1085	886	911	886
query37	212	85	87	85
query38	2975	2797	2786	2786
query39	889	797	805	797
query40	260	116	116	116
query41	49	46	45	45
query42	128	113	106	106
query43	482	428	439	428
query44	1177	742	733	733
query45	214	180	177	177
query46	1085	812	776	776
query47	1806	1727	1753	1727
query48	385	302	296	296
query49	875	432	444	432
query50	900	442	442	442
query51	6764	6733	6585	6585
query52	104	87	91	87
query53	256	186	193	186
query54	621	459	455	455
query55	78	77	76	76
query56	286	278	261	261
query57	1118	1181	1072	1072
query58	272	268	272	268
query59	3007	2903	2658	2658
query60	291	265	274	265
query61	110	109	91	91
query62	901	670	665	665
query63	210	180	179	179
query64	4862	1899	1889	1889
query65	3126	3077	3080	3077
query66	955	329	322	322
query67	15410	14850	14881	14850
query68	6129	584	582	582
query69	734	394	328	328
query70	1152	1057	1066	1057
query71	541	284	276	276
query72	8167	2678	2533	2533
query73	950	327	332	327
query74	6107	5801	5571	5571
query75	4380	2689	2695	2689
query76	4287	1245	1288	1245
query77	753	309	315	309
query78	9569	9003	8975	8975
query79	2969	525	528	525
query80	2104	495	502	495
query81	561	229	229	229
query82	872	142	133	133
query83	269	184	172	172
query84	268	81	79	79
query85	1449	314	298	298
query86	435	298	308	298
query87	3273	3146	3096	3096
query88	3734	2404	2408	2404
query89	395	302	286	286
query90	2008	192	196	192
query91	134	98	104	98
query92	65	50	50	50
query93	4348	624	634	624
query94	927	286	275	275
query95	386	269	264	264
query96	620	278	283	278
query97	3229	3093	3071	3071
query98	227	206	195	195
query99	1631	1273	1317	1273
Total cold run time: 272455 ms
Total hot run time: 170006 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.87 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6b1864c3c85fa9be99e1c5b6f4ee51a0dc633bbb, data reload: false

query1	0.05	0.04	0.04
query2	0.07	0.03	0.04
query3	0.22	0.05	0.06
query4	1.67	0.07	0.08
query5	0.49	0.50	0.49
query6	1.14	0.71	0.71
query7	0.01	0.01	0.01
query8	0.05	0.04	0.04
query9	0.56	0.51	0.51
query10	0.56	0.56	0.57
query11	0.15	0.11	0.11
query12	0.14	0.12	0.12
query13	0.62	0.60	0.59
query14	0.77	0.78	0.82
query15	0.89	0.87	0.85
query16	0.36	0.36	0.37
query17	0.99	0.99	1.04
query18	0.22	0.24	0.21
query19	1.82	1.71	1.76
query20	0.01	0.01	0.02
query21	15.40	0.75	0.65
query22	4.10	7.55	1.16
query23	17.79	1.33	1.31
query24	2.29	0.22	0.22
query25	0.19	0.08	0.08
query26	0.33	0.22	0.21
query27	0.45	0.24	0.24
query28	13.16	1.00	0.96
query29	12.51	3.29	3.28
query30	0.25	0.06	0.06
query31	2.86	0.41	0.40
query32	3.26	0.50	0.48
query33	2.91	2.96	2.98
query34	15.44	4.26	4.26
query35	4.30	4.29	4.28
query36	0.68	0.46	0.47
query37	0.19	0.17	0.16
query38	0.16	0.16	0.15
query39	0.04	0.04	0.04
query40	0.16	0.14	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.05
Total cold run time: 107.47 s
Total hot run time: 29.87 s

@dataroaring dataroaring merged commit 2f11a4c into apache:master Aug 7, 2024
29 of 30 checks passed
mymeiyi added a commit to mymeiyi/doris that referenced this pull request Aug 8, 2024
dataroaring pushed a commit that referenced this pull request Aug 8, 2024
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.1-merged doing reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants