Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug](brpc) fix sync_filter_size/apply_filterv2 has wrong closure #39155

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Aug 9, 2024

Proposed changes

  1. fix sync_filter_size/apply_filterv2 has wrong closure
  2. avoid to use thread local storage of iobuf

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the doing label Aug 9, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt BiteTheDDDDt changed the title [Improvement](brpc) do not create iobuf on RuntimeFilterMergeControllerEntity::merge [Bug](brpc) fix sync_filter_size/apply_filterv2 has wrong clouse Aug 12, 2024
@BiteTheDDDDt BiteTheDDDDt changed the title [Bug](brpc) fix sync_filter_size/apply_filterv2 has wrong clouse [Bug](brpc) fix sync_filter_size/apply_filterv2 has wrong closure Aug 12, 2024
@BiteTheDDDDt
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 13, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei added usercase Important user case type label dev/2.1.6-merged dev/3.0.x labels Aug 13, 2024
@BiteTheDDDDt BiteTheDDDDt merged commit ee356e5 into apache:master Aug 13, 2024
31 of 33 checks passed
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Aug 14, 2024
…ache#39155)

## Proposed changes
1. fix sync_filter_size/apply_filterv2 has wrong closure
2. avoid to use thread local storage of iobuf
dataroaring pushed a commit that referenced this pull request Aug 17, 2024
…9155)

## Proposed changes
1. fix sync_filter_size/apply_filterv2 has wrong closure
2. avoid to use thread local storage of iobuf
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Nov 12, 2024
…ache#39155)

## Proposed changes
1. fix sync_filter_size/apply_filterv2 has wrong closure
2. avoid to use thread local storage of iobuf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.2-merged doing reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants