Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improvement](iceberg)add some description for show create #39179

Merged
merged 5 commits into from
Aug 11, 2024
Merged

[improvement](iceberg)add some description for show create #39179

merged 5 commits into from
Aug 11, 2024

Conversation

wuwenchi
Copy link
Contributor

@wuwenchi wuwenchi commented Aug 9, 2024

Proposed changes

  1. add location and properties for show create table.
  2. add location for show create database.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@wuwenchi
Copy link
Contributor Author

wuwenchi commented Aug 9, 2024

run buildall

@github-actions github-actions bot added the doing label Aug 9, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 39966 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f9ba0ab81cb0e9e78d3afe5e04b5740a5d81af1c, data reload: false

------ Round 1 ----------------------------------
q1	17882	4495	4527	4495
q2	2592	180	201	180
q3	10899	1211	1176	1176
q4	10639	740	668	668
q5	7541	2566	2582	2566
q6	227	147	145	145
q7	989	612	602	602
q8	9659	1966	1900	1900
q9	8758	6559	6560	6559
q10	6989	2257	2258	2257
q11	472	247	245	245
q12	399	220	231	220
q13	17756	2984	2977	2977
q14	277	238	237	237
q15	530	487	492	487
q16	489	387	394	387
q17	956	683	701	683
q18	7979	7661	7483	7483
q19	5658	1053	1020	1020
q20	710	341	350	341
q21	5703	4336	4565	4336
q22	1106	1033	1002	1002
Total cold run time: 118210 ms
Total hot run time: 39966 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4461	4256	4254	4254
q2	376	276	259	259
q3	2857	2666	2622	2622
q4	1884	1671	1636	1636
q5	5292	5245	5186	5186
q6	217	133	131	131
q7	2035	1728	1685	1685
q8	3141	3335	3321	3321
q9	8378	8356	8386	8356
q10	3620	3156	3161	3156
q11	597	511	498	498
q12	761	612	611	611
q13	16346	2991	2998	2991
q14	306	273	279	273
q15	525	487	481	481
q16	473	432	419	419
q17	1774	1485	1485	1485
q18	7650	7495	7292	7292
q19	1682	1584	1363	1363
q20	1992	1795	1786	1786
q21	5078	5113	5181	5113
q22	1076	996	982	982
Total cold run time: 70521 ms
Total hot run time: 53900 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 201433 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f9ba0ab81cb0e9e78d3afe5e04b5740a5d81af1c, data reload: false

query1	919	370	360	360
query2	6446	1925	1805	1805
query3	6656	212	219	212
query4	34360	23337	23177	23177
query5	4168	504	516	504
query6	300	172	160	160
query7	4579	291	287	287
query8	248	201	201	201
query9	8608	2465	2432	2432
query10	540	481	440	440
query11	16226	15010	15001	15001
query12	149	100	98	98
query13	1638	372	368	368
query14	10668	7714	7817	7714
query15	283	225	216	216
query16	7763	506	459	459
query17	1752	567	557	557
query18	1917	280	279	279
query19	191	144	144	144
query20	113	109	111	109
query21	208	102	100	100
query22	4200	4066	3992	3992
query23	33785	33256	33238	33238
query24	11961	2632	2619	2619
query25	657	382	390	382
query26	1703	161	159	159
query27	2929	280	286	280
query28	7724	2034	2035	2034
query29	1061	437	431	431
query30	312	152	145	145
query31	994	756	750	750
query32	98	61	57	57
query33	743	308	284	284
query34	951	465	466	465
query35	936	830	827	827
query36	1088	920	916	916
query37	279	82	84	82
query38	4272	4094	4155	4094
query39	1445	1365	1370	1365
query40	284	116	123	116
query41	46	46	45	45
query42	112	98	98	98
query43	500	473	480	473
query44	1175	754	734	734
query45	236	212	209	209
query46	1110	717	739	717
query47	1859	1746	1762	1746
query48	377	301	302	301
query49	1204	435	433	433
query50	814	412	408	408
query51	6784	6662	6615	6615
query52	100	99	88	88
query53	260	188	184	184
query54	1052	466	459	459
query55	83	75	79	75
query56	275	244	264	244
query57	1181	1072	1084	1072
query58	256	241	233	233
query59	3051	2752	2672	2672
query60	299	272	275	272
query61	118	116	113	113
query62	835	621	668	621
query63	217	184	184	184
query64	10647	2265	1722	1722
query65	3196	3295	3136	3136
query66	1372	355	333	333
query67	15356	14857	14774	14774
query68	8082	559	572	559
query69	461	428	414	414
query70	1192	1107	1115	1107
query71	559	273	275	273
query72	20198	16925	16619	16619
query73	829	332	331	331
query74	9323	8821	8773	8773
query75	4845	2651	2634	2634
query76	4830	1014	992	992
query77	823	312	319	312
query78	9647	9063	8908	8908
query79	9795	536	532	532
query80	853	511	543	511
query81	601	223	222	222
query82	292	132	130	130
query83	334	148	142	142
query84	269	79	75	75
query85	1027	284	268	268
query86	347	295	275	275
query87	4659	4555	4544	4544
query88	4482	2491	2500	2491
query89	460	289	281	281
query90	2185	193	196	193
query91	119	94	98	94
query92	64	49	49	49
query93	4884	553	549	549
query94	1129	288	303	288
query95	352	311	261	261
query96	615	273	273	273
query97	3212	3040	3040	3040
query98	214	203	208	203
query99	1448	1289	1270	1270
Total cold run time: 333799 ms
Total hot run time: 201433 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.79 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f9ba0ab81cb0e9e78d3afe5e04b5740a5d81af1c, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.04
query4	1.67	0.08	0.07
query5	0.48	0.47	0.47
query6	1.14	0.74	0.72
query7	0.03	0.01	0.01
query8	0.05	0.04	0.04
query9	0.55	0.49	0.50
query10	0.54	0.52	0.54
query11	0.15	0.11	0.11
query12	0.15	0.12	0.13
query13	0.59	0.60	0.58
query14	0.76	0.79	0.77
query15	0.87	0.80	0.82
query16	0.36	0.36	0.36
query17	1.01	1.00	1.02
query18	0.23	0.22	0.23
query19	1.79	1.70	1.81
query20	0.01	0.01	0.02
query21	15.40	0.76	0.68
query22	3.76	7.66	2.19
query23	18.30	1.39	1.29
query24	2.10	0.25	0.20
query25	0.15	0.09	0.08
query26	0.29	0.21	0.22
query27	0.45	0.23	0.22
query28	13.26	1.02	0.99
query29	12.58	3.32	3.26
query30	0.24	0.05	0.04
query31	2.90	0.40	0.39
query32	3.25	0.47	0.45
query33	2.84	2.95	2.91
query34	16.97	4.33	4.31
query35	4.42	4.43	4.45
query36	0.65	0.46	0.46
query37	0.18	0.16	0.16
query38	0.16	0.15	0.14
query39	0.04	0.04	0.03
query40	0.15	0.11	0.12
query41	0.10	0.05	0.04
query42	0.05	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.02 s
Total hot run time: 30.79 s

morningman
morningman approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

PR approved by anyone and no changes requested.

kaka11chen
kaka11chen approved these changes Aug 11, 2024
View reviewed changes
Copy link
Contributor

@kaka11chen kaka11chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit c35e931 into apache:master Aug 11, 2024
30 of 31 checks passed
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Aug 14, 2024
@wuwenchi @wyxxxcat
[improvement](iceberg)add some description for show create (apache#…
efe5ddb 
…39179)

## Proposed changes

1. add `location` and `properties` for `show create table`.
2. add `location` for `show create database`.
dataroaring pushed a commit that referenced this pull request Aug 17, 2024
@wuwenchi @dataroaring
[improvement](iceberg)add some description for show create (#39179)
21c946f 
## Proposed changes

1. add `location` and `properties` for `show create table`.
2. add `location` for `show create database`.
wuwenchi added a commit to wuwenchi/doris_new that referenced this pull request Aug 20, 2024
@wuwenchi
[improvement](iceberg)add some description for show create (apache#…
6e687ef 
…39179)

## Proposed changes

1. add `location` and `properties` for `show create table`.
2. add `location` for `show create database`.
@wuwenchi wuwenchi mentioned this pull request Aug 20, 2024
Merged
yiguolei pushed a commit that referenced this pull request Aug 21, 2024
@wuwenchi
[improvement](iceberg)add some description for show create for 2.1 #3…
28ce116 
…9179 (#39644)

## Proposed changes

bp: #39179

1. add `location` and `properties` for `show create table`.
2. add `location` for `show create database`.
@gavinchou gavinchou mentioned this pull request Oct 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaka11chen kaka11chen kaka11chen approved these changes

@morningman morningman morningman approved these changes

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

@CalvinKirs CalvinKirs Awaiting requested review from CalvinKirs CalvinKirs is a code owner

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.2-merged doing reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wuwenchi @doris-robot @kaka11chen @morningman @yiguolei @dataroaring