-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](catalog) gen partition id by name #39325
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by anyone and no changes requested. |
run buildall |
run buildall |
TPC-H: Total hot run time: 38023 ms
|
TPC-DS: Total hot run time: 185357 ms
|
ClickBench: Total hot run time: 30.97 s
|
run buildall |
TPC-H: Total hot run time: 37266 ms
|
TPC-DS: Total hot run time: 189571 ms
|
ClickBench: Total hot run time: 30.84 s
|
run buildall |
TPC-H: Total hot run time: 38462 ms
|
TPC-DS: Total hot run time: 195890 ms
|
ClickBench: Total hot run time: 31.75 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
Followup apache#38525 Previously, we use sequence number to generate partition id of table in hive metastore. for example, there are 2 partitions: `dt=2024-10-02` and `dt=2024-10-03`, the partition id will be 0 and 1. But if a new partition being added: `dt=2024-10-01`, the partiton id will be 0, 1, and 2. You can see, before, the id `0` is for `dt=2024-10-02`, but now `0` is for `dt=2024-10-01`. This PR use catalog/db/table/partition name to generate a id for the partition, so that each partition will have unique id.
Followup #38525 Previously, we use sequence number to generate partition id of table in hive metastore. for example, there are 2 partitions: `dt=2024-10-02` and `dt=2024-10-03`, the partition id will be 0 and 1. But if a new partition being added: `dt=2024-10-01`, the partiton id will be 0, 1, and 2. You can see, before, the id `0` is for `dt=2024-10-02`, but now `0` is for `dt=2024-10-01`. This PR use catalog/db/table/partition name to generate a id for the partition, so that each partition will have unique id.
Followup #38525
Previously, we use sequence number to generate partition id of table in hive metastore.
for example, there are 2 partitions:
dt=2024-10-02
anddt=2024-10-03
, the partition id will be 0 and 1.But if a new partition being added:
dt=2024-10-01
, the partiton id will be 0, 1, and 2.You can see, before, the id
0
is fordt=2024-10-02
, but now0
is fordt=2024-10-01
.This PR use catalog/db/table/partition name to generate a id for the partition,
so that each partition will have unique id.