Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](fe-log) add position info in async mode #39419

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

morningman
Copy link
Contributor

@morningman morningman commented Aug 15, 2024

followup #37793
NORMAL: sync flush + with location
ASYNC(default): async flush + with location
BRIEF: async flush + without location

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

gavinchou
gavinchou previously approved these changes Aug 15, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 15, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@caiconghui
Copy link
Contributor

caiconghui commented Aug 15, 2024

this config is used to improve log4j performance, so I suggest that to make best performance for brief mode without location and async flush, and the default config is async which is with location and async flush

@caiconghui
Copy link
Contributor

so we need to modify illustration for this config

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 16, 2024
Copy link
Contributor

@caiconghui caiconghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 16, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@gavinchou
Copy link
Contributor

run buildall

@morningman
Copy link
Contributor Author

run performance

@doris-robot
Copy link

TPC-H: Total hot run time: 38580 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 282a4b9cc7ae682ea29868fd789168e4017d2a19, data reload: false

------ Round 1 ----------------------------------
q1	18131	4418	4358	4358
q2	2048	206	207	206
q3	12420	972	1120	972
q4	10543	729	764	729
q5	7789	2873	2807	2807
q6	266	157	155	155
q7	1024	647	673	647
q8	10552	2102	2102	2102
q9	7358	6651	6650	6650
q10	7137	2246	2283	2246
q11	487	283	271	271
q12	453	262	263	262
q13	18126	3196	3138	3138
q14	316	291	270	270
q15	574	568	522	522
q16	764	431	429	429
q17	1159	715	758	715
q18	8081	6808	6724	6724
q19	7192	1032	1105	1032
q20	672	347	334	334
q21	3824	2983	2985	2983
q22	1122	1041	1028	1028
Total cold run time: 120038 ms
Total hot run time: 38580 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5387	4316	4305	4305
q2	394	306	306	306
q3	2848	2738	2774	2738
q4	1967	1657	1698	1657
q5	5670	5576	5595	5576
q6	232	144	143	143
q7	2106	1748	1779	1748
q8	3329	3486	3404	3404
q9	8775	8696	8893	8696
q10	3590	3241	3288	3241
q11	641	520	523	520
q12	837	642	665	642
q13	17186	3027	3062	3027
q14	340	301	292	292
q15	567	532	527	527
q16	514	463	434	434
q17	1871	1603	1531	1531
q18	8402	8054	7731	7731
q19	10589	1771	1525	1525
q20	3238	1896	1893	1893
q21	7377	5390	5246	5246
q22	1501	1090	1088	1088
Total cold run time: 87361 ms
Total hot run time: 56270 ms

@morningman morningman merged commit 2bdff39 into apache:master Aug 19, 2024
30 of 32 checks passed
morningman added a commit to morningman/doris that referenced this pull request Aug 19, 2024
morningman added a commit that referenced this pull request Aug 20, 2024
dataroaring pushed a commit that referenced this pull request Aug 26, 2024
followup #37793
NORMAL:  sync flush + with location
ASYNC(default): async flush + with location
BRIEF: async flush + without location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants