[Bug](predicate) fix wrong result of AcceptNullPredicate #39497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
yiguolei
reviewed
Aug 17, 2024
| @@ -158,21 +156,26 @@ class AcceptNullPredicate : public ColumnPredicate { | |||
| } | |||
| // create selected_flags | |||
| uint16_t max_idx = sel[size - 1]; | |||
| std::vector<uint16_t> old_sel(size); | |||
yiguolei
reviewed
Aug 18, 2024
| // add rows selected by _nested->evaluate | ||
| for (uint16_t i = 0; i < new_size; ++i) { | ||
| uint16_t row_idx = sel[i]; | ||
| selected[row_idx] = true; | ||
| } | ||
| for (uint16_t i = 0; i < size; ++i) { |
yiguolei
reviewed
Aug 19, 2024
| @@ -158,21 +156,26 @@ class AcceptNullPredicate : public ColumnPredicate { | |||
| } | |||
| // create selected_flags | |||
| uint16_t max_idx = sel[size - 1]; | |||
| std::vector<uint16_t> old_sel(size); | |||
| memcpy(old_sel.data(), sel, sizeof(uint16_t) * size); | |||
|
|
|||
| const auto& nullable_col = assert_cast<const vectorized::ColumnNullable&>(column); | |||
| // call nested predicate evaluate | |||
| uint16_t new_size = _nested->evaluate(nullable_col.get_nested_column(), sel, size); | |||
|
|
|||
There was a problem hiding this comment.
sel 1,2,3,7,8,9
sel 1,2,3,4,5,6,7,8,9
|
run buildall |
|
run buildall |
yiguolei
reviewed
Aug 19, 2024
| const auto& nullable_col = assert_cast<const vectorized::ColumnNullable&>(column); | ||
| _nested->evaluate_and(nullable_col.get_nested_column(), sel, size, flags); | ||
| const auto& nullmap = nullable_col.get_null_map_data(); | ||
| for (uint16_t i = 0; i < size; ++i) { | ||
| flags[i] |= nullmap[sel[i]]; | ||
| flags[i] |= (original_flags[i] && nullmap[sel[i]]); |
There was a problem hiding this comment.
我觉得这里不对吧
是不是应该是 flags[sel[i]] |= (original_flags[sel[i]] && nullmap[sel[i]]);
yiguolei
reviewed
Aug 19, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
yiguolei
approved these changes
Aug 19, 2024
|
run buildall |
yiguolei
approved these changes
Aug 19, 2024
BiteTheDDDDt
added a commit
to BiteTheDDDDt/incubator-doris
that referenced
this pull request
Aug 21, 2024
fix wrong result of AcceptNullPredicate
yiguolei
pushed a commit
that referenced
this pull request
Aug 21, 2024
dataroaring
added
dev/3.0.x
dev/3.0.1-merged
dev/3.0.2-merged
and removed
dev/3.0.x
dev/3.0.1-merged
labels
dataroaring
pushed a commit
that referenced
this pull request
Aug 26, 2024
## Proposed changes fix wrong result of AcceptNullPredicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fix wrong result of AcceptNullPredicate