-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](routine load) do not cancel job if not found transaction #39514
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 38061 ms
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 38059 ms
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TPC-H: Total hot run time: 38422 ms
|
TPC-DS: Total hot run time: 191069 ms
|
ClickBench: Total hot run time: 31.4 s
|
run buildall |
TPC-H: Total hot run time: 38407 ms
|
TPC-DS: Total hot run time: 192582 ms
|
ClickBench: Total hot run time: 31.14 s
|
run buildall |
run buildall |
TPC-H: Total hot run time: 37562 ms
|
TPC-DS: Total hot run time: 195982 ms
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If do not find transaction when planning for the routine load task, the routine load job will be canceled. In cloud mode, it may RPC timeout. Meanwhile, it should not cancel the job if the transaction cannot be found, as the job can still be rescheduled.
If do not find transaction when planning for the routine load task, the routine load job will be canceled. In cloud mode, it may RPC timeout. Meanwhile, it should not cancel the job if the transaction cannot be found, as the job can still be rescheduled.