Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](cloud) Retry commit_txn should return ok except 2pc, consistent with local mode #39615

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

SWJTU-ZhangLei
Copy link
Contributor

  • sometimes, the network error between meta-service and fe/be make commit_txn timeout, the fe/be will retry to commit_txn, meta-service should return ok except 2pc

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@SWJTU-ZhangLei
Copy link
Contributor Author

run buildall

* sometimes, the network error between `meta-service` and fe/be
  make `commit_txn` timeout, the fe/be will retry to `commit_txn`,
  `meta-service` should return ok except 2pc
@SWJTU-ZhangLei
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@gavinchou gavinchou changed the title [fix](cloud) Retry commit_txn should return ok except 2pc [fix](cloud) Retry commit_txn should return ok except 2pc, consistent with local mode Aug 21, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 21, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 3553bc6 into apache:master Aug 22, 2024
29 of 31 checks passed
dataroaring pushed a commit that referenced this pull request Aug 22, 2024
…nt with local mode (#39615)

* sometimes, the network error between `meta-service` and fe/be make
`commit_txn` timeout, the fe/be will retry to `commit_txn`,
`meta-service` should return ok except 2pc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.2-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants