Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug](compatibility) fix window funnel function coredump when upgrade #39648

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

zhangstar333
Copy link
Contributor

Proposed changes

as the branch-2.1 is used the new impl of window funnel, and the be_exec_version is 5
but in branch-3.0 this be_exec_version have update to 7, so when upgrade from branch-2.1 to branch-3.0
maybe have error send the branch-3.0 version of version 7 to branch-2.1([0---version--5])

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhangstar333
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 38173 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fdd98d8fccaa0042262d9f6c0fc9d2fb982b6ed2, data reload: false

------ Round 1 ----------------------------------
q1	18144	4452	4370	4370
q2	2494	215	203	203
q3	11506	1144	1173	1144
q4	10686	824	782	782
q5	8102	2874	2836	2836
q6	266	162	163	162
q7	1032	677	665	665
q8	9396	2054	2090	2054
q9	7322	6548	6517	6517
q10	7058	2236	2247	2236
q11	490	281	261	261
q12	419	249	251	249
q13	18961	2985	3008	2985
q14	296	255	259	255
q15	568	523	526	523
q16	540	412	403	403
q17	994	722	716	716
q18	7450	6872	6657	6657
q19	5704	1015	1054	1015
q20	723	352	338	338
q21	3897	2997	2762	2762
q22	1128	1094	1040	1040
Total cold run time: 117176 ms
Total hot run time: 38173 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4476	4273	4251	4251
q2	409	311	297	297
q3	2875	2624	2649	2624
q4	1951	1663	1656	1656
q5	5382	5420	5414	5414
q6	234	152	150	150
q7	2095	1733	1714	1714
q8	3222	3378	3328	3328
q9	8444	8397	8433	8397
q10	3413	3176	3174	3174
q11	660	525	525	525
q12	797	664	639	639
q13	16402	3038	3010	3010
q14	336	300	295	295
q15	581	537	531	531
q16	506	458	464	458
q17	1790	1517	1516	1516
q18	7793	7612	7426	7426
q19	1718	1617	1671	1617
q20	2041	1855	1842	1842
q21	8857	5086	5058	5058
q22	1151	1049	1063	1049
Total cold run time: 75133 ms
Total hot run time: 54971 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191514 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fdd98d8fccaa0042262d9f6c0fc9d2fb982b6ed2, data reload: false

query1	961	390	391	390
query2	6746	2028	1940	1940
query3	6670	238	240	238
query4	33356	23404	23203	23203
query5	4423	722	711	711
query6	319	218	210	210
query7	4621	336	333	333
query8	474	436	441	436
query9	8719	2531	2532	2531
query10	493	329	337	329
query11	17921	14945	14970	14945
query12	173	129	134	129
query13	1694	452	433	433
query14	10004	7302	6666	6666
query15	291	196	188	188
query16	7566	518	523	518
query17	1630	617	584	584
query18	2059	344	346	344
query19	241	171	172	171
query20	146	140	138	138
query21	256	147	147	147
query22	4392	4006	4034	4006
query23	34222	33302	33398	33302
query24	11392	2977	2944	2944
query25	654	430	436	430
query26	1190	182	180	180
query27	2635	298	305	298
query28	7398	2133	2090	2090
query29	816	460	442	442
query30	320	192	213	192
query31	1078	861	829	829
query32	124	82	84	82
query33	817	357	352	352
query34	919	514	506	506
query35	920	761	802	761
query36	1096	959	984	959
query37	169	106	104	104
query38	4007	3886	3927	3886
query39	1547	1531	1481	1481
query40	239	160	157	157
query41	143	142	140	140
query42	135	117	120	117
query43	553	533	503	503
query44	1254	782	798	782
query45	226	195	203	195
query46	1138	798	785	785
query47	1939	1866	1870	1866
query48	410	344	343	343
query49	1255	588	580	580
query50	866	494	472	472
query51	7149	7130	7073	7073
query52	131	109	118	109
query53	300	230	229	229
query54	916	515	507	507
query55	91	91	92	91
query56	334	321	308	308
query57	1264	1112	1155	1112
query58	333	304	353	304
query59	3301	2769	2789	2769
query60	356	330	333	330
query61	151	149	150	149
query62	922	716	702	702
query63	260	229	225	225
query64	5440	2395	1845	1845
query65	3318	3186	3204	3186
query66	1399	820	782	782
query67	15633	15140	15128	15128
query68	8452	594	617	594
query69	701	456	352	352
query70	1238	1144	1194	1144
query71	558	323	330	323
query72	7415	2352	2088	2088
query73	1650	368	367	367
query74	9214	8859	8901	8859
query75	5155	2763	2781	2763
query76	5089	1043	987	987
query77	887	440	515	440
query78	9797	9183	9189	9183
query79	7586	549	551	549
query80	1069	634	609	609
query81	630	261	267	261
query82	317	167	159	159
query83	356	218	216	216
query84	301	99	98	98
query85	1054	367	363	363
query86	382	329	326	326
query87	4462	4402	4236	4236
query88	4497	2564	2546	2546
query89	543	332	327	327
query90	2076	240	234	234
query91	160	130	167	130
query92	96	76	77	76
query93	6123	562	567	562
query94	1000	333	326	326
query95	393	297	296	296
query96	631	290	286	286
query97	3218	3063	3114	3063
query98	253	228	230	228
query99	1680	1334	1306	1306
Total cold run time: 318898 ms
Total hot run time: 191514 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.89 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fdd98d8fccaa0042262d9f6c0fc9d2fb982b6ed2, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.05
query3	0.23	0.06	0.04
query4	1.66	0.08	0.07
query5	0.51	0.48	0.51
query6	1.13	0.73	0.73
query7	0.03	0.02	0.02
query8	0.06	0.05	0.05
query9	0.55	0.49	0.50
query10	0.54	0.55	0.55
query11	0.17	0.13	0.13
query12	0.16	0.13	0.12
query13	0.63	0.60	0.59
query14	0.76	0.80	0.79
query15	0.84	0.83	0.83
query16	0.38	0.38	0.38
query17	1.05	1.00	1.00
query18	0.22	0.20	0.20
query19	1.95	1.78	1.80
query20	0.01	0.02	0.01
query21	15.40	0.66	0.67
query22	3.75	8.42	1.67
query23	18.29	1.44	1.28
query24	2.12	0.24	0.23
query25	0.15	0.09	0.08
query26	0.27	0.18	0.18
query27	0.08	0.07	0.08
query28	13.25	1.03	1.02
query29	12.64	3.34	3.33
query30	0.42	0.19	0.18
query31	2.80	0.39	0.39
query32	3.27	0.48	0.48
query33	2.94	2.98	3.02
query34	16.99	4.33	4.37
query35	4.40	4.41	4.40
query36	0.67	0.49	0.51
query37	0.21	0.18	0.18
query38	0.17	0.17	0.17
query39	0.07	0.06	0.06
query40	0.17	0.15	0.15
query41	0.12	0.07	0.07
query42	0.08	0.07	0.07
query43	0.07	0.06	0.07
Total cold run time: 109.36 s
Total hot run time: 30.89 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 21, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen hello-stephen merged commit 1301b0b into apache:master Aug 21, 2024
28 of 31 checks passed
dataroaring pushed a commit that referenced this pull request Aug 21, 2024
…#39648)

## Proposed changes

as the branch-2.1 is used the new impl of window funnel, and the
be_exec_version is 5
but in branch-3.0 this be_exec_version have update to 7, so when upgrade
from branch-2.1 to branch-3.0
maybe have error send the branch-3.0 version of version 7 to
branch-2.1([0---version--5])

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.2-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants