-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](cloud) should do before commit check in cloud mode #39775
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
1 similar comment
run buildall |
TPC-H: Total hot run time: 38199 ms
|
TPC-DS: Total hot run time: 186940 ms
|
ClickBench: Total hot run time: 30.48 s
|
run buildall |
TPC-H: Total hot run time: 38274 ms
|
TPC-DS: Total hot run time: 191756 ms
|
ClickBench: Total hot run time: 30.57 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In cloud mode, there is no before commit check when commit transaction. For routine load, job may be paused during sub task execution. If these transactions are committed, the problem is: 1. The progress seen by the user may not be accurate. It will consume data repeatedly if they create a new job consumption using this progress. 2. The user's modification offset operation may be overwritten by the offset of the transaction callback.
In cloud mode, there is no before commit check when commit transaction. For routine load, job may be paused during sub task execution. If these transactions are committed, the problem is: