-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](cloud) Fix cloud auto start and add a regression case #40027
Conversation
deardeng
commented
Aug 28, 2024
•
edited by gavinchou
Loading
edited by gavinchou
- Fix the cluster being suspended and select not waking up the cluster. The reason is that all be nodes in the cluster are inactive, the cluster is skipped, and the cluster that needs to be woken up cannot be found, and the wake-up logic will not be reached. And delete the redundant function getAuthorizedCloudCluster
- Add check after resume cluster, there must be at least one alive be in the cluster.
- add auto start regression case
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 38371 ms
|
TPC-DS: Total hot run time: 193084 ms
|
ClickBench: Total hot run time: 32.3 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR, describe below, what is the bug and how was it fixed, and then the removed segment of code, as well as changing the return type from void to string, does it involve a behavior change?
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run buildall |
TPC-H: Total hot run time: 37905 ms
|
TPC-DS: Total hot run time: 186730 ms
|
ClickBench: Total hot run time: 32.09 s
|
PR approved by at least one committer and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. Fix the cluster being suspended and select not waking up the cluster. The reason is that all be nodes in the cluster are inactive, the cluster is skipped, and the cluster that needs to be woken up cannot be found, and the wake-up logic will not be reached. And delete the redundant function getAuthorizedCloudCluster 2. Add check after resume cluster, there must be at least one alive be in the cluster. 3. add auto start regression case