[fix](restore) Reset next version for remote table when restore #40118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
@w41ter please help to review, thank you. |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
TPC-H: Total hot run time: 38251 ms |
TPC-DS: Total hot run time: 187956 ms |
ClickBench: Total hot run time: 33.16 s |
w41ter
pushed a commit
to w41ter/incubator-doris
that referenced
this pull request
Aug 30, 2024
…he#40118) We should reset next version to visible version + 1 for all partitions of remote table, when restoring table that do not exist locally. 在高并发insert场景，CCR源端表的next version可能比visible version大比较多，目标集群restore全量快照后，切换到增量binlog后，commit事务时使用的version（来自next version）就可能比当前visible version大比较多。 此时，对于MoW表，就会出现publish version不连续，增量binlog一直无法publish的问题。事务状态会一直是`COMMITTED`，并伴随类似ErrMsg `wait for publishing partition 15027 version 1037597. self version: 1037627. table 15025`。
w41ter
pushed a commit
to w41ter/incubator-doris
that referenced
this pull request
Aug 30, 2024
…he#40118) We should reset next version to visible version + 1 for all partitions of remote table, when restoring table that do not exist locally. 在高并发insert场景，CCR源端表的next version可能比visible version大比较多，目标集群restore全量快照后，切换到增量binlog后，commit事务时使用的version（来自next version）就可能比当前visible version大比较多。 此时，对于MoW表，就会出现publish version不连续，增量binlog一直无法publish的问题。事务状态会一直是`COMMITTED`，并伴随类似ErrMsg `wait for publishing partition 15027 version 1037597. self version: 1037627. table 15025`。
yiguolei
pushed a commit
that referenced
this pull request
Aug 30, 2024
#40165) cherry pick from #40118 Co-authored-by: smallx <[email protected]>
w41ter
added a commit
that referenced
this pull request
Aug 30, 2024
#40166) cherry pick from #40118 Co-authored-by: smallx <[email protected]>
dataroaring
pushed a commit
that referenced
this pull request
Sep 3, 2024
We should reset next version to visible version + 1 for all partitions of remote table, when restoring table that do not exist locally. 在高并发insert场景，CCR源端表的next version可能比visible version大比较多，目标集群restore全量快照后，切换到增量binlog后，commit事务时使用的version（来自next version）就可能比当前visible version大比较多。 此时，对于MoW表，就会出现publish version不连续，增量binlog一直无法publish的问题。事务状态会一直是`COMMITTED`，并伴随类似ErrMsg `wait for publishing partition 15027 version 1037597. self version: 1037627. table 15025`。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should reset next version to visible version + 1 for all partitions of remote table, when restoring table that do not exist locally.
在高并发insert场景，CCR源端表的next version可能比visible version大比较多，目标集群restore全量快照后，切换到增量binlog后，commit事务时使用的version（来自next version）就可能比当前visible version大比较多。
此时，对于MoW表，就会出现publish version不连续，增量binlog一直无法publish的问题。事务状态会一直是
COMMITTED，并伴随类似ErrMsgwait for publishing partition 15027 version 1037597. self version: 1037627. table 15025。