-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](recycler) Implement missing delete_prefix() of hdfs accessor #40215
[fix](recycler) Implement missing delete_prefix() of hdfs accessor #40215
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
clang-tidy review says "All clean, LGTM! 👍" |
run buildall |
TPC-H: Total hot run time: 37972 ms
|
TPC-DS: Total hot run time: 188676 ms
|
ClickBench: Total hot run time: 32.48 s
|
21db926
to
15ce85a
Compare
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38280 ms
|
TPC-DS: Total hot run time: 192593 ms
|
ClickBench: Total hot run time: 31.59 s
|
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To test it, 1. enable commit_rowset fail with injection point 2. issue a streamload 3. check the recycler log or storage vault the uncommitted rowset recycled ``` curl 'be_ip:http_port/api/injection_point/enable' curl 'be_ip:http_port/api/injection_point/clear' curl "be_ip:http_port/api/injection_point/set?name=CloudMetaMgr::commit_rowset&behavior=return_error" curl -XPUT --location-trusted -vv -T tmp/1.csv -H'format:csv' -H 'column_separator:,' -H'timeout:60' -uroot: be_ip:http_port/api/db1/t2/_stream_load curl 'be_ip:http_port/api/injection_point/clear' curl 'be_ip:http_port/api/injection_point/disable' ```
7c87f68
15ce85a
to
7c87f68
Compare
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38185 ms
|
TPC-DS: Total hot run time: 192956 ms
|
ClickBench: Total hot run time: 32.03 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…40215) To test it, 1. enable commit_rowset fail with injection point 2. issue a streamload 3. check the recycler log or storage vault the uncommitted rowset recycled ``` curl 'be_ip:http_port/api/injection_point/enable' curl 'be_ip:http_port/api/injection_point/clear' curl "be_ip:http_port/api/injection_point/set?name=CloudMetaMgr::commit_rowset&behavior=return_error" curl -XPUT --location-trusted -vv -T tmp/1.csv -H'format:csv' -H 'column_separator:,' -H'timeout:60' -uroot: be_ip:http_port/api/db1/t2/_stream_load curl 'be_ip:http_port/api/injection_point/clear' curl 'be_ip:http_port/api/injection_point/disable' ```
To test it,