Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement](balance) change unnecessary write locks to read locks in cloud balance #40633

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

luwei16
Copy link
Contributor

@luwei16 luwei16 commented Sep 10, 2024

No description provided.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@luwei16
Copy link
Contributor Author

luwei16 commented Sep 10, 2024

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 10, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 38369 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 778d724e920bff68651b9510693ce2d86d0897f9, data reload: false

------ Round 1 ----------------------------------
q1	18832	4528	4492	4492
q2	2949	199	189	189
q3	11008	1157	1169	1157
q4	10773	760	802	760
q5	8704	2902	2847	2847
q6	229	141	140	140
q7	979	635	618	618
q8	9341	2055	2062	2055
q9	7052	6551	6523	6523
q10	7019	2269	2251	2251
q11	491	252	251	251
q12	402	224	226	224
q13	17867	3077	3104	3077
q14	278	253	260	253
q15	531	484	504	484
q16	519	440	438	438
q17	986	673	737	673
q18	7608	6827	6880	6827
q19	1401	1103	1015	1015
q20	691	332	333	332
q21	3965	3041	2754	2754
q22	1101	1027	1009	1009
Total cold run time: 112726 ms
Total hot run time: 38369 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4361	4309	4315	4309
q2	386	284	277	277
q3	2981	2696	2654	2654
q4	1943	1660	1659	1659
q5	5422	5447	5423	5423
q6	223	133	135	133
q7	2122	1734	1781	1734
q8	3261	3359	3355	3355
q9	8493	8519	8517	8517
q10	3465	3261	3232	3232
q11	610	499	513	499
q12	811	623	617	617
q13	14497	3098	3074	3074
q14	308	278	280	278
q15	537	499	484	484
q16	537	469	487	469
q17	1802	1497	1508	1497
q18	7682	7551	7331	7331
q19	1670	1671	1401	1401
q20	2090	1827	1859	1827
q21	5583	5159	5273	5159
q22	1118	1032	1064	1032
Total cold run time: 69902 ms
Total hot run time: 54961 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192398 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 778d724e920bff68651b9510693ce2d86d0897f9, data reload: false

query1	911	378	391	378
query2	6479	2035	1963	1963
query3	6643	210	214	210
query4	34452	23362	23146	23146
query5	4260	524	491	491
query6	252	163	167	163
query7	4593	295	287	287
query8	287	232	223	223
query9	8664	2506	2518	2506
query10	480	288	282	282
query11	17095	14986	15149	14986
query12	159	98	97	97
query13	1624	393	370	370
query14	10017	6697	6921	6697
query15	283	172	177	172
query16	8072	484	485	484
query17	1568	564	544	544
query18	2124	296	284	284
query19	243	156	155	155
query20	121	112	116	112
query21	207	110	109	109
query22	4601	4351	4202	4202
query23	34409	33705	33549	33549
query24	11118	2937	2832	2832
query25	623	394	381	381
query26	1237	161	157	157
query27	2604	286	274	274
query28	7102	2039	2024	2024
query29	840	405	400	400
query30	305	165	152	152
query31	1007	742	792	742
query32	93	55	55	55
query33	755	317	283	283
query34	949	481	462	462
query35	871	709	717	709
query36	1071	911	909	909
query37	160	87	85	85
query38	4045	3878	3881	3878
query39	1469	1398	1405	1398
query40	215	111	114	111
query41	49	50	48	48
query42	117	95	97	95
query43	512	460	479	460
query44	1172	764	754	754
query45	198	169	166	166
query46	1100	720	711	711
query47	1935	1815	1819	1815
query48	375	296	294	294
query49	1103	433	447	433
query50	808	415	421	415
query51	6938	6818	6863	6818
query52	103	87	85	85
query53	255	185	175	175
query54	913	466	463	463
query55	79	76	74	74
query56	274	270	251	251
query57	1227	1092	1095	1092
query58	242	263	239	239
query59	2977	2891	2815	2815
query60	296	265	268	265
query61	100	98	100	98
query62	831	652	660	652
query63	214	194	188	188
query64	4326	677	639	639
query65	3258	3204	3151	3151
query66	1457	343	333	333
query67	16126	15445	15279	15279
query68	3123	841	833	833
query69	434	316	319	316
query70	1158	1146	1102	1102
query71	335	347	329	329
query72	6261	3726	3651	3651
query73	590	578	578	578
query74	8992	8862	8889	8862
query75	3186	2949	2958	2949
query76	1846	833	830	830
query77	495	404	409	404
query78	10263	9125	9217	9125
query79	931	886	857	857
query80	833	824	808	808
query81	448	270	266	266
query82	269	268	278	268
query83	210	206	205	205
query84	233	111	110	110
query85	707	446	449	446
query86	305	309	304	304
query87	4444	4325	4383	4325
query88	4341	4154	4119	4119
query89	378	357	367	357
query90	1533	327	318	318
query91	137	135	136	135
query92	81	76	74	74
query93	897	911	894	894
query94	591	374	369	369
query95	438	425	421	421
query96	474	473	475	473
query97	3099	3090	3087	3087
query98	251	226	223	223
query99	1408	1290	1316	1290
Total cold run time: 287684 ms
Total hot run time: 192398 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.3 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 778d724e920bff68651b9510693ce2d86d0897f9, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.04
query4	1.68	0.07	0.07
query5	0.50	0.50	0.50
query6	1.12	0.75	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.50	0.49
query10	0.52	0.57	0.56
query11	0.16	0.12	0.12
query12	0.14	0.12	0.13
query13	0.60	0.58	0.59
query14	1.41	1.42	1.43
query15	0.84	0.83	0.82
query16	0.38	0.36	0.38
query17	1.05	1.02	1.03
query18	0.23	0.20	0.21
query19	1.87	1.73	1.73
query20	0.01	0.02	0.01
query21	15.39	0.67	0.66
query22	5.27	6.65	1.68
query23	18.21	1.42	1.31
query24	2.09	0.25	0.22
query25	0.15	0.09	0.08
query26	0.27	0.17	0.18
query27	0.09	0.07	0.08
query28	13.22	1.04	1.02
query29	12.62	3.37	3.36
query30	0.24	0.06	0.05
query31	2.87	0.40	0.41
query32	3.24	0.48	0.47
query33	2.97	3.01	2.98
query34	16.83	4.40	4.41
query35	4.58	4.47	4.45
query36	0.65	0.48	0.48
query37	0.19	0.16	0.16
query38	0.15	0.15	0.14
query39	0.05	0.04	0.04
query40	0.15	0.13	0.13
query41	0.10	0.04	0.05
query42	0.06	0.06	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.9 s
Total hot run time: 31.3 s

@dataroaring dataroaring merged commit 1690c55 into apache:master Sep 11, 2024
26 of 29 checks passed
@gavinchou gavinchou added the p0_c label Sep 12, 2024
gavinchou pushed a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.2-merged p0_c reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants