-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug](compatibility) fix covar_samp function coredump when upgrade #41023
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 41728 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 190747 ms
|
ClickBench: Total hot run time: 32.45 s
|
run buildall |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41269 ms
|
TPC-DS: Total hot run time: 195496 ms
|
ClickBench: Total hot run time: 32.69 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
…41023) ## Proposed changes in branch-2.1, the function covar_samp mode is PropagateNullable eg: select covar_samp(non_nullable(x), y) from test_covar_samp; x, y has nullable, and return is nullable and now the column of non_nullable(x), y is nullable should check is nullable alone. the fixed in branch-21 #39943 <!--Describe your changes.-->
Proposed changes
in branch-2.1, the function covar_samp mode is PropagateNullable
eg: select covar_samp(non_nullable(x), y) from test_covar_samp;
x, y has nullable, and return is nullable
and now the column of non_nullable(x), y is nullable should check is nullable alone.
the fixed in branch-21
#39943