-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](cloud) ensure afterCommit/afterAbort will always be called when commit/abort transaction fails #41267
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 41066 ms
|
run buildall |
TPC-H: Total hot run time: 41279 ms
|
TPC-DS: Total hot run time: 191939 ms
|
ClickBench: Total hot run time: 32.63 s
|
run buildall |
fe/fe-core/src/main/java/org/apache/doris/cloud/transaction/CloudGlobalTransactionMgr.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/cloud/transaction/CloudGlobalTransactionMgr.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/cloud/transaction/CloudGlobalTransactionMgr.java
Outdated
Show resolved
Hide resolved
TPC-H: Total hot run time: 40904 ms
|
TPC-DS: Total hot run time: 192368 ms
|
ClickBench: Total hot run time: 32.06 s
|
run buildall |
TPC-H: Total hot run time: 40855 ms
|
fe/fe-core/src/main/java/org/apache/doris/cloud/transaction/CloudGlobalTransactionMgr.java
Outdated
Show resolved
Hide resolved
TPC-DS: Total hot run time: 192589 ms
|
ClickBench: Total hot run time: 32.42 s
|
run buildall |
1 similar comment
run buildall |
TPC-H: Total hot run time: 40606 ms
|
TPC-DS: Total hot run time: 192900 ms
|
run buildall |
TPC-H: Total hot run time: 41089 ms
|
TPC-DS: Total hot run time: 191924 ms
|
ClickBench: Total hot run time: 32.25 s
|
run buildall |
run buildall |
1 similar comment
run buildall |
TPC-H: Total hot run time: 40924 ms
|
TPC-DS: Total hot run time: 194635 ms
|
ClickBench: Total hot run time: 32.64 s
|
run buildall |
1 similar comment
run buildall |
TPC-H: Total hot run time: 40868 ms
|
TPC-DS: Total hot run time: 191365 ms
|
ClickBench: Total hot run time: 32.75 s
|
… transaction fails
run buildall |
TPC-H: Total hot run time: 40761 ms
|
TPC-DS: Total hot run time: 190984 ms
|
ClickBench: Total hot run time: 32.48 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
… commit/abort transaction fails (#41267) Ensure afterCommit/afterAbort will always be called when commit/abort transaction fails. Otherwise, it may cause some problems, such as the routing load getting stuck.
… commit/abort transaction fails (apache#41267) Ensure afterCommit/afterAbort will always be called when commit/abort transaction fails. Otherwise, it may cause some problems, such as the routing load getting stuck.
… commit/abort transaction fails (apache#41267) Ensure afterCommit/afterAbort will always be called when commit/abort transaction fails. Otherwise, it may cause some problems, such as the routing load getting stuck.
Ensure afterCommit/afterAbort will always be called when commit/abort transaction fails. Otherwise, it may cause some problems, such as the routing load getting stuck.