Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode #41636

Merged
merged 5 commits into from
Dec 10, 2024
Merged

[improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode #41636

merged 5 commits into from
Dec 10, 2024

Conversation

hust-hhb
Copy link
Contributor

pr #40204 remove delete bitmap on cloud mode, this pr is used for local mode

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@hust-hhb
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.24% (9644/25896)
Line Coverage: 28.54% (79966/280165)
Region Coverage: 27.98% (41345/147768)
Branch Coverage: 24.59% (21052/85612)
Coverage Report: http://coverage.selectdb-in.cc/coverage/73d9c5a3fda0ff0d36b8b4a2a8bd20b99e46d142_73d9c5a3fda0ff0d36b8b4a2a8bd20b99e46d142/report/index.html

@BiteTheDDDDt
Copy link
Contributor

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.41% (9663/25828)
Line Coverage: 28.69% (80188/279504)
Region Coverage: 28.12% (41459/147427)
Branch Coverage: 24.72% (21116/85414)
Coverage Report: http://coverage.selectdb-in.cc/coverage/73d9c5a3fda0ff0d36b8b4a2a8bd20b99e46d142_73d9c5a3fda0ff0d36b8b4a2a8bd20b99e46d142/report/index.html

@hust-hhb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.41% (9662/25829)
Line Coverage: 28.68% (80163/279529)
Region Coverage: 28.11% (41457/147479)
Branch Coverage: 24.71% (21111/85440)
Coverage Report: http://coverage.selectdb-in.cc/coverage/73d9c5a3fda0ff0d36b8b4a2a8bd20b99e46d142_73d9c5a3fda0ff0d36b8b4a2a8bd20b99e46d142/report/index.html

@hust-hhb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.40% (9660/25828)
Line Coverage: 28.67% (80153/279566)
Region Coverage: 28.10% (41446/147493)
Branch Coverage: 24.71% (21115/85450)
Coverage Report: http://coverage.selectdb-in.cc/coverage/73d9c5a3fda0ff0d36b8b4a2a8bd20b99e46d142_73d9c5a3fda0ff0d36b8b4a2a8bd20b99e46d142/report/index.html

@hust-hhb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.46% (9717/25938)
Line Coverage: 28.73% (80602/280525)
Region Coverage: 28.16% (41679/148021)
Branch Coverage: 24.72% (21179/85682)
Coverage Report: http://coverage.selectdb-in.cc/coverage/73d9c5a3fda0ff0d36b8b4a2a8bd20b99e46d142_73d9c5a3fda0ff0d36b8b4a2a8bd20b99e46d142/report/index.html

@hust-hhb
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.92% (9850/25975)
Line Coverage: 29.19% (82094/281203)
Region Coverage: 28.44% (42349/148886)
Branch Coverage: 25.02% (21520/86002)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e5717fb37a1e403b361eda8caed85ba0759385a5_e5717fb37a1e403b361eda8caed85ba0759385a5/report/index.html

@hust-hhb hust-hhb mentioned this pull request Nov 8, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hust-hhb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.04% (9903/26035)
Line Coverage: 29.21% (82823/283564)
Region Coverage: 28.35% (42554/150113)
Branch Coverage: 24.90% (21568/86614)
Coverage Report: http://coverage.selectdb-in.cc/coverage/452eba32fbcc95e9b0fc9fc90a619466e4b9a9aa_452eba32fbcc95e9b0fc9fc90a619466e4b9a9aa/report/index.html

@hust-hhb
Copy link
Contributor Author

run buildall

1 similar comment
@hust-hhb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.32% (9975/26031)
Line Coverage: 29.39% (83508/284101)
Region Coverage: 28.52% (42983/150714)
Branch Coverage: 25.14% (21829/86840)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ca6b5706b06dbf49960a26ed713fda68ee53d331_ca6b5706b06dbf49960a26ed713fda68ee53d331/report/index.html

@hust-hhb
Copy link
Contributor Author

hust-hhb commented Dec 2, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.41% (9995/26022)
Line Coverage: 29.45% (83697/284184)
Region Coverage: 28.57% (43064/150722)
Branch Coverage: 25.19% (21889/86884)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0b6b024275fb42b4e0f7c290cd2b62c2e6ca1559_0b6b024275fb42b4e0f7c290cd2b62c2e6ca1559/report/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

PR approved by anyone and no changes requested.

@hust-hhb
Copy link
Contributor Author

hust-hhb commented Dec 4, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 4, 2024
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.47% (10008/26012)
Line Coverage: 29.52% (83925/284290)
Region Coverage: 28.62% (43127/150686)
Branch Coverage: 25.21% (21918/86944)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3d587b1dffc0e807efd8ebd9bfe5f9699ea8c584_3d587b1dffc0e807efd8ebd9bfe5f9699ea8c584/report/index.html

zhannngchen
zhannngchen previously approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

PR approved by at least one committer and no changes requested.

dataroaring
dataroaring previously approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hust-hhb hust-hhb dismissed stale reviews from dataroaring and zhannngchen via f3ee6b0 December 6, 2024 14:47
@hust-hhb
Copy link
Contributor Author

hust-hhb commented Dec 6, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 6, 2024
@hust-hhb
Copy link
Contributor Author

hust-hhb commented Dec 9, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.49% (10009/26004)
Line Coverage: 29.50% (83911/284444)
Region Coverage: 28.60% (43127/150785)
Branch Coverage: 25.20% (21927/87012)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f3ee6b036ebd9b5a8d656a6e4f38984a24aa398a_f3ee6b036ebd9b5a8d656a6e4f38984a24aa398a/report/index.html

dataroaring
dataroaring approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 10, 2024
@zhannngchen zhannngchen merged commit cebf648 into apache:master Dec 10, 2024
24 of 27 checks passed
mymeiyi added a commit to mymeiyi/doris that referenced this pull request Dec 16, 2024
@mymeiyi
Revert "[improve](mow) merge and remove old version of delete bitmap …
0f01a25 
…when cumulative compaction is done on local mode (apache#41636)"

This reverts commit cebf648.
@bobhan1 bobhan1 mentioned this pull request Mar 13, 2025
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhannngchen zhannngchen zhannngchen approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x dev/2.1.x-conflict dev/3.0.x dev/3.0.x-conflict reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hust-hhb @doris-robot @BiteTheDDDDt @zhannngchen @dataroaring