-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](load) return DataQualityError when filtered rows exceeds limit #47617
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 31865 ms
|
TPC-DS: Total hot run time: 192159 ms
|
ClickBench: Total hot run time: 30.22 s
|
run buildall |
TPC-H: Total hot run time: 31535 ms
|
TPC-DS: Total hot run time: 183577 ms
|
ClickBench: Total hot run time: 30.84 s
|
TeamCity be ut coverage result: |
run buildall |
TPC-H: Total hot run time: 31806 ms
|
TPC-DS: Total hot run time: 190925 ms
|
ClickBench: Total hot run time: 30.67 s
|
TeamCity be ut coverage result: |
run buildall |
TPC-H: Total hot run time: 31282 ms
|
TPC-DS: Total hot run time: 189660 ms
|
ClickBench: Total hot run time: 29.88 s
|
TeamCity be ut coverage result: |
run buildall |
TPC-H: Total hot run time: 31545 ms
|
TPC-DS: Total hot run time: 189477 ms
|
ClickBench: Total hot run time: 30.26 s
|
TeamCity be ut coverage result: |
_num_filtered_rows += filtered_rows; | ||
has_filtered_rows = filtered_rows > 0; | ||
if (stop_processing) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove stop_processing?
run buildall |
run buildall |
TPC-H: Total hot run time: 34230 ms
|
TPC-DS: Total hot run time: 185939 ms
|
ClickBench: Total hot run time: 30.92 s
|
run buildall |
TPC-H: Total hot run time: 32500 ms
|
TPC-DS: Total hot run time: 193463 ms
|
ClickBench: Total hot run time: 31.1 s
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
run buildall |
TPC-H: Total hot run time: 32530 ms
|
TPC-DS: Total hot run time: 185517 ms
|
ClickBench: Total hot run time: 30.85 s
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
run buildall |
TPC-H: Total hot run time: 32428 ms
|
TPC-DS: Total hot run time: 192986 ms
|
ClickBench: Total hot run time: 30.81 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
What problem does this PR solve?
Issue Number: DORIS-17408
Problem Summary:
When the load is canceled due to an excessive number of filtered rows in
CsvReader
, the end of stream flag is set, but an error is not returned. As a result, the following confusing message is shown to the user:This PR addresses the issue by returning a
DataQualityError
in such cases. The updated message will be:Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)