[fix](cloud) dup FDCache reset before FileCache dtor causing crash #48915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is another FDCache reset near line 788, and this previous dup one deconstruct its mutex before BlockFileCache destory in FileCacheFactory thus causing BE crash on following stack: SIGSEGV address not mapped to object (@0x68) received by PID 222738 (TID 222917 OR 0x7505dc800640) from PID 104; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /mnt/disk3/pipeline/repo/selectdb-core_selectdb-second-branch/be/src/common/signal_handler.h:421 1# PosixSignals::chained_handler(int, siginfo*, void*) [clone .part.0] in /home/qatest/jdk/java-17-openjdk-amd64/lib/server/libjvm.so 2# JVM_handle_linux_signal in /home/qatest/jdk/java-17-openjdk-amd64/lib/server/libjvm.so 3# 0x0000750666842520 in /lib/x86_64-linux-gnu/libc.so.6 4# __pthread_rwlock_wrlock at ./nptl/pthread_rwlock_wrlock.c:26 5# doris::io::FDCache::remove_file_reader(std::pair<doris::io::UInt128Wrapper, unsigned long> const&) at /mnt/disk3/pipeline/repo/selectdb-core_selectdb-second-branch/be/src/io/cache/fs_file_cache_storag e.cpp:86 6# doris::io::FSFileCacheStorage::remove(doris::io::FileCacheKey const&) at /mnt/disk3/pipeline/repo/selectdb-core_selectdb-second-branch/be/src/io/cache/fs_file_cache_storage.cpp:203 Signed-off-by: zhengyu <[email protected]>
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 32753 ms |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
TPC-DS: Total hot run time: 192678 ms |
ClickBench: Total hot run time: 31.53 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Yukang-Lian
approved these changes
Mar 12, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
…48915) There is another FDCache reset near line 788, and this previous dup one deconstruct its mutex before BlockFileCache destory in FileCacheFactory thus causing BE crash on following stack: SIGSEGV address not mapped to object (@0x68) received by PID 222738 (TID 222917 OR 0x7505dc800640) from PID 104; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /mnt/disk3/pipeline/repo/selectdb-core_selectdb-second-branch/be/src/common/signal_handler.h:421 1# PosixSignals::chained_handler(int, siginfo*, void*) [clone .part.0] in /home/qatest/jdk/java-17-openjdk-amd64/lib/server/libjvm.so 2# JVM_handle_linux_signal in /home/qatest/jdk/java-17-openjdk-amd64/lib/server/libjvm.so 3# 0x0000750666842520 in /lib/x86_64-linux-gnu/libc.so.6 4# __pthread_rwlock_wrlock at ./nptl/pthread_rwlock_wrlock.c:26 5# doris::io::FDCache::remove_file_reader(std::pair<doris::io::UInt128Wrapper, unsigned long> const&) at /mnt/disk3/pipeline/repo/selectdb-core_selectdb-second-branch/be/src/io/cache/fs_file_cache_storag e.cpp:86 6# doris::io::FSFileCacheStorage::remove(doris::io::FileCacheKey const&) at /mnt/disk3/pipeline/repo/selectdb-core_selectdb-second-branch/be/src/io/cache/fs_file_cache_storage.cpp:203
dataroaring
pushed a commit
that referenced
this pull request
Mar 13, 2025
…ing crash #48915 (#49016) Cherry-picked from #48915 Co-authored-by: zhengyu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is another FDCache reset near line 788, and this previous dup one deconstruct its mutex before BlockFileCache destory in FileCacheFactory thus causing BE crash on following stack:
SIGSEGV address not mapped to object (@0x68) received by PID 222738 (TID 222917 OR 0x7505dc800640) from PID 104; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /mnt/disk3/pipeline/repo/selectdb-core_selectdb-second-branch/be/src/common/signal_handler.h:421 1# PosixSignals::chained_handler(int, siginfo*, void*) [clone .part.0] in /home/qatest/jdk/java-17-openjdk-amd64/lib/server/libjvm.so 2# JVM_handle_linux_signal in /home/qatest/jdk/java-17-openjdk-amd64/lib/server/libjvm.so 3# 0x0000750666842520 in /lib/x86_64-linux-gnu/libc.so.6 4# __pthread_rwlock_wrlock at ./nptl/pthread_rwlock_wrlock.c:26 5# doris::io::FDCache::remove_file_reader(std::pair<doris::io::UInt128Wrapper, unsigned long> const&) at /mnt/disk3/pipeline/repo/selectdb-core_selectdb-second-branch/be/src/io/cache/fs_file_cache_storag e.cpp:86
6# doris::io::FSFileCacheStorage::remove(doris::io::FileCacheKey const&) at /mnt/disk3/pipeline/repo/selectdb-core_selectdb-second-branch/be/src/io/cache/fs_file_cache_storage.cpp:203
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)