-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix business exception #12136
Fix business exception #12136
Conversation
@songxiaosheng @wxbty PTAL |
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -85,6 +86,7 @@ public void handleMethodException(Invocation invocation, Throwable throwable) { | |||
eventType = MetricsEvent.Type.NETWORK_EXCEPTION; | |||
} | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (e.isBiz()) {
eventType = MetricsEvent.Type.BUSINESS_FAILED;
}
Can this code be deleted directly?
I'm not sure if a business exception occurs, is it possible to enter the onError method, although the comment says frame exception. If it enters onError, it will record two biz exceptions. If it does not enter, this line of code is redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might throw by Filter by custom
What is the purpose of the change
Brief changelog
Verifying this change
Checklist