Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize generateMethodContent to avoid unnecessary StringBuilder cre… #14904

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

aruato
Copy link
Contributor

@aruato aruato commented Nov 18, 2024

…ation

What is the purpose of the change?

avoid unnecessary StringBuilder creation

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@wcy666103
Copy link
Contributor

ci fixed in apache/dubbo-samples#1195

@AlbumenJ AlbumenJ merged commit acf6e8d into apache:3.3 Nov 20, 2024
12 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants