-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try register Service Instance after export #15113
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15113 +/- ##
============================================
+ Coverage 60.73% 60.77% +0.03%
- Complexity 10861 10879 +18
============================================
Files 1882 1882
Lines 86007 86013 +6
Branches 12886 12886
============================================
+ Hits 52236 52272 +36
+ Misses 28326 28298 -28
+ Partials 5445 5443 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@CrazyHZM @chickenlj PTAL |
...ubbo-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultApplicationDeployer.java
Show resolved
Hide resolved
ReferenceConfigTest,ServiceConfigTest,DubboBootstrapTest,MultipleRegistryCenterServiceDiscoveryRegistryIntegrationTest of dubbo-config-api might be affected as sometimes RpcException with
|
|
Maybe we should enhance the UT |
#15164 might solve it. |
What is the purpose of the change?
When
DubboBootstrap
starts without anyServiceConfig
,ServiceInstance
will be no longer registered even thoughServiceConfig
exports later.Checklist