Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try register Service Instance after export #15113

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Feb 8, 2025

What is the purpose of the change?

When DubboBootstrap starts without any ServiceConfig, ServiceInstance will be no longer registered even though ServiceConfig exports later.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.77%. Comparing base (22395f8) to head (0994d6e).
Report is 36 commits behind head on 3.3.

Files with missing lines Patch % Lines
...ubbo/config/deploy/DefaultApplicationDeployer.java 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15113      +/-   ##
============================================
+ Coverage     60.73%   60.77%   +0.03%     
- Complexity    10861    10879      +18     
============================================
  Files          1882     1882              
  Lines         86007    86013       +6     
  Branches      12886    12886              
============================================
+ Hits          52236    52272      +36     
+ Misses        28326    28298      -28     
+ Partials       5445     5443       -2     
Flag Coverage Δ
integration-tests 33.08% <80.00%> (+0.09%) ⬆️
samples-tests 29.22% <80.00%> (+0.03%) ⬆️
unit-tests 58.92% <80.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ
Copy link
Member Author

@CrazyHZM @chickenlj PTAL

@CrazyHZM CrazyHZM merged commit bc729af into apache:3.3 Feb 11, 2025
19 checks passed
@zrlw
Copy link
Contributor

zrlw commented Feb 22, 2025

ReferenceConfigTest,ServiceConfigTest,DubboBootstrapTest,MultipleRegistryCenterServiceDiscoveryRegistryIntegrationTest of dubbo-config-api might be affected as sometimes RpcException with Address already in use will be thrown.
see https://github.com/apache/dubbo/actions/runs/13462589128/job/37621771946

2025-02-21T18:35:26.8596499Z [ERROR]   ReferenceConfigTest.testClassLoader:1164 » Rpc Fail to start server(url: dubbo://10.1.0.216:20880/org.apache.dubbo.config.api.DemoService?anyhost=true&application=Test&background=false&bind.ip=10.1.0.216&bind.port=20880&channel.readonly.sent=true&codec=dubbo&deprecated=false&dubbo=2.0.2&dynamic=true&executor-management-mode=isolation&file-cache=true&generic=false&heartbeat=60000&interface=org.apache.dubbo.config.api.DemoService&methods=callInnerClass,echo,getBox,getUsers,sayName,throwDemoException&pid=236855&register=false&release=3.3.4-SNAPSHOT&side=provider&timestamp=1740162893508) Failed to bind NettyServer on /0.0.0.0:20880, cause: Address already in use
...

@zrlw
Copy link
Contributor

zrlw commented Feb 22, 2025

Build and Test Scheduled On 3.3 https://github.com/apache/dubbo/actions/runs/13269479987/job/37046175125 which just runned after this PR merging into 3.3:

2025-02-11T18:39:00.4118796Z [ERROR] Errors: 
2025-02-11T18:39:00.4124586Z [ERROR]   ServiceConfigTest.testMethodConfigWithConfiguredArgumentType:492 » Rpc Fail to start server(url: dubbo://10.1.0.109:20880/org.apache.dubbo.config.api.DemoService?anyhost=true&application=app&background=false&bind.ip=10.1.0.109&bind.port=20880&channel.readonly.sent=true&codec=dubbo&deprecated=false&dubbo=2.0.2&dynamic=true&executor-management-mode=isolation&export=true&file-cache=true&generic=false&heartbeat=60000&interface=org.apache.dubbo.config.api.DemoService&methods=callInnerClass,echo,getBox,getUsers,sayName,throwDemoException&pid=236894&register=false&release=3.3.4-SNAPSHOT&sayName.0.callback=false&sayName.return=true&sayName.sent=true&side=provider&timestamp=1739299104130) Failed to bind NettyServer on /0.0.0.0:20880, cause: Address already in use
2025-02-11T18:39:00.4131440Z [ERROR]   MultipleRegistryCenterServiceDiscoveryRegistryIntegrationTest.integrate:152 » Runtime org.apache.dubbo.rpc.RpcException: Fail to start server(url: dubbo://10.1.0.109:20880/org.apache.dubbo.config.integration.multiple.servicediscoveryregistry.MultipleRegistryCenterServiceDiscoveryRegistryService?anyhost=true&application=multiple-registry-center-provider-for-service-discovery-registry-protocol&async=false&background=false&bind.ip=10.1.0.109&bind.port=20880&channel.readonly.sent=true&codec=dubbo&deprecated=false&dubbo=2.0.2&dynamic=true&executor-management-mode=isolation&file-cache=true&generic=false&heartbeat=60000&interface=org.apache.dubbo.config.integration.multiple.servicediscoveryregistry.MultipleRegistryCenterServiceDiscoveryRegistryService&methods=hello&pid=236894&prefer.serialization=hessian2,fastjson2&release=3.3.4-SNAPSHOT&service-name-mapping=true&side=provider&timestamp=1739299132226) Failed to bind NettyServer on /0.0.0.0:20880, cause: Address already in use

@AlbumenJ
Copy link
Member Author

Build and Test Scheduled On 3.3 https://github.com/apache/dubbo/actions/runs/13269479987/job/37046175125 which just runned after this PR merging into 3.3:

2025-02-11T18:39:00.4118796Z [ERROR] Errors: 
2025-02-11T18:39:00.4124586Z [ERROR]   ServiceConfigTest.testMethodConfigWithConfiguredArgumentType:492 » Rpc Fail to start server(url: dubbo://10.1.0.109:20880/org.apache.dubbo.config.api.DemoService?anyhost=true&application=app&background=false&bind.ip=10.1.0.109&bind.port=20880&channel.readonly.sent=true&codec=dubbo&deprecated=false&dubbo=2.0.2&dynamic=true&executor-management-mode=isolation&export=true&file-cache=true&generic=false&heartbeat=60000&interface=org.apache.dubbo.config.api.DemoService&methods=callInnerClass,echo,getBox,getUsers,sayName,throwDemoException&pid=236894&register=false&release=3.3.4-SNAPSHOT&sayName.0.callback=false&sayName.return=true&sayName.sent=true&side=provider&timestamp=1739299104130) Failed to bind NettyServer on /0.0.0.0:20880, cause: Address already in use
2025-02-11T18:39:00.4131440Z [ERROR]   MultipleRegistryCenterServiceDiscoveryRegistryIntegrationTest.integrate:152 » Runtime org.apache.dubbo.rpc.RpcException: Fail to start server(url: dubbo://10.1.0.109:20880/org.apache.dubbo.config.integration.multiple.servicediscoveryregistry.MultipleRegistryCenterServiceDiscoveryRegistryService?anyhost=true&application=multiple-registry-center-provider-for-service-discovery-registry-protocol&async=false&background=false&bind.ip=10.1.0.109&bind.port=20880&channel.readonly.sent=true&codec=dubbo&deprecated=false&dubbo=2.0.2&dynamic=true&executor-management-mode=isolation&file-cache=true&generic=false&heartbeat=60000&interface=org.apache.dubbo.config.integration.multiple.servicediscoveryregistry.MultipleRegistryCenterServiceDiscoveryRegistryService&methods=hello&pid=236894&prefer.serialization=hessian2,fastjson2&release=3.3.4-SNAPSHOT&service-name-mapping=true&side=provider&timestamp=1739299132226) Failed to bind NettyServer on /0.0.0.0:20880, cause: Address already in use

Maybe we should enhance the UT

@zrlw
Copy link
Contributor

zrlw commented Feb 26, 2025

Maybe we should enhance the UT

#15164 might solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants