FIX gRPC-related URL object caused a NullPointerException (NPE) #15157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15157 +/- ##
============================================
- Coverage 60.74% 60.70% -0.04%
- Complexity 10880 10881 +1
============================================
Files 1884 1884
Lines 86050 86055 +5
Branches 12893 12894 +1
============================================
- Hits 52268 52242 -26
- Misses 28333 28359 +26
- Partials 5449 5454 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AlbumenJ
requested changes
Feb 19, 2025
dubbo-common/src/main/java/org/apache/dubbo/common/utils/UrlUtils.java
Outdated
Show resolved
Hide resolved
Comment on lines
284
to
288
| ExtensionLoader<HeaderFilter> headerFilterExtensionLoader = | ||
| frameworkModel.getExtensionLoader(HeaderFilter.class); | ||
| headerFilters = headerFilterExtensionLoader | ||
| .getActivateExtension(invoker.getUrl(), HEADER_FILTERS_CACHE) | ||
| .toArray(new HeaderFilter[0]); |
There was a problem hiding this comment.
Yes, I've already verified it.
There was a problem hiding this comment.
You are right, they are no different. I just didn't notice that this piece of code caused me to write exactly the same code.
Stellar1999
force-pushed
the
FIX-Service-NPE
branch
from
8a8822c to
321c2c7
Compare
AlbumenJ
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
fix issue #15108
Checklist