-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX gRPC-related URL object caused a NullPointerException (NPE) #15157
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15157 +/- ##
============================================
- Coverage 60.74% 60.70% -0.04%
- Complexity 10880 10881 +1
============================================
Files 1884 1884
Lines 86050 86055 +5
Branches 12893 12894 +1
============================================
- Hits 52268 52242 -26
- Misses 28333 28359 +26
- Partials 5449 5454 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dubbo-common/src/main/java/org/apache/dubbo/common/utils/UrlUtils.java
Outdated
Show resolved
Hide resolved
ExtensionLoader<HeaderFilter> headerFilterExtensionLoader = | ||
frameworkModel.getExtensionLoader(HeaderFilter.class); | ||
headerFilters = headerFilterExtensionLoader | ||
.getActivateExtension(invoker.getUrl(), HEADER_FILTERS_CACHE) | ||
.toArray(new HeaderFilter[0]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will load success here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I've already verified it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, they are no different. I just didn't notice that this piece of code caused me to write exactly the same code.
8a8822c
to
321c2c7
Compare
What is the purpose of the change?
fix issue #15108
Checklist