Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【3.0】Enhance and fix check config #8483

Merged
merged 3 commits into from
Aug 23, 2021

Conversation

CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented Aug 12, 2021

What is the purpose of the change

1.fix check config anbout registry and config cneter
2.metatada report support check config
3.fix typo

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

metadata report support check config
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2021

Codecov Report

Merging #8483 (76c9a4d) into 3.0 (0a07eae) will decrease coverage by 0.49%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8483      +/-   ##
============================================
- Coverage     63.32%   62.83%   -0.50%     
- Complexity      312      313       +1     
============================================
  Files          1104     1113       +9     
  Lines         46258    46692     +434     
  Branches       6977     7029      +52     
============================================
+ Hits          29291    29337      +46     
- Misses        13704    14081     +377     
- Partials       3263     3274      +11     
Impacted Files Coverage Δ
...ient/metadata/store/RemoteMetadataServiceImpl.java 70.42% <0.00%> (ø)
.../registry/zookeeper/ZookeeperServiceDiscovery.java 83.33% <0.00%> (+4.68%) ⬆️
...nfig/bootstrap/builders/MetadataReportBuilder.java 92.68% <33.33%> (-4.69%) ⬇️
.../report/support/AbstractMetadataReportFactory.java 63.15% <33.33%> (-13.77%) ⬇️
...apache/dubbo/registry/ListenerRegistryWrapper.java 55.07% <50.00%> (-1.65%) ⬇️
...ubbo/registry/support/AbstractRegistryFactory.java 70.88% <61.90%> (-5.51%) ⬇️
...e/dubbo/registry/integration/RegistryProtocol.java 59.09% <71.42%> (-0.18%) ⬇️
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 70.42% <72.72%> (+0.39%) ⬆️
...registry/zookeeper/util/CuratorFrameworkUtils.java 84.78% <75.00%> (-8.25%) ⬇️
.../dubbo/metadata/report/MetadataReportInstance.java 82.35% <85.71%> (-2.03%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a07eae...76c9a4d. Read the comment docs.

@AlbumenJ AlbumenJ added this to the 3.0.3 milestone Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants