Fix partitioning on timestamp field with year and month transformations #12443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes apache#12442 Add a test case for creating a table partitioned by year and month in `TestCreateTable.java`. * Add `testCreateTablePartitionedByYearAndMonth` method to verify table creation with `PARTITIONED BY (year(completion_date), month(completion_date))`. * Check that the table is created successfully with the correct schema and partitioning. * Ensure the table does not have the default format set. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/apache/iceberg/issues/12442?shareId=XXXX-XXXX-XXXX-XXXX).
…ations on the same timestamp field and add tests for creating tables with such partitioning. * **PartitionSpec.java** - Update `Builder` class to handle multiple partition transformations on the same timestamp field - Add logic to check for redundant partitions and throw an exception if found - Modify `checkAndAddPartitionName` method to handle multiple transformations - Ensure `build` method validates the new partitioning logic * **TestCreateTable.java** - Add test case for creating a table with `PARTITIONED BY (year(completion_date), month(completion_date))` - Verify table creation with correct partitioning - Ensure test case covers both singular and plural forms of transformations
|
@tousifanwar11 Can you provide more context on what you're trying to achieve? The partitioning schemes are redundant: The month partitioning also covers for the year partitioning 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12442
Add a test case for creating a table partitioned by year and month in
TestCreateTable.java.testCreateTablePartitionedByYearAndMonthmethod to verify table creation withPARTITIONED BY (year(completion_date), month(completion_date)).For more details, open the Copilot Workspace session.