Spark-3.5: Add procedure to compute partition stats #12451
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajantha-bhat
changed the title
singhpk234
reviewed
Mar 4, 2025
| LOG.info("Computing partition stats for {} (branch {})", table.name(), branch); | ||
| PartitionStatisticsFile statisticsFile; | ||
| try { | ||
| statisticsFile = PartitionStatsHandler.computeAndWriteStatsFile(table, branch); |
There was a problem hiding this comment.
[doubt] wouldn't it be better if we do stats computation in executor, rather than just computing it in driver in a multi-threaded way ?
There was a problem hiding this comment.
We did benchmarks and it turns out local algorithm is more performant than distributed way.
#9437 (comment)
So, going with non-distributed way.
There was a problem hiding this comment.
That makes sense, thank you for sharing the benchmark, just for my understanding what was the machine configuration used for running the benchmark ?
There was a problem hiding this comment.
It was JMH benchmarks on my machine (macbook m2 max), Anton also did similar test and commented on that PR.
#9437 (comment)
api/src/main/java/org/apache/iceberg/actions/ComputePartitionStats.java
Outdated
Show resolved
Hide resolved
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #12450 (Hence kept in Draft).
Fixes: #10106