Avro: Add variant readers and writers #12457
Open
+448
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
force-pushed
the
avro-support-variant
branch
from
9aad1b4 to
b18a880
Compare
aihuaxu
reviewed
Mar 6, 2025
core/src/main/java/org/apache/iceberg/data/avro/DataWriter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/iceberg/avro/GenericAvroReader.java
Outdated
Show resolved
Hide resolved
| case ARRAY: | ||
| // for now, generate an object instead of an array | ||
| case OBJECT: | ||
| ShreddedObject object = Variants.object(metadata); |
There was a problem hiding this comment.
Seems we only have fully shredded objects here. Should we add partial shredded objects?
There was a problem hiding this comment.
This produces a variant in memory, not a serialized variant. The writer is free to serialize however it chooses, although this is currently not intended to exercise shredding paths that need records to have a more stable structure in order to make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds readers and writers for Variants in Avro. Avro generics, Iceberg generics, and the internal data model are supported.
Variant values are tested using
RandomVariantsto extend random data generation.