Spark: Add some tests for variant fixup #12497
Open
+474
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XBaith
commented
Mar 11, 2025
| import org.apache.iceberg.variants.Variants; | ||
|
|
||
| public class RandomVariants { | ||
| private RandomVariants() {} |
There was a problem hiding this comment.
Copy from core/src/test/java/org/apache/iceberg/RandomVariants.java, will rebase when the PR is merged
sfc-gh-aixu
reviewed
Mar 11, 2025
| @@ -54,6 +54,10 @@ static VariantMetadata from(ByteBuffer buffer) { | |||
| return SerializedMetadata.from(buffer); | |||
| } | |||
|
|
|||
| static VariantMetadata empty() { | |||
| return SerializedMetadata.EMPTY_V1_METADATA; | |||
| } | |||
There was a problem hiding this comment.
Can you add the implementation for PruneColumnsWithoutReordering class?
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestSparkFixupTypes.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #12473
The implementation of variant in various visitors has been basically completed in #11831. Since Spark3 does not support the variant type, this PR only adds preliminary work and unit tests.