-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix hbase/rocksdb shard bug #1306
Conversation
Change-Id: Ifce3d450712104c067a57c361351c9e047bc0cfa
Codecov Report
@@ Coverage Diff @@
## master #1306 +/- ##
============================================
+ Coverage 62.11% 62.33% +0.22%
Complexity 5772 5772
============================================
Files 377 377
Lines 31501 31502 +1
Branches 4413 4412 -1
============================================
+ Hits 19566 19638 +72
+ Misses 9946 9871 -75
- Partials 1989 1993 +4
Continue to review full report at Codecov.
|
List<Shard> shards = new ArrayList<>(count); | ||
while (Bytes.compare(offset, end) < 0) { | ||
while (Bytes.compare(offset, end) < 0 && !finished) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the test not covered? prefer to add one test case
Change-Id: I75b33c8cff9c7e48fc8f44e9e175f9365a143ee3
Change-Id: I7cbdaccf8a79227bcac2bdb953e11faf2e6da69b
Change-Id: Ifce3d450712104c067a57c361351c9e047bc0cfa