Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact: unify naming of degree for oltp algorithms #1433

Merged
merged 9 commits into from
May 12, 2021
Merged

refact: unify naming of degree for oltp algorithms #1433

merged 9 commits into from
May 12, 2021

Conversation

imbajin
Copy link
Member

@imbajin imbajin commented Apr 27, 2021 •
edited
Loading

Note: also keep degree for alias in Step* request

@imbajin imbajin requested review from Linary and zhoney April 27, 2021 11:27
@codecov
Copy link

codecov bot commented Apr 27, 2021 •
edited
Loading

Codecov Report

Merging #1433 (e267a53) into master (4907886) will increase coverage by 0.01%.
The diff coverage is 1.38%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1433      +/-   ##
============================================
+ Coverage     62.25%   62.27%   +0.01%     
- Complexity     5861     5863       +2     
============================================
  Files           381      381              
  Lines         32139    32139              
  Branches       4504     4504              
============================================
+ Hits          20009    20014       +5     
+ Misses        10076    10071       -5     
  Partials       2054     2054
Impacted Files Coverage Δ Complexity Δ
.../hugegraph/api/traversers/AllShortestPathsAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...a/com/baidu/hugegraph/api/traversers/CountAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...baidu/hugegraph/api/traversers/CrosspointsAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...graph/api/traversers/CustomizedCrosspointsAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...u/hugegraph/api/traversers/CustomizedPathsAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ugegraph/api/traversers/FusiformSimilarityAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...hugegraph/api/traversers/JaccardSimilarityAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...m/baidu/hugegraph/api/traversers/KneighborAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...va/com/baidu/hugegraph/api/traversers/KoutAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...graph/api/traversers/MultiNodeShortestPathAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4907886...e267a53. Read the comment docs.

javeme
javeme reviewed Apr 28, 2021
View reviewed changes
@imbajin imbajin removed the request for review from zhoney May 6, 2021 12:56
javeme
javeme reviewed May 6, 2021
View reviewed changes
hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/PersonalRankAPI.java
@@ -106,10 +106,10 @@ public String personalRank(@Context GraphManager manager,
private String label;
@JsonProperty("alpha")
private double alpha;
@JsonProperty("degree")
private long degree = Long.valueOf(DEFAULT_DEGREE);
@JsonProperty("max_degree")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this param is not in a step, don't need alias

javeme
javeme previously approved these changes May 7, 2021
View reviewed changes
@imbajin imbajin changed the title doc: unified naming of degree for olap algorithms refact: unify naming of degree for olap algorithms May 7, 2021
@imbajin imbajin changed the title refact: unify naming of degree for olap algorithms refact: unify naming of degree for oltp algorithms May 11, 2021
@Linary Linary merged commit de81038 into master May 12, 2021
@Linary Linary deleted the fix-tp-max-degree branch May 12, 2021 06:15
zhoney pushed a commit that referenced this pull request May 27, 2021
@imbajin @zhoney
refact: unify naming of degree for oltp algorithms (#1433)
906daa4 
* refact: remove redundant packaging
* refact: keep compatible with degree in 'step'
* update api version to 0.61

Change-Id: Ibbfcaab820eed9d4131a5544899a5e3829729201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linary Linary Linary approved these changes

@javeme javeme javeme approved these changes

@zhoney zhoney zhoney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imbajin @Linary @javeme @zhoney