refact: remove source from kneighbor/kout results & unify 'degree ' error info #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also adapt test in client
javeme
reviewed
May 25, 2021
hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/KoutTraverser.java
Outdated
Show resolved
Hide resolved
imbajin
changed the title
imbajin
force-pushed
the
unify-kout
branch
2 times, most recently
from
bf43789 to
7fb1324
Compare
Codecov Report
@@ Coverage Diff @@
## master #1463 +/- ##
============================================
+ Coverage 61.73% 62.17% +0.43%
- Complexity 5842 5864 +22
============================================
Files 381 381
Lines 32177 32177
Branches 4504 4504
============================================
+ Hits 19866 20006 +140
+ Misses 10265 10119 -146
- Partials 2046 2052 +6
Continue to review full report at Codecov.
|
zhoney
requested changes
May 25, 2021
hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/HugeTraverser.java
Outdated
Show resolved
Hide resolved
zhoney
previously approved these changes
May 26, 2021
Linary
previously approved these changes
May 26, 2021
javeme
requested changes
May 27, 2021
hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/PersonalRankAPI.java
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/HugeTraverser.java
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/NeighborRankTraverser.java
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/steps/EdgeStep.java
Show resolved
Hide resolved
zhoney
previously approved these changes
May 27, 2021
javeme
reviewed
May 27, 2021
hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/CountAPI.java
Outdated
Show resolved
Hide resolved
zhoney
approved these changes
May 27, 2021
javeme
approved these changes
May 27, 2021
zhoney
pushed a commit
that referenced
this pull request
May 27, 2021
…rror info (#1463) remove source vertex from kout algorithm unify 'degree ' error info & remove source from kneighbor/kout result
jadepeng
pushed a commit
to jadepeng/hugegraph
that referenced
this pull request
Jun 25, 2021
…rror info (apache#1463) remove source vertex from kout algorithm unify 'degree ' error info & remove source from kneighbor/kout result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also adapt test in client