fix test-module checkstyle #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javeme
reviewed
Apr 24, 2022
hugegraph-test/src/test/java/com/baidu/hugegraph/core/AuthTest.java
Outdated
Show resolved
Hide resolved
hugegraph-test/src/test/java/com/baidu/hugegraph/core/AuthTest.java
Outdated
Show resolved
Hide resolved
|
It seems that renaming to "test" package will trigger running all tests, but we expect all tests to be executed in multiple stages |
JackyYangPassion
force-pushed
the
fix-checkstyle-hugegraph-test
branch
from
8e71489 to
21cc1b6
Compare
|
ci error: Error: Tests run: 727, Failures: 1, Errors: 0, Skipped: 81, Time elapsed: 229.553 s <<< FAILURE! - in com.baidu.hugegraph.core.CoreTestSuite
Error: testGremlinJobAndRestore(com.baidu.hugegraph.core.TaskCoreTest) Time elapsed: 1.215 s <<< FAILURE!
java.lang.AssertionError: expected:<CANCELLING> but was:<FAILED>
at com.baidu.hugegraph.core.TaskCoreTest.testGremlinJobAndRestore(TaskCoreTest.java:629) |
javeme
reviewed
Apr 26, 2022
hugegraph-test/src/main/java/com/baidu/hugegraph/core/VertexCoreTest.java
Show resolved
Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/core/TaskCoreTest.java
Outdated
Show resolved
Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/core/AuthTest.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1842 +/- ##
============================================
+ Coverage 66.91% 70.96% +4.05%
Complexity 982 982
============================================
Files 447 447
Lines 38072 38076 +4
Branches 5401 5401
============================================
+ Hits 25475 27022 +1547
+ Misses 10082 8408 -1674
- Partials 2515 2646 +131
Continue to review full report at Codecov.
|
javeme
previously approved these changes
Apr 26, 2022
|
@seagle-yuan seems it's confuse and break the IDE default wrap behavior with 8 space in new line
consider keep the original style is better (or maybe we need a easy way to keep the wrap unify) |
need to update checkstyle version |
javeme
reviewed
May 4, 2022
hugegraph-test/src/main/java/com/baidu/hugegraph/api/MetricsApiTest.java
Outdated
Show resolved
Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/core/AuthTest.java
Outdated
Show resolved
Hide resolved
|
Change the checkstyle version and keep the original style lambda alignment. At present, this module has been reduced from 1500+ to 900+. It is expected to be repaired this week mvn compile checkstyle:checkstyle
|
|
please rebase latest master branch |
JackyYangPassion
force-pushed
the
fix-checkstyle-hugegraph-test
branch
from
5f72ead to
b95626a
Compare
javeme
reviewed
May 8, 2022
| @@ -209,7 +210,8 @@ public void testEdgeCacheClearWhenUpdateVertex() { | |||
| Whitebox.invoke(cache, "edgesCache", "size")); | |||
|
|
|||
| cache.addVertexProperty(new HugeVertexProperty<>(v1, | |||
| cache.graph().schema().getPropertyKey("name"), | |||
| cache.graph().schema() | |||
| .getPropertyKey("name"), | |||
There was a problem hiding this comment.
Can you give a code example?
hugegraph-test/src/main/java/com/baidu/hugegraph/unit/core/SecurityManagerTest.java
Outdated
Show resolved
Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/unit/core/SecurityManagerTest.java
Outdated
Show resolved
Hide resolved
seagle-yuan
suggested changes
May 10, 2022
hugegraph-test/src/main/java/com/baidu/hugegraph/unit/cassandra/CassandraTest.java
Show resolved
Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/unit/core/RolePermissionTest.java
Show resolved
Hide resolved
javeme
approved these changes
May 11, 2022
seagle-yuan
approved these changes
May 11, 2022
imbajin
approved these changes
May 12, 2022
imbajin
changed the title
|
seems didn't move java class to test/java |
javeme
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix hugegraph-test checkstyle issue
TODO: move java class to test/java