Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace APPLICATION_JSON with TEXT_PLAIN in dynamic create graph api #1888

Merged
merged 1 commit into from
May 18, 2022

Conversation

simon824
Copy link
Member

@simon824 simon824 commented May 17, 2022

The format of the graph instance config is text instead of json
image

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #1888 (4d1d6f9) into master (335f0ea) will increase coverage by 4.28%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1888      +/-   ##
============================================
+ Coverage     66.75%   71.04%   +4.28%     
- Complexity      728      980     +252     
============================================
  Files           451      451              
  Lines         38207    38207              
  Branches       5407     5407              
============================================
+ Hits          25506    27144    +1638     
+ Misses        10184     8413    -1771     
- Partials       2517     2650     +133     
Impacted Files Coverage Δ
...api/src/main/java/com/baidu/hugegraph/api/API.java 74.11% <ø> (ø)
...ava/com/baidu/hugegraph/api/profile/GraphsAPI.java 0.00% <ø> (ø)
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 80.14% <0.00%> (+0.20%) ⬆️
...c/main/java/com/baidu/hugegraph/task/HugeTask.java 72.22% <0.00%> (+0.30%) ⬆️
.../baidu/hugegraph/backend/tx/SchemaTransaction.java 89.31% <0.00%> (+0.38%) ⬆️
...gegraph/backend/cache/CachedSchemaTransaction.java 91.30% <0.00%> (+0.48%) ⬆️
...om/baidu/hugegraph/task/StandardTaskScheduler.java 76.15% <0.00%> (+0.48%) ⬆️
.../main/java/com/baidu/hugegraph/util/Consumers.java 56.84% <0.00%> (+0.68%) ⬆️
...a/com/baidu/hugegraph/backend/query/Condition.java 79.44% <0.00%> (+0.69%) ⬆️
...a/com/baidu/hugegraph/auth/HugeGraphAuthProxy.java 58.38% <0.00%> (+0.73%) ⬆️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 335f0ea...4d1d6f9. Read the comment docs.

@imbajin
Copy link
Member

imbajin commented May 17, 2022

@wangyao2016 could u take a look for it & check if we need update for other api?

@wangyao2016
Copy link
Contributor

wangyao2016 commented May 17, 2022

@wangyao2016 could u take a look for it?

Sure. IMO both Json and text are fine , PropertiesConfiguration supports parsing two formats. But text is better.

Or we can support both, just remove the limit of @Consumes(APPLICATION_JSON_WITH_CHARSET).

@imbajin
Copy link
Member

imbajin commented May 18, 2022

@wangyao2016 could u take a look for it?

Sure. IMO both Json and text are fine , PropertiesConfiguration supports parsing two formats. But text is better.

Or we can support both, just remove the limit of @Consumes(APPLICATION_JSON_WITH_CHARSET).

could enhance it together next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants