Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tx leak #2031

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Fix tx leak #2031

merged 1 commit into from
Nov 25, 2022

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented Nov 24, 2022

2022-11-24 12:53:40 [gremlin-server-stop] [WARN] o.a.t.g.s.GremlinServer - Exception while closing Graph instance [hugegraph]
java.lang.IllegalStateException: Ensure tx closed in all threads when closing graph 'hugegraph'
	at com.google.common.base.Preconditions.checkState(Preconditions.java:531) ~[guava-25.1-jre.jar:?]
	at com.baidu.hugegraph.util.E.checkState(E.java:68) ~[hugegraph-common-2.1.2.jar:2.1.2.0]
	at com.baidu.hugegraph.StandardHugeGraph.close(StandardHugeGraph.java:948) ~[hugegraph-core-0.13.0.jar:0.13.0.0]
	at org.apache.tinkerpop.gremlin.server.GremlinServer.lambda$null$7(GremlinServer.java:307) ~[gremlin-server-3.5.1.jar:3.5.1]
	at java.util.concurrent.ConcurrentHashMap$KeySetView.forEach(ConcurrentHashMap.java:4649) ~[?:1.8.0_332]
	at org.apache.tinkerpop.gremlin.server.GremlinServer.lambda$stop$8(GremlinServer.java:304) ~[gremlin-server-3.5.1.jar:3.5.1]
	at java.lang.Thread.run(Thread.java:750) [?:1.8.0_332]

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #2031 (41f6242) into master (d340420) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #2031      +/-   ##
============================================
+ Coverage     66.36%   66.41%   +0.05%     
- Complexity      675      976     +301     
============================================
  Files           482      482              
  Lines         41455    41458       +3     
  Branches       5888     5889       +1     
============================================
+ Hits          27511    27536      +25     
+ Misses        11244    11225      -19     
+ Partials       2700     2697       -3     
Impacted Files Coverage Δ
...g/apache/hugegraph/backend/store/ram/RamTable.java 68.30% <100.00%> (+0.64%) ⬆️
...apache/hugegraph/backend/store/BackendSession.java 76.19% <0.00%> (-4.77%) ⬇️
...he/hugegraph/backend/store/BackendSessionPool.java 78.87% <0.00%> (-2.82%) ⬇️
...hugegraph/backend/serializer/BinarySerializer.java 85.58% <0.00%> (ø)
...g/apache/hugegraph/task/StandardTaskScheduler.java 76.05% <0.00%> (+0.49%) ⬆️
...g/apache/hugegraph/backend/store/BackendTable.java 85.11% <0.00%> (+0.59%) ⬆️
...n/java/org/apache/hugegraph/schema/IndexLabel.java 77.27% <0.00%> (+1.13%) ⬆️
...a/org/apache/hugegraph/task/ServerInfoManager.java 75.00% <0.00%> (+1.74%) ⬆️
...hugegraph/backend/store/raft/RaftBackendStore.java 81.72% <0.00%> (+6.45%) ⬆️
...ava/org/apache/hugegraph/backend/LocalCounter.java 68.96% <0.00%> (+10.34%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@z7658329 we need update the version

image

@z7658329
Copy link
Member

z7658329 commented Nov 24, 2022

@z7658329 we need update the version

image

yes. fix in #2033 @imbajin

@javeme javeme merged commit 6c9fe3a into master Nov 25, 2022
@javeme javeme deleted the fix_tx_leak branch November 25, 2022 10:57
@coderzc coderzc added the bug Something isn't working label Nov 25, 2022
@coderzc coderzc added this to the 1.0.0 milestone Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants