chore: cmn algorithm optimization #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2134 +/- ##
============================================
- Coverage 68.59% 65.14% -3.45%
- Complexity 676 977 +301
============================================
Files 481 481
Lines 39701 39704 +3
Branches 5580 5581 +1
============================================
- Hits 27233 25866 -1367
- Misses 9821 11272 +1451
+ Partials 2647 2566 -81
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
javeme
reviewed
Feb 27, 2023
| return callback.apply(result); | ||
| Boolean apply = callback.apply(result); | ||
| while (index < result.size()) { | ||
| result.remove(index); |
There was a problem hiding this comment.
when to cause this behavior?
There was a problem hiding this comment.
We can run the test:
the result is:
javeme
approved these changes
Feb 28, 2023
imbajin
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.