-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): support order by id #2233
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2233 +/- ##
============================================
+ Coverage 68.64% 68.66% +0.01%
Complexity 977 977
============================================
Files 498 498
Lines 40681 40682 +1
Branches 5681 5681
============================================
+ Hits 27927 27934 +7
+ Misses 10055 10047 -8
- Partials 2699 2701 +2
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
please note ci error: Caused by: com.mysql.cj.exceptions.WrongArgumentException:
The connection property 'useSSL' acceptable values are: 'TRUE', 'FALSE', 'YES' or 'NO'.
The value 'disable' is not acceptable. prefer to update |
got it, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of the PR
Main Changes
Verifying these changes
(or)
(or)
This change added tests and can be verified as follows:
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - NO Need