fix：asf invalid notification scheme 'discussions_status' #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2247 +/- ##
=============================================
- Coverage 65.03% 53.61% -11.43%
+ Complexity 979 378 -601
=============================================
Files 498 498
Lines 40682 40684 +2
Branches 5681 5681
=============================================
- Hits 26458 21812 -4646
- Misses 11596 16567 +4971
+ Partials 2628 2305 -323 see 133 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
imbajin
approved these changes
Jul 17, 2023
liuxiaocs7
approved these changes
Jul 18, 2023
imbajin
reviewed
Jul 20, 2023
| @@ -57,5 +57,5 @@ notifications: | |||
| issues: [email protected] | |||
| issues_status: [email protected] | |||
| issues_comment: [email protected] | |||
| discussions_status: [email protected] | |||
| discussions: [email protected] | |||
| discussions_comment: [email protected] | |||
There was a problem hiding this comment.
@Z-HUANT we need also remove discussions_comment for same problem
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Error while running notifications feature from .asf.yaml in incubator-hugegraph!
Main Changes
fix：asf invalid notification scheme 'discussions_status'
Verifying these changes
Does this PR potentially affect the following parts?
fix：asf invalid notification scheme 'discussions_status'
Documentation Status
Doc - TODODoc - DoneDoc - No Need