Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): clean up the code #2456

Merged
merged 5 commits into from
Feb 22, 2024
Merged

fix(server): clean up the code #2456

merged 5 commits into from
Feb 22, 2024

Conversation

msgui
Copy link
Contributor

@msgui msgui commented Feb 21, 2024

Purpose of the PR

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. cassandra Cassandra backend labels Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (5cb9aad) 66.25% compared to head (b48108b) 66.23%.

Files Patch % Lines
.../apache/hugegraph/backend/tx/GraphTransaction.java 36.36% 6 Missing and 1 partial ⚠️
...hugegraph/job/algorithm/comm/LouvainTraverser.java 0.00% 4 Missing ⚠️
...apache/hugegraph/backend/query/ConditionQuery.java 40.00% 0 Missing and 3 partials ⚠️
...raph/traversal/optimize/HugeVertexStepByBatch.java 0.00% 0 Missing and 3 partials ⚠️
...ugegraph/backend/store/memory/InMemoryDBTable.java 0.00% 0 Missing and 2 partials ⚠️
...backend/store/postgresql/PostgresqlSerializer.java 0.00% 0 Missing and 2 partials ⚠️
.../apache/hugegraph/api/filter/LoadDetectFilter.java 0.00% 0 Missing and 1 partial ⚠️
...n/java/org/apache/hugegraph/server/RestServer.java 0.00% 0 Missing and 1 partial ⚠️
...graph/backend/store/cassandra/CassandraTables.java 0.00% 0 Missing and 1 partial ⚠️
.../main/java/org/apache/hugegraph/backend/id/Id.java 0.00% 0 Missing and 1 partial ⚠️
... and 13 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2456      +/-   ##
============================================
- Coverage     66.25%   66.23%   -0.02%     
  Complexity      827      827              
============================================
  Files           511      511              
  Lines         42586    42582       -4     
  Branches       5935     5935              
============================================
- Hits          28214    28205       -9     
- Misses        11563    11564       +1     
- Partials       2809     2813       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 22, 2024
@imbajin imbajin requested a review from VGalaxies February 22, 2024 03:27
@VGalaxies VGalaxies merged commit e79f1a5 into apache:master Feb 22, 2024
18 of 21 checks passed
VGalaxies pushed a commit that referenced this pull request Feb 22, 2024
- replace `size() == 0` with `isEmpty()`
- remove unnecessary unboxing
- remove unnecessary boxing
- replace for loop with enhanced for loop
- replace lambda with method reference
@msgui msgui deleted the clean-code branch March 15, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cassandra Cassandra backend lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants